Skip to content

Commit a9f4f44

Browse files
committed
fix: address review feedback
1 parent 0c8d747 commit a9f4f44

7 files changed

Lines changed: 13 additions & 11 deletions

File tree

webapp/src/ts/components/panel-header/panel-header.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
<mat-icon svgIcon="icon-close"></mat-icon>
66
</a>
77
}
8-
</div>
8+
</div>
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
@if (loading) {
2+
<div class="loader"></div>
3+
}
14
@if (!loading) {
2-
<img class="report-image" [src]="objectUrl" alt="Report" />
3-
}
5+
<img class="report-image" [src]="objectUrl" />
6+
}

webapp/src/ts/components/snackbar/snackbar.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
<span class="snackbar-message">{{message}}</span>
44

55
@if (action) {
6-
<button class="snackbar-action" (click)="action.onClick()">
7-
{{action.label}}
8-
</button>
6+
<span class="snackbar-action" (click)="action.onClick()">
7+
{{action.label}}
8+
</span>
99
}
1010

1111
</span>
12-
</div>
12+
</div>

webapp/src/ts/components/snackbar/snackbar.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { GlobalActions } from '@mm-actions/global';
1212
selector: 'snackbar',
1313
changeDetection: ChangeDetectionStrategy.OnPush,
1414
templateUrl: './snackbar.component.html',
15-
1615
})
1716
export class SnackbarComponent implements OnInit, OnDestroy {
1817
private subscription: Subscription = new Subscription();

webapp/src/ts/modals/check-date/check-date.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@
2020
</p>
2121
}
2222

23-
</mm-modal-layout>
23+
</mm-modal-layout>

webapp/src/ts/modals/feedback/feedback.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@
1818

1919
</div>
2020
</form>
21-
</mm-modal-layout>
21+
</mm-modal-layout>

webapp/src/ts/modules/messages/messages-more-menu.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
</button>
1212
</mat-menu>
1313
</section>
14-
}
14+
}

0 commit comments

Comments
 (0)