Skip to content

Commit d6e86b0

Browse files
committed
🔧 chore(ci): update AWS credentials and CI configurations
- add AWS credentials to load services and build test node in aws_dev.yml - uncomment and enable Amazon ECR login in aws_dev.yml - replace environment variable condition from TRAVIS/GITHUB_ACTION to CI_ENV in test_helper.php Signed-off-by: domenico <domenico@translated.net>
1 parent 631c74f commit d6e86b0

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

.github/workflows/aws_dev.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ jobs:
5757
submodules: recursive
5858

5959
- name: Load services and build test node
60+
with:
61+
aws-access-key-id: ${{ env.TEST_AWS_ACCESS_KEY_ID }}
62+
aws-secret-access-key: ${{ secrets.TEST_AWS_SECRET_ACCESS_KEY }}
63+
aws-region: ${{ env.AWS_REGION }}
6064
run: |
6165
docker compose -f docker/docker-compose-ci.yml build mysql redis > /dev/null 2>&1
6266
docker compose -f docker/docker-compose-ci.yml create mysql redis > /dev/null 2>&1
@@ -92,9 +96,9 @@ jobs:
9296
aws-secret-access-key: ${{ secrets.BETA_AWS_SECRET_ACCESS_KEY }}
9397
aws-region: ${{ env.AWS_REGION }}
9498

95-
# - name: Login to Amazon ECR
96-
# id: login_ecr
97-
# uses: aws-actions/amazon-ecr-login@v1
99+
- name: Login to Amazon ECR
100+
id: login_ecr
101+
uses: aws-actions/amazon-ecr-login@v1
98102

99103
- name: Build, tag, and push image to Amazon ECR for Development
100104
id: build-image

docker

tests/test_helper.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,9 @@
1212
set_include_path(get_include_path() . PATH_SEPARATOR . TEST_DIR);
1313
require_once(PROJECT_ROOT . 'lib/Bootstrap.php');
1414

15-
var_dump(getenv());
16-
1715
if (getenv('USE_LOCAL_DEVELOPMENT_ENV')) {
1816
Bootstrap::start();
19-
} elseif (getenv('TRAVIS') || getenv('GITHUB_ACTION')) {
17+
} elseif (getenv('CI_ENV')) {
2018
Bootstrap::start(new SplFileInfo(TEST_DIR . '/inc/config.travis.ini'), new SplFileInfo(TEST_DIR . '/inc/task_manager_config.ini'));
2119
} else {
2220
Bootstrap::start(new SplFileInfo(TEST_DIR . '/inc/config.local.ini'), new SplFileInfo(TEST_DIR . '/inc/task_manager_config.ini'));

0 commit comments

Comments
 (0)