🐛 fix(ci): relax commit message check for Copilot and GitHub web edits

- add requireEmoji option (default true) to validateCommitMessage so
  PR title stays strict while commit messages accept emoji-less
  conventional-commit format (e.g. "docs(qa): ...")
- auto-skip GitHub web UI patterns (Update/Create/Delete/Rename) in
  relaxed mode
- update workflow to pass requireEmoji: false for commit-messages job
- add 18 new tests for relaxed mode and isGitHubWebEdit (53 total)

Author: Ostico

.github/scripts/commit-message-check.js

@@ -49,26 +49,17 @@ function findTypeForEmoji(emoji) {
     return null;
 }
 
-/**
- * Return true when the subject line is an auto-generated merge commit
- * that should be exempt from conventional-commit rules.
- */
 function isAutoGenerated(subject) {
     return /^Merge /.test(subject);
 }
 
+function isGitHubWebEdit(subject) {
+    return /^(Update|Create|Delete|Rename) .+/.test(subject);
+}
+
 // ── Core validation ──────────────────────────────────────────────────
 
-/**
- * Validate a commit message (or PR title) against the project's
- * conventional-commit spec with emoji prefixes.
- *
- * Only the first line (subject) is validated.
- *
- * @param {string} message  Full commit message or PR title
- * @returns {{ valid: boolean, errors: string[], skipped: boolean }}
- */
-function validateCommitMessage(message) {
+function validateCommitMessage(message, {requireEmoji = true} = {}) {
     const errors = [];
 
     if (!message || typeof message !== 'string') {
@@ -81,72 +72,74 @@ function validateCommitMessage(message) {
         return {valid: false, errors: ['Empty subject line'], skipped: false};
     }
 
-    // Auto-generated merge commits are exempt
     if (isAutoGenerated(subject)) {
         return {valid: true, errors: [], skipped: true};
     }
 
-    // ── Length ────────────────────────────────────────────────────
+    if (!requireEmoji && isGitHubWebEdit(subject)) {
+        return {valid: true, errors: [], skipped: true};
+    }
+
     if (subject.length > MAX_SUBJECT_LENGTH) {
         errors.push(
             `Subject exceeds ${MAX_SUBJECT_LENGTH} characters (${subject.length})`,
         );
     }
 
-    // ── Split emoji from rest ────────────────────────────────────
     const firstSpace = subject.indexOf(' ');
     if (firstSpace === -1) {
         errors.push(
-            'Subject must start with an emoji followed by a space',
+            requireEmoji
+                ? 'Subject must start with an emoji followed by a space'
+                : 'Subject must contain a space',
         );
         return {valid: false, errors, skipped: false};
     }
 
-    const emoji = subject.slice(0, firstSpace);
+    const firstToken = subject.slice(0, firstSpace);
     const rest = subject.slice(firstSpace + 1);
 
-    // ── Emoji lookup ─────────────────────────────────────────────
-    const emojiType = findTypeForEmoji(emoji);
-    if (!emojiType) {
+    const emojiType = findTypeForEmoji(firstToken);
+    const hasEmoji = emojiType !== null;
+
+    if (requireEmoji && !hasEmoji) {
         const validList = Object.entries(EMOJI_TYPE_MAP)
             .map(([e, t]) => `${e} ${t}`)
             .join(', ');
-        errors.push(`Unknown emoji "${emoji}". Valid: ${validList}`);
+        errors.push(`Unknown emoji "${firstToken}". Valid: ${validList}`);
     }
 
-    // ── Parse: <type>[(<scope>)][!]: <description> ───────────────
-    const restMatch = rest.match(/^(\w+)(?:\(([^)]+)\))?(!)?: (.+)$/);
-    if (!restMatch) {
+    const textToParse = hasEmoji ? rest : subject;
+    const formatMatch = textToParse.match(/^(\w+)(?:\(([^)]+)\))?(!)?: (.+)$/);
+    if (!formatMatch) {
         errors.push(
-            'Format after emoji must be: <type>[(<scope>)][!]: <description>',
+            hasEmoji
+                ? 'Format after emoji must be: <type>[(<scope>)][!]: <description>'
+                : 'Format must be: <type>[(<scope>)][!]: <description>',
         );
         return {valid: false, errors, skipped: false};
     }
 
-    const [, type, , , description] = restMatch;
+    const [, type, , , description] = formatMatch;
 
-    // ── Type enum ────────────────────────────────────────────────
     if (!VALID_TYPES.includes(type)) {
         errors.push(
             `Invalid type "${type}". Valid: ${VALID_TYPES.join(', ')}`,
         );
     }
 
-    // ── Emoji ↔ type consistency ─────────────────────────────────
-    if (emojiType && VALID_TYPES.includes(type) && emojiType !== type) {
+    if (hasEmoji && emojiType && VALID_TYPES.includes(type) && emojiType !== type) {
         const correctEmoji = TYPE_EMOJI_MAP[type] || '?';
         errors.push(
-            `Emoji ${emoji} is for "${emojiType}", not "${type}". ` +
+            `Emoji ${firstToken} is for "${emojiType}", not "${type}". ` +
             `Use ${correctEmoji} for "${type}"`,
         );
     }
 
-    // ── No capitalization ────────────────────────────────────────
     if (description && /^[A-Z]/.test(description)) {
         errors.push('Description must start with a lowercase letter');
     }
 
-    // ── No trailing period ───────────────────────────────────────
     if (description && description.endsWith('.')) {
         errors.push('Description must not end with a period');
     }
@@ -162,5 +155,6 @@ module.exports = {
     validateCommitMessage,
     findTypeForEmoji,
     isAutoGenerated,
+    isGitHubWebEdit,
     stripVS16,
 };

.github/scripts/commit-message-check.test.js

@@ -10,6 +10,7 @@ const {
     validateCommitMessage,
     findTypeForEmoji,
     isAutoGenerated,
+    isGitHubWebEdit,
     stripVS16,
 } = require('./commit-message-check.js');
 
@@ -178,7 +179,7 @@ describe('validateCommitMessage – invalid', () => {
     it('no space after emoji', () => {
         const r = validateCommitMessage('\u2728feat: add login');
         assert.equal(r.valid, false);
-        assert.ok(r.errors.some(e => e.includes('Format after emoji')));
+        assert.ok(r.errors.some(e => e.includes('Format')));
     });
 
     it('unknown emoji', () => {
@@ -237,3 +238,106 @@ describe('validateCommitMessage – invalid', () => {
         assert.ok(r.errors.length >= 3, `expected >= 3 errors, got ${r.errors.length}: ${r.errors.join('; ')}`);
     });
 });
+
+// ── isGitHubWebEdit ───────────────────────────────────────────
+
+describe('isGitHubWebEdit', () => {
+    it('detects Update pattern', () => {
+        assert.equal(isGitHubWebEdit('Update pr-readiness-check.yml'), true);
+    });
+
+    it('detects Create pattern', () => {
+        assert.equal(isGitHubWebEdit('Create new-file.md'), true);
+    });
+
+    it('detects Delete pattern', () => {
+        assert.equal(isGitHubWebEdit('Delete old-file.js'), true);
+    });
+
+    it('detects Rename pattern', () => {
+        assert.equal(isGitHubWebEdit('Rename foo.js to bar.js'), true);
+    });
+
+    it('rejects normal commit', () => {
+        assert.equal(isGitHubWebEdit('fix: update login flow'), false);
+    });
+
+    it('rejects partial match at wrong position', () => {
+        assert.equal(isGitHubWebEdit('Please Update the file'), false);
+    });
+});
+
+// ── validateCommitMessage – relaxed mode (requireEmoji: false) ─
+
+describe('validateCommitMessage – relaxed mode', () => {
+    const relaxed = {requireEmoji: false};
+
+    it('accepts emoji-less conventional commit', () => {
+        const r = validateCommitMessage('docs(qa): add full phpdoc for shared ICU detector', relaxed);
+        assert.equal(r.valid, true);
+        assert.equal(r.skipped, false);
+    });
+
+    it('accepts emoji-less commit with scope and !', () => {
+        const r = validateCommitMessage('feat(api)!: remove legacy endpoint', relaxed);
+        assert.equal(r.valid, true);
+    });
+
+    it('accepts emoji-less commit without scope', () => {
+        const r = validateCommitMessage('refactor: share ICU source detection logic across LQA flows', relaxed);
+        assert.equal(r.valid, true);
+    });
+
+    it('still accepts emoji commits in relaxed mode', () => {
+        const r = validateCommitMessage('\u2728 feat: add user login', relaxed);
+        assert.equal(r.valid, true);
+    });
+
+    it('still validates emoji-type consistency in relaxed mode', () => {
+        const r = validateCommitMessage('\u{1F41B} feat: wrong emoji', relaxed);
+        assert.equal(r.valid, false);
+        assert.ok(r.errors.some(e => e.includes('not "feat"')));
+    });
+
+    it('skips GitHub web edit in relaxed mode', () => {
+        const r = validateCommitMessage('Update .github/workflows/pr-readiness-check.yml', relaxed);
+        assert.equal(r.valid, true);
+        assert.equal(r.skipped, true);
+    });
+
+    it('does NOT skip GitHub web edit in strict mode', () => {
+        const r = validateCommitMessage('Update .github/workflows/pr-readiness-check.yml');
+        assert.equal(r.valid, false);
+    });
+
+    it('still rejects invalid type in relaxed mode', () => {
+        const r = validateCommitMessage('feature: add login', relaxed);
+        assert.equal(r.valid, false);
+        assert.ok(r.errors.some(e => e.includes('Invalid type')));
+    });
+
+    it('still rejects capitalized description in relaxed mode', () => {
+        const r = validateCommitMessage('fix: Update broken thing', relaxed);
+        assert.equal(r.valid, false);
+        assert.ok(r.errors.some(e => e.includes('lowercase')));
+    });
+
+    it('still rejects trailing period in relaxed mode', () => {
+        const r = validateCommitMessage('fix: update broken thing.', relaxed);
+        assert.equal(r.valid, false);
+        assert.ok(r.errors.some(e => e.includes('period')));
+    });
+
+    it('still rejects over-length in relaxed mode', () => {
+        const desc = 'a'.repeat(96);
+        const r = validateCommitMessage(`fix: ${desc}`, relaxed);
+        assert.equal(r.valid, false);
+        assert.ok(r.errors.some(e => e.includes('exceeds')));
+    });
+
+    it('skips merge commits in relaxed mode', () => {
+        const r = validateCommitMessage('Merge branch \'main\' into feature', relaxed);
+        assert.equal(r.valid, true);
+        assert.equal(r.skipped, true);
+    });
+});

.github/workflows/commit-message-check.yml

@@ -76,7 +76,7 @@ jobs:
             const failures = [];
             for (const c of commits) {
               const msg = c.commit.message;
-              const result = validateCommitMessage(msg);
+              const result = validateCommitMessage(msg, {requireEmoji: false});
               if (result.skipped) continue;
               if (!result.valid) {
                 const sha = c.sha.slice(0, 7);