fix(tui): remove legacy priority filter shim

Drop the internal priority_only compatibility argument from query_events_for_display so the new v5.3 event tier API has one explicit path: verbosity 0, 1, or 2.

Also address CodeRabbit follow-ups by renaming ambiguous test comprehension variables and documenting the updated Stats E2E event-tier check.

Co-Authored-By: opencode <noreply@opencode.ai>

Author: m4r1k

docs/testing.md

@@ -145,7 +145,7 @@ The numbered E2E tests are defined in `tests/e2e/groups/*.sh`. There are 36 numb
 | 28 | Stats | SQLite stats DB is created with samples and daemon-start event rows |
 | 29 | Stats | Stats writer failure is non-fatal and does not crash monitoring |
 | 30 | Stats | `monitor --once --graph` renders a graph from persisted stats data |
-| 31 | Stats | `monitor --once --events-only` reads events from SQLite |
+| 31 | Stats | `monitor --once --events-only` reads SQLite events and enforces event verbosity tiers |
 | 32 | Stats | Voltage nominal auto-detect re-snaps misreported NUT nominal voltage and records a silent event |
 | 33 | UPS Single | `voltage_sensitivity` avoids 120 V hot-grid false alarms while preserving real brownout detection |
 | 34 | Stats | Pending on-battery and restored notifications coalesce into one brief-outage summary |

src/eneru/tui.py

@@ -480,7 +480,6 @@ def query_events_for_display(
     *,
     max_events: Optional[int] = EVENTS_MAX_ROWS_NORMAL,
     verbosity: int = EVENTS_VERBOSITY_POWER,
-    priority_only: Optional[bool] = None,
     grouped: bool = False,
 ) -> List[str]:
     """Pull events from each UPS's SQLite store, sorted by timestamp.
@@ -497,8 +496,7 @@ def query_events_for_display(
     should fall back to ``parse_log_events`` in that case.
 
     ``verbosity`` selects enabled tiers: ``0`` shows Power Events only,
-    ``1`` adds Diagnostics, and ``2`` adds Lifecycle. ``priority_only`` is
-    accepted as a legacy shim for tests / older internal callers.
+    ``1`` adds Diagnostics, and ``2`` adds Lifecycle.
 
     ``max_events=None`` (or 0) disables the row cap entirely.
 
@@ -507,10 +505,6 @@ def query_events_for_display(
     Lifecycle. Power events are never evicted; diagnostics outrank daemon
     lifecycle context when the cap is hit in verbose mode.
     """
-    if priority_only is not None:
-        # Legacy compatibility: the old boolean API had priority_only=False
-        # mean "show every event type".
-        verbosity = EVENTS_VERBOSITY_POWER if priority_only else EVENTS_VERBOSITY_ALL
     verbosity = _events_verbosity(verbosity)
     multi_ups = config.multi_ups
     rows: List[tuple] = []  # (ts, label, event_type, detail)

tests/test_tui.py

@@ -1636,10 +1636,10 @@ def test_events_only_flat_time_sorted_with_enabled_tiers(
     @pytest.mark.unit
     def test_snapshot_path_honours_verbose_level(self, tmp_path, capsys):
         """5.2.2 (cubic.dev / CodeRabbit P1): the non-events-only branch
-        of run_once also reads events for its tail block. Pre-fix it
-        used the default ``priority_only=True`` and silently ignored
-        ``--verbose``, so diagnostics never surfaced even when the user
-        explicitly asked for them."""
+        of run_once also reads events for its tail block. Pre-fix it used
+        the default event query and silently ignored ``--verbose``, so
+        diagnostics never surfaced even when the user explicitly asked for
+        them."""
         from eneru.tui import run_once
         import time as _time
         config = _events_config(tmp_path)
@@ -1703,7 +1703,7 @@ def test_events_only_length_caps_output(self, tmp_path, capsys):
         run_once(config, events_only=True, length=5)
         out = capsys.readouterr().out
         # Should see exactly 5 lines -- the most-recent 5 ON_BATTERY rows.
-        lines = [l for l in out.splitlines() if "ON_BATTERY" in l]
+        lines = [line for line in out.splitlines() if "ON_BATTERY" in line]
         assert len(lines) == 5
         assert "row-49" in lines[-1]
         assert "row-45" in lines[0]
@@ -1720,7 +1720,7 @@ def test_events_only_length_zero_means_no_cap(self, tmp_path, capsys):
         ])
         run_once(config, events_only=True, length=0)
         out = capsys.readouterr().out
-        lines = [l for l in out.splitlines() if "ON_BATTERY" in l]
+        lines = [line for line in out.splitlines() if "ON_BATTERY" in line]
         assert len(lines) == 40, f"length=0 must show all rows; got {len(lines)}"