cleanup

Author: lofcz

src/FastCloner.Benchmark.CI/Reporting/BenchmarkDiffReporter.cs

@@ -222,20 +222,18 @@ private static string BuildCommentMarkdown(
             return sb.ToString().TrimEnd();
         }
 
-        sb.AppendLine("### Relative FastCloner vs DeepCloner change from latest `next` baseline");
+        sb.AppendLine("### FastCloner vs latest `next` baseline");
         sb.AppendLine();
         sb.AppendLine($"- Baseline generated (UTC): `{baseline.GeneratedAtUtc:yyyy-MM-dd HH:mm:ss}`");
         sb.AppendLine($"- Regression thresholds: time > `{FormatPercent(options.TimeThreshold)}`, alloc > `{FormatPercent(options.AllocThreshold)}`");
-        sb.AppendLine("- Anchor: compare the `FastCloner / DeepCloner` ratio from the baseline run to the current run, so hosted runner speed changes do not count as regressions by themselves.");
-        sb.AppendLine("- Score guide: values below `1.00x` are better than DeepCloner, above `1.00x` are worse.");
         sb.AppendLine();
-        sb.AppendLine("| Status | Benchmark | Time Score (Baseline) | Time Score (Current) | Delta Time Score | Alloc Score (Baseline) | Alloc Score (Current) | Delta Alloc Score |");
-        sb.AppendLine("|---|---|---:|---:|---|---:|---:|---|");
+        sb.AppendLine("| Status | Benchmark | Delta Time | Delta Alloc |");
+        sb.AppendLine("|---|---|---|---|");
 
         foreach (BaselineDiffItem item in diff.Items)
         {
             sb.AppendLine(
-                $"| {FormatStatus(item.Status)} | {item.Benchmark} | {FormatScore(item.BaselineTimeScore)} | {FormatScore(item.CurrentTimeScore)} | {FormatCurrentDelta(item.TimeScoreDeltaRatio, options.SameThreshold, "closer to DeepCloner", "farther from DeepCloner")} | {FormatScore(item.BaselineAllocScore)} | {FormatScore(item.CurrentAllocScore)} | {FormatCurrentDelta(item.AllocScoreDeltaRatio, options.SameThreshold, "closer to DeepCloner", "farther from DeepCloner")} |");
+                $"| {FormatStatus(item.Status)} | {item.Benchmark} | {FormatCurrentDelta(item.TimeScoreDeltaRatio, options.SameThreshold, "faster", "slower")} | {FormatCurrentDelta(item.AllocScoreDeltaRatio, options.SameThreshold, "less", "more")} |");
         }
 
         AppendStatusSection(sb, "Regressions", diff.Items.Where(item => item.Status == DiffStatus.Regression).ToList(), options.SameThreshold);
@@ -296,8 +294,8 @@ private static void AppendStatusSection(
         sb.AppendLine();
         foreach (BaselineDiffItem item in items)
         {
-            string timeDelta = FormatCurrentDelta(item.TimeScoreDeltaRatio, sameThreshold, "closer to DeepCloner", "farther from DeepCloner");
-            string allocDelta = FormatCurrentDelta(item.AllocScoreDeltaRatio, sameThreshold, "closer to DeepCloner", "farther from DeepCloner");
+            string timeDelta = FormatCurrentDelta(item.TimeScoreDeltaRatio, sameThreshold, "faster", "slower");
+            string allocDelta = FormatCurrentDelta(item.AllocScoreDeltaRatio, sameThreshold, "less", "more");
             sb.AppendLine($"- `{item.Benchmark}`: time {timeDelta}, alloc {allocDelta}");
         }
     }

src/FastCloner.Tests/DynamicMaxRecursionDepthTests.cs

@@ -169,7 +169,7 @@ public void TestDeepExactObjectGraph_1500Levels_WithMRD1()
     }
 
     [Test]
-    public void Internal_CloneClassInternalExact_Should_Reset_CallDepth_After_WorkList_Switch()
+    public void Internal_CloneClassInternal_Should_Reset_CallDepth_After_WorkList_Switch()
     {
         ExactNode root = new ExactNode
         {
@@ -186,7 +186,7 @@ public void Internal_CloneClassInternalExact_Should_Reset_CallDepth_After_WorkLi
         FastCloneState state = FastCloneState.Rent();
         try
         {
-            ExactNode? clone = FastClonerGenerator.CloneClassInternalExact(root, state);
+            ExactNode? clone = (ExactNode?)FastClonerGenerator.CloneClassInternal(root, state);
 
             Assert.That(clone, Is.Not.Null);
             Assert.That(state.UseWorkList, Is.True);

src/FastCloner.Tests/TypeBehaviorTests.cs

@@ -210,24 +210,6 @@ public void SetTypeBehavior_Ignore_RootObjectOfIgnoredType_ReturnsNull()
         // Assert
         Assert.That(cloned, Is.Null, "Cloning an object of an globally ignored type should return null.");
     }
-
-    [Test]
-    public void Internal_CloneClassInternalExact_IgnoreTypeBehavior_ReturnsNull()
-    {
-        ClassToBeIgnored original = new ClassToBeIgnored { Data = "Important Data" };
-        FastCloner.SetTypeBehavior<ClassToBeIgnored>(CloneBehavior.Ignore);
-
-        FastCloneState state = FastCloneState.Rent();
-        try
-        {
-            ClassToBeIgnored? cloned = FastClonerGenerator.CloneClassInternalExact(original, state);
-            Assert.That(cloned, Is.Null);
-        }
-        finally
-        {
-            FastCloneState.Return(state);
-        }
-    }
 
     [Test]
     public void SetTypeBehavior_Ignore_ForPrimitiveIntProperty_SetsToDefault()

src/FastCloner/Code/FastClonerGenerator.cs

@@ -608,22 +608,6 @@ private static bool TryGetGenericInterfaceArgument(Type type, Type genericInterf
         return CloneClassInternalTyped(obj, runtimeType, state, metadata);
     }
 
-    internal static T? CloneClassInternalExact<T>(T? obj, FastCloneState state) where T : class
-    {
-        if (obj is null)
-            return null;
-
-        ClonerCache<T>.CacheEntry cacheEntry = ClonerCache<T>.GetCurrent();
-        if (!FastClonerCache.HasActiveTypeBehaviorOverrides && cacheEntry.IsSafe)
-            return obj;
-
-        Type objType = typeof(T);
-        FastClonerCache.TypeCloneMetadata metadata = cacheEntry.Metadata ?? GetTypeMetadata(objType, state);
-
-        // Keep exact and polymorphic class cloning on the same decision path.
-        return (T?)CloneClassInternalTyped(obj, objType, state, metadata);
-    }
-
     internal static object? CloneClassInternalNoTracking(object? obj, FastCloneState state)
     {
         if (obj is null)