Short Description
Opening an issue to centralize this discussion... I hope some folks from Microsoft will comment here.
can the restriction "require approval of the most recent reviewable push" please be removed for the LightGBM repo?
Details
#7032 is another example where the org-wide Microsoft ruleset(s) introduced this year are slowing us down 🙃
@StrikerRUS left a few small requests but also an "approve" review, so that I'd be able to merge that after applying changes for the requests. We have been operating in this high-trust way for years, as it helps keep the project moving (especially with maintainers spread across very different timezones).
I've made those changes, all CI is passing... and I'm not able to merge that PR.
Waiting on 1 reapproval from someone other than the last pusher. Review from StrikerRUS is stale because it was submitted before the most recent code changes.
It looks like this has been set org-wide:
ref: https://github.com/microsoft/LightGBM/settings/rules
ref: https://github.com/microsoft/LightGBM/settings/rules/5351760
Asking again... @letmaik could you help us get this changed or connect us to someone else at Microsoft we could talk to about it? Sorry to bother you, but I don't know of any other contacts at Microsoft who are involved with LightGBM.
I can see how this could be only a minor nuisance for projects staffed by Microsoft employees who work on open source during working hours, but here in LightGBM where the vast majority of the work is done by outside contributors / maintainers on their limited free time, it's pretty disruptive.
Notes
We have been asking for this to be changed for about 6 months now:
If the answer is "no, this is not something Microsoft is willing to change" then we can just deal with it, but it'd be good to see that in writing so we know not to keep asking.
cc @StrikerRUS @shiyu1994
Short Description
Opening an issue to centralize this discussion... I hope some folks from Microsoft will comment here.
can the restriction "require approval of the most recent reviewable push" please be removed for the LightGBM repo?
Details
#7032 is another example where the org-wide Microsoft ruleset(s) introduced this year are slowing us down 🙃
@StrikerRUS left a few small requests but also an "approve" review, so that I'd be able to merge that after applying changes for the requests. We have been operating in this high-trust way for years, as it helps keep the project moving (especially with maintainers spread across very different timezones).
I've made those changes, all CI is passing... and I'm not able to merge that PR.
It looks like this has been set org-wide:
ref: https://github.com/microsoft/LightGBM/settings/rules
ref: https://github.com/microsoft/LightGBM/settings/rules/5351760
Asking again... @letmaik could you help us get this changed or connect us to someone else at Microsoft we could talk to about it? Sorry to bother you, but I don't know of any other contacts at Microsoft who are involved with LightGBM.
I can see how this could be only a minor nuisance for projects staffed by Microsoft employees who work on open source during working hours, but here in LightGBM where the vast majority of the work is done by outside contributors / maintainers on their limited free time, it's pretty disruptive.
Notes
We have been asking for this to be changed for about 6 months now:
If the answer is "no, this is not something Microsoft is willing to change" then we can just deal with it, but it'd be good to see that in writing so we know not to keep asking.
cc @StrikerRUS @shiyu1994