Skip to content

[python-package] Add specific error messages to some test_basic tests#6887

Merged
jameslamb merged 4 commits intolightgbm-org:masterfrom
nicklamiller:raises-error-msgs
Apr 25, 2025
Merged

[python-package] Add specific error messages to some test_basic tests#6887
jameslamb merged 4 commits intolightgbm-org:masterfrom
nicklamiller:raises-error-msgs

Conversation

@nicklamiller
Copy link
Copy Markdown
Contributor

Contributes to: #6860

Adds specific error messages to:

  • test_add_features_throws_if_num_data_unequal
  • test_add_features_throws_if_datasets_unconstructed

@jameslamb
Copy link
Copy Markdown
Member

/AzurePipelines run

Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on this, we really appreciate it! This looks great.

Copy link
Copy Markdown
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jameslamb jameslamb merged commit a725360 into lightgbm-org:master Apr 25, 2025
51 checks passed
@jameslamb
Copy link
Copy Markdown
Member

@nicklamiller if you have time and interest, we'd welcome other contributions to help with #6860 !

@nicklamiller nicklamiller deleted the raises-error-msgs branch April 25, 2025 03:01
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/lightgbm-org/LightGBM/issues including a reference to this.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants