[python-package] Show true origin of logger info/warning#6878
Closed
tmct wants to merge 2 commits intolightgbm-org:masterfrom
Closed
[python-package] Show true origin of logger info/warning#6878tmct wants to merge 2 commits intolightgbm-org:masterfrom
tmct wants to merge 2 commits intolightgbm-org:masterfrom
Conversation
tmct
requested review from
StrikerRUS,
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
jameslamb
changed the title
jameslamb
requested changes
Mar 31, 2025
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for your interest in LightGBM!
Before we review this any further, please:
- add a description to the PR explaining the benefit of these changes, and linking to any previous discussion (here or elsewhere on the internet) that they relate to
- add some unit tests confirming that this works as expected, and to ensure it isn't broken in the future
- add these after https://github.com/microsoft/LightGBM/blob/82c85e4032fa12a23de341888ca545757761682e/tests/python_package_test/test_utilities.py#L131
- follow the style and conventions you see there
| _LOGGER = logger | ||
| _INFO_METHOD_NAME = info_method_name | ||
| _WARNING_METHOD_NAME = warning_method_name | ||
| _LOG_KWARGS = {"stacklevel": 2} if isinstance(logger, logging.Logger) else {} |
Member
There was a problem hiding this comment.
please make this an if-else instead of a 1-liner. We have a slight preference for that, for readability.
Collaborator
|
/AzurePipelines run |
Member
|
It's been about a month, I am going to close this due to lack of response. @tmct if you'd like to contribute in the future, you are welcome to re-open this! If you do, please add the things I asked for in #6878 (review). |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.