Fix not keyword silently ignored when used without parentheses in conditions (#4421)

* Initial plan

* Fix: not keyword now works without parentheses in guard conditions

Previously, `boolean(not false)` silently ignored the `not` keyword
while `boolean(not (false))` worked correctly.

The `negatedCondition` parser function consumed the `not` keyword but
only tried `parenthesisCondition`, which requires `(`. With no parens,
it returned undefined with `not` already consumed, causing silent skip.

Fix: fall back to `atomicCondition` when `parenthesisCondition` fails,
allowing both `not false` and `not (false)` to work consistently.

Co-authored-by: matthew-dean <[email protected]>

* Restrict not-without-parens to simple values only (keywords/variables)

Complex conditions like `not 2 < 1` still require parentheses,
keeping alignment with CSS media query syntax. Only simple bare
values (keywords, variables, quoted strings) are allowed after
`not` without parens: `not false`, `not @var`.

Remove the `boolean(not 2 < 1)` test case that relied on the
broader atomicCondition fallback.

Co-authored-by: matthew-dean <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: matthew-dean <[email protected]>
Co-authored-by: Matthew Dean <[email protected]>

Author: Copilot

packages/less/lib/less/parser/parser.js

@@ -2438,8 +2438,18 @@ const Parser = function Parser(context, imports, fileInfo, currentIndex) {
                     const result = this.parenthesisCondition(needsParens);
                     if (result) {
                         result.negate = !result.negate;
+                        return result;
+                    }
+
+                    // Allow simple bare values (keyword/variable) without parens,
+                    // e.g., `not false` or `not @var`.
+                    // Complex conditions (comparisons, function calls) require parentheses.
+                    const entities = this.entities;
+                    const index = parserInput.i;
+                    const a = entities.keyword() || entities.variable() || entities.quoted() || entities.mixinLookup();
+                    if (a) {
+                        return new(tree.Condition)('=', a, new(tree.Keyword)('true'), index + currentIndex, true);
                     }
-                    return result;
                 }
             },
             parenthesisCondition: function (needsParens) {

packages/test-data/tests-unit/functions/functions.css

@@ -224,6 +224,8 @@ html {
   a: true;
   b: false;
   c: false;
+  d: true;
+  e: false;
 }
 #if {
   a: 1;
@@ -236,6 +238,8 @@ html {
   i: 6;
   j: 8;
   k: 1;
+  m: 1;
+  n: 2;
   l: black;
   /* results in void */
   color: green;

packages/test-data/tests-unit/functions/functions.less

@@ -256,6 +256,9 @@ html {
   a: boolean(not(2 < 1));
   b: boolean(not(2 > 1) and (true));
   c: boolean(not(boolean(true)));
+  // not without parentheses (should behave the same as with parentheses)
+  d: boolean(not false);
+  e: boolean(not true);
 }
 
 #if {
@@ -271,6 +274,9 @@ html {
   i: if(true and isnumber(6), 6, 8);
   j: if(not(true) and true, 6, 8);
   k: if(true or true, 1);
+  // not without parentheses
+  m: if(not false, 1, 2);
+  n: if(not true, 1, 2);
 
   // see: https://github.com/less/less.js/issues/3371
   @some: foo;

packages/test-data/tests-unit/mixins-guards/mixins-guards.css

@@ -209,3 +209,9 @@
   no-parenthesis: evaluated true 4;
   with-parenthesis: evaluated true;
 }
+.test-not-noparens1 {
+  content: "not without parens true.";
+}
+.test-not-noparens2 {
+  content: "not without parens false.";
+}

packages/test-data/tests-unit/mixins-guards/mixins-guards.less

@@ -356,3 +356,14 @@
   .orderOfEvaluation(true, true, false);
 }
 
+// not without parentheses should work the same as not with parentheses
+.test-not-noparens (@a) when not @a {
+    content: "not without parens false.";
+}
+.test-not-noparens (@a) when (@a) {
+    content: "not without parens true.";
+}
+
+.test-not-noparens1 { .test-not-noparens(true) }
+.test-not-noparens2 { .test-not-noparens(false) }
+