Swc migration by YASHMAHAKAL · Pull Request #26 · layer5io/mui-datatables

YASHMAHAKAL · 2026-02-17T12:49:25Z

Notes for Reviewers

This PR fixes #

Migrates from Babel to SWC

Signed commits

Yes, I signed my commits.

YASHMAHAKAL · 2026-02-17T13:06:35Z

@leecalcote should i also upgrade mocha version ? please take a look

kishore08-07

@YASHMAHAKAL I noticed inconsistent module configurations across files: .swcrc and .swcrc.test are using commonjs, while rollup.config.js is configured for es6.
Could we align these configs or rely on Rollup to handle the module format to avoid potential build inconsistencies?

YASHMAHAKAL · 2026-02-19T17:59:47Z

@YASHMAHAKAL I noticed inconsistent module configurations across files: .swcrc and .swcrc.test are using commonjs, while rollup.config.js is configured for es6. Could we align these configs or rely on Rollup to handle the module format to avoid potential build inconsistencies?

The different module types are intentional and follow the recommended pattern for Rollup + SWC.
The .swcrc commonjs is used by @swc-node/register in Node.js tests, node requires CommonJS.
Inside the Rollup plugin, we use es6 so rollup can perform static analysis and tree-shaking on es module import/export statements. If we set it to commonjs, SWC would convert imports to require() calls before rollup sees them, which would break rollup's tree shaking entirely.

kishore08-07 · 2026-02-19T18:44:47Z

@YASHMAHAKAL I noticed inconsistent module configurations across files: .swcrc and .swcrc.test are using commonjs, while rollup.config.js is configured for es6. Could we align these configs or rely on Rollup to handle the module format to avoid potential build inconsistencies?

The different module types are intentional and follow the recommended pattern for Rollup + SWC. The .swcrc commonjs is used by @swc-node/register in Node.js tests, node requires CommonJS. Inside the Rollup plugin, we use es6 so rollup can perform static analysis and tree-shaking on es module import/export statements. If we set it to commonjs, SWC would convert imports to require() calls before rollup sees them, which would break rollup's tree shaking entirely.

@YASHMAHAKAL Thanks for clarifying, that makes sense.

leecalcote · 2026-03-24T01:58:32Z

@saurabhraghuvanshii keep working this through, please.

saurabhraghuvanshii · 2026-03-24T18:32:01Z

@YASHMAHAKAL, did you test your changes? Did you see any improvement in build time?

YASHMAHAKAL · 2026-03-24T18:33:18Z

@saurabhraghuvanshii yes, build time was reduced to 900 ms vs 2.5 seconds

YASHMAHAKAL · 2026-03-24T18:33:57Z

@saurabhraghuvanshii however, i just resolved merge conflicts so i'm testing it again

saurabhraghuvanshii · 2026-03-24T18:42:09Z

@saurabhraghuvanshii yes, build time was reduced to 900 ms vs 2.5 seconds

Wow!!

YASHMAHAKAL · 2026-03-24T19:13:33Z

@saurabhraghuvanshii i have tested it again and new build time is - 1.2 seconds vs 4.5 seconds after having changes in master recently : )

Rajesh-Nagarajan-11

Looks Good to me

Rajesh-Nagarajan-11 · 2026-03-25T09:44:52Z

@YASHMAHAKAL did you test all the scripts that are mentioned in package.json especially ( npm run dev & npm run build ) ?

YASHMAHAKAL · 2026-03-25T09:50:16Z

@YASHMAHAKAL did you test all the scripts that are mentioned in package.json especially ( npm run dev & npm run build ) ?

yes @Rajesh-Nagarajan-11

YASHMAHAKAL · 2026-04-08T17:39:50Z

@saurabhraghuvanshii take a look again, i've made the fix

saurabhraghuvanshii · 2026-04-10T22:09:52Z

@miacycle please merge this then I can update my Pr.

Bharath314 · 2026-05-08T10:19:11Z

There are some conflicts that have to be resolved.

YASHMAHAKAL

merge conflicts have been resolved

Signed-off-by: YASHMAHAKAL <[email protected]> remove @babel/runtime-corejs3 dependency Signed-off-by: YASHMAHAKAL <[email protected]> replaced 8-line IE11-era object with MUI v7 query string Signed-off-by: YASHMAHAKAL <[email protected]> removed mui/emotions Signed-off-by: YASHMAHAKAL <[email protected]> deleted .eslintrc Signed-off-by: YASHMAHAKAL <[email protected]> update rollup config Signed-off-by: YASHMAHAKAL <[email protected]> eliminate .eslintrc, fixed jsc.target errors Signed-off-by: YASHMAHAKAL <[email protected]> inconsistency fixed Signed-off-by: YASHMAHAKAL <[email protected]>

YASHMAHAKAL · 2026-05-09T19:15:58Z

+'use strict';
+
+// React 19 + Enzyme compatibility shims for Vitest. Mirrors master's setup-mocha-env.js.
+
+// beforeAll/afterAll are Vitest globals (globals:true). Alias for Mocha-style tests.
+global.before = beforeAll;
+global.after = afterAll;
+
+afterAll(async () => {
+  await new Promise((resolve) => setTimeout(resolve, 100));
+});
+
+// jsdom polyfills
+if (global.document) {
+  global.document.createRange = () => ({
+    setStart: () => {},


test/setup-vitest.cjs is a temporary compatibility shim. The existing test suite relies on Enzyme, which is incompatible with React 19 — ReactDOM.findDOMNode, testUtils.Simulate, and the internal hook dispatcher were all removed in React 19, causing all 234 tests to fail. This file patches them back in so the tests pass for now, mirroring the same approach master uses in test/setup-mocha-env.js. The proper fix is migrating the test suite from Enzyme to React Testing Library, which I will do in a follow-up PR. Keeping it separate avoids stacking a large test refactor on top of this build toolchain migration, making both PRs easier to review and merge independently.

YASHMAHAKAL · 2026-05-09T22:08:33Z

@leecalcote @Rajesh-Nagarajan-11 @saurabhraghuvanshii i've resolved all the merge conflicts, all the tests are passing, please take a look whenever convenient : )

Signed-off-by: YASHMAHAKAL <[email protected]> addressed compatibility issues and test configuration fixes Signed-off-by: YASHMAHAKAL <[email protected]> leftover warnings fixed Signed-off-by: YASHMAHAKAL <[email protected]> applied suggestions Signed-off-by: YASHMAHAKAL <[email protected]> fixed bugs for validateDOM and props nesting Signed-off-by: YASHMAHAKAL <[email protected]> coverage differentiated and npm run coverage fixed Signed-off-by: YASHMAHAKAL <[email protected]> fix: update dependencies and config Signed-off-by: YASHMAHAKAL <[email protected]> changed tests to unplugin-swc Signed-off-by: YASHMAHAKAL <[email protected]> apply suggestions Signed-off-by: YASHMAHAKAL <[email protected]> vitest.config.mts edited Signed-off-by: YASHMAHAKAL <[email protected]> added test/setup-vitest.cjs Signed-off-by: YASHMAHAKAL <[email protected]>

Signed-off-by: YASHMAHAKAL <[email protected]>

Oluwatunmise-olat

lgtm

Katotodan · 2026-05-23T13:21:15Z

LGTM

github-actions Bot added area/challenges area/learning-paths labels Feb 17, 2026

saurabhraghuvanshii reviewed Feb 17, 2026

View reviewed changes

Comment thread package.json Outdated

leecalcote requested review from Rajesh-Nagarajan-11, kishore08-07 and matrixkavi February 19, 2026 15:40

kishore08-07 suggested changes Feb 19, 2026

View reviewed changes

Comment thread package.json Outdated

Comment thread rollup.config.js Outdated

YASHMAHAKAL requested a review from kishore08-07 February 19, 2026 19:05

YASHMAHAKAL force-pushed the swc-migration branch from 4c3f9b3 to 4cc37ff Compare March 24, 2026 18:22

Rajesh-Nagarajan-11 approved these changes Mar 25, 2026

View reviewed changes

saurabhraghuvanshii reviewed Mar 25, 2026

View reviewed changes

Comment thread .eslintrc Outdated

rishiraj38 approved these changes Apr 7, 2026

View reviewed changes

YASHMAHAKAL force-pushed the swc-migration branch from a2948a4 to a58174f Compare April 8, 2026 17:37

YASHMAHAKAL requested a review from saurabhraghuvanshii April 8, 2026 17:39

YASHMAHAKAL requested a review from Rajesh-Nagarajan-11 April 8, 2026 17:43

YASHMAHAKAL force-pushed the swc-migration branch from a58174f to 6b0fd20 Compare April 10, 2026 20:17

saurabhraghuvanshii approved these changes Apr 10, 2026

View reviewed changes

Rajesh-Nagarajan-11 mentioned this pull request Apr 25, 2026

Migrate mui-datatables from JavaScript to TypeScript #50

Open

YASHMAHAKAL commented Apr 25, 2026

View reviewed changes

Comment thread package.json Outdated

YASHMAHAKAL requested a review from leecalcote April 25, 2026 13:32

Rajesh-Nagarajan-11 reviewed Apr 25, 2026

View reviewed changes

Comment thread src/components/TableFilter.js

Rajesh-Nagarajan-11 reviewed Apr 25, 2026

View reviewed changes

Comment thread rollup.config.mjs

Comment thread .swcrc Outdated

YASHMAHAKAL force-pushed the swc-migration branch from e9550ae to e848b30 Compare April 26, 2026 07:14

YASHMAHAKAL force-pushed the swc-migration branch from e848b30 to 6568cc1 Compare May 9, 2026 09:58

YASHMAHAKAL marked this pull request as draft May 9, 2026 09:59

YASHMAHAKAL force-pushed the swc-migration branch 2 times, most recently from 554571a to 27d26af Compare May 9, 2026 12:28

YASHMAHAKAL commented May 9, 2026

View reviewed changes

YASHMAHAKAL force-pushed the swc-migration branch from b8f4079 to 9ea6dba Compare May 9, 2026 19:07

YASHMAHAKAL marked this pull request as ready for review May 9, 2026 19:10

YASHMAHAKAL commented May 9, 2026

View reviewed changes

YASHMAHAKAL requested a review from Rajesh-Nagarajan-11 May 9, 2026 19:24

YASHMAHAKAL force-pushed the swc-migration branch from 9ea6dba to bf1e8ca Compare May 9, 2026 20:43

YASHMAHAKAL force-pushed the swc-migration branch 2 times, most recently from ca86bea to 5452615 Compare May 9, 2026 23:15

YASHMAHAKAL requested a review from rishiraj38 May 9, 2026 23:26

YASHMAHAKAL added 2 commits May 10, 2026 11:48

removed dead-dependencies and setup.js

f529756

Signed-off-by: YASHMAHAKAL <[email protected]>

YASHMAHAKAL force-pushed the swc-migration branch from 5452615 to f529756 Compare May 10, 2026 06:25

rishiraj38 approved these changes May 10, 2026

View reviewed changes

Oluwatunmise-olat approved these changes May 10, 2026

View reviewed changes

Junnygram approved these changes May 11, 2026

View reviewed changes

Katotodan approved these changes May 23, 2026

View reviewed changes

Conversation

YASHMAHAKAL commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YASHMAHAKAL commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kishore08-07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

YASHMAHAKAL commented Feb 19, 2026

Uh oh!

kishore08-07 commented Feb 19, 2026

Uh oh!

leecalcote commented Mar 24, 2026

Uh oh!

saurabhraghuvanshii commented Mar 24, 2026

Uh oh!

YASHMAHAKAL commented Mar 24, 2026

Uh oh!

YASHMAHAKAL commented Mar 24, 2026

Uh oh!

saurabhraghuvanshii commented Mar 24, 2026

Uh oh!

YASHMAHAKAL commented Mar 24, 2026

Uh oh!

Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rajesh-Nagarajan-11 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YASHMAHAKAL commented Mar 25, 2026

Uh oh!

YASHMAHAKAL commented Apr 8, 2026

Uh oh!

saurabhraghuvanshii commented Apr 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bharath314 commented May 8, 2026

Uh oh!

YASHMAHAKAL left a comment

Choose a reason for hiding this comment

Uh oh!

YASHMAHAKAL May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YASHMAHAKAL commented May 9, 2026

Uh oh!

Oluwatunmise-olat left a comment

Choose a reason for hiding this comment

Uh oh!

Katotodan commented May 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

YASHMAHAKAL commented Feb 17, 2026 •

edited

Loading

YASHMAHAKAL commented Feb 17, 2026 •

edited

Loading

Rajesh-Nagarajan-11 commented Mar 25, 2026 •

edited

Loading

YASHMAHAKAL May 9, 2026 •

edited

Loading