io: detect pollable fds for streaming read/write dispatch#394
Draft
lalinsky wants to merge 6 commits into
Draft
Conversation
- Default FileOpenFlags/FileCreateFlags.nonblocking to true - Remove supportsNonBlockingFileIo() guard from common.zig backends - After open/create, detect pollable fds via lseek/GetFileType and set Io.File.flags.nonblocking accordingly - In fileReadStreaming/fileWriteStreaming: pollable fds use PipeRead/PipeWrite (epoll/kqueue), regular files use FileReadStreaming/FileWriteStreaming (thread pool) - Add Runtime.pollable_fds map for caching foreign fds (stdin/stdout/stderr) - Thread Runtime through operate → operateInner → streaming functions - Same dispatch logic in batch path
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… open Keep the default false for FileOpenFlags/FileCreateFlags to avoid IOCP regressions. After fdIsPollable detection, explicitly set O_NONBLOCK on POSIX for pollable fds. Restore supportsNonBlockingFileIo guard in common.zig for io_uring/IOCP backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On epoll/kqueue backends, pipes/devices should be polled directly instead of going through the thread pool. This PR:
FileOpenFlags.nonblockingandFileCreateFlags.nonblockingtotruesupportsNonBlockingFileIo()guard from backendslseek(POSIX) /GetFileType(Windows)PipeRead/PipeWritefor pollable fds,FileReadStreaming/FileWriteStreamingfor regular filesRuntime.pollable_fdsmap for caching foreign fds (stdin/stdout/stderr)