fix: create cluster error in cluster node

Signed-off-by: redscholar <blacktiledhouse@gmail.com>

Author: redscholar

builtin/core/playbooks/create_cluster.yaml

@@ -49,7 +49,10 @@
 - hosts:
     - localhost
   roles:
-    - image-registry/push
+    - role: image-registry/push
+      when: 
+        - .groups.image_registry | empty | not
+        - .image_registry.type | empty | not
 
 # Install the Kubernetes cluster
 - hosts:

builtin/core/roles/defaults/defaults/main/10-download.yaml

@@ -143,7 +143,7 @@ download:
   images:
     manifests: []
     # Architectures for which images should be downloaded.
-    registry: >
+    registry: >-
       {{- if .zone | eq "cn" }}
       hub.kubesphere.com.cn
       {{- end }}

pkg/modules/copy/copy.go

@@ -28,6 +28,7 @@ import (
 	"github.com/cockroachdb/errors"
 	kkcorev1alpha1 "github.com/kubesphere/kubekey/api/core/v1alpha1"
 	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/util/rand"
 	"k8s.io/klog/v2"
 	"k8s.io/utils/ptr"
 
@@ -250,7 +251,7 @@ func (ca copyArgs) copyAbsoluteDir(ctx context.Context, conn connector.Connector
 		}
 		dest := filepath.Join(ca.dest, rel)
 
-		tmpDest := filepath.Join("/tmp", dest)
+		tmpDest := filepath.Join("/tmp", dest+"."+rand.String(5))
 
 		if err = conn.PutFile(ctx, data, tmpDest, mode); err != nil {
 			return err
@@ -294,7 +295,7 @@ func (ca copyArgs) copyRelativeDir(ctx context.Context, pj project.Project, relP
 		}
 		dest := filepath.Join(ca.dest, rel)
 
-		tmpDest := filepath.Join("/tmp", dest)
+		tmpDest := filepath.Join("/tmp", dest+"."+rand.String(5))
 
 		err = conn.PutFile(ctx, data, tmpDest, mode)
 		if err != nil {
@@ -329,7 +330,7 @@ func (ca copyArgs) copyContent(ctx context.Context, mode fs.FileMode, conn conne
 		mode = os.FileMode(*ca.mode)
 	}
 
-	tmpDest := filepath.Join("/tmp", ca.dest)
+	tmpDest := filepath.Join("/tmp", ca.dest+"."+rand.String(5))
 
 	if err := conn.PutFile(ctx, []byte(ca.content), tmpDest, mode); err != nil {
 		return internal.StdoutFailed, "failed to copy file", err
@@ -355,7 +356,7 @@ func (ca copyArgs) copyFile(ctx context.Context, data []byte, mode fs.FileMode,
 	if ca.mode != nil {
 		mode = os.FileMode(*ca.mode)
 	}
-	tmpDest := filepath.Join("/tmp", dest)
+	tmpDest := filepath.Join("/tmp", dest+"."+rand.String(5))
 
 	if err := conn.PutFile(ctx, data, tmpDest, mode); err != nil {
 		return err

pkg/modules/template/template.go

@@ -28,6 +28,7 @@ import (
 	"github.com/cockroachdb/errors"
 	kkcorev1alpha1 "github.com/kubesphere/kubekey/api/core/v1alpha1"
 	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/util/rand"
 	"k8s.io/klog/v2"
 	"k8s.io/utils/ptr"
 
@@ -227,7 +228,7 @@ func handleRelativeDir(ctx context.Context, pj project.Project, relPath string,
 			}
 			dest = filepath.Join(ta.dest, rel)
 		}
-		tmpDest := filepath.Join("/tmp", dest)
+		tmpDest := filepath.Join("/tmp", dest+"."+rand.String(5))
 
 		if err = conn.PutFile(ctx, result, tmpDest, mode); err != nil {
 			return err
@@ -254,7 +255,7 @@ func (ta templateArgs) readFile(ctx context.Context, data string, mode fs.FileMo
 	if ta.mode != nil {
 		mode = os.FileMode(*ta.mode)
 	}
-	tmpDest := filepath.Join("/tmp", dest)
+	tmpDest := filepath.Join("/tmp", dest+"."+rand.String(5))
 
 	if err = conn.PutFile(ctx, result, tmpDest, mode); err != nil {
 		return err
@@ -303,7 +304,7 @@ func (ta templateArgs) absDir(ctx context.Context, conn connector.Connector, var
 			dest = filepath.Join(ta.dest, rel)
 		}
 
-		tmpDest := filepath.Join("/tmp", dest)
+		tmpDest := filepath.Join("/tmp", dest+"."+rand.String(5))
 
 		if err = conn.PutFile(ctx, result, tmpDest, mode); err != nil {
 			return err