Merge pull request #74 from ksctl/feature/new-region

feat: modularized the cardselection system

Author: dipankardas011

cmd/create.go

@@ -84,8 +84,9 @@ func (k *KsctlCommand) CostOptimizeAcrossRegion(inp chan CliRecommendation, meta
 				return
 			}
 
-			// k.PrintRecommendation(meta.ClusterType, optimizeResp)
-			selectedReg, err := NewRegionRecommendation(meta.ClusterType, optimizeResp).Run()
+			selectedReg, err := k.menuDriven.CardSelection(
+				cli.ConverterForRecommendationIOutputForCards(optimizeResp, meta.ClusterType),
+			)
 			if err != nil {
 				k.l.Error("Failed to get the recommendation options from user", "Reason", err)
 				return

cmd/handle_meta.go

@@ -76,9 +76,19 @@ func (k *KsctlCommand) handleRegionSelection(meta *controllerMeta.Controller, m
 	ss.Stop()
 
 	k.l.Note(k.Ctx, "Carbon emission data shown represents monthly averages calculated over a one-year period")
-	if v, ok := k.getSelectedRegion(listOfRegions); !ok {
+	k.l.Note(k.Ctx, "Select the region for the cluster")
+
+	if v, err := k.menuDriven.CardSelection(
+		cli.ConverterForRegionOutputForCards(listOfRegions),
+	); err != nil {
+		k.l.Error("Failed to get the region", "Reason", err)
 		os.Exit(1)
 	} else {
+		if v == "" {
+			k.l.Error("Region not selected")
+			os.Exit(1)
+		}
+		k.l.Debug(k.Ctx, "Selected region", "Region", v)
 		m.Region = v
 	}
 
@@ -121,17 +131,25 @@ func (k *KsctlCommand) handleInstanceTypeSelection(
 		k.inMemInstanceTypesInReg = listOfVMs
 	}
 
-	availableOptions := make(provider.InstancesRegionOutput, len(k.inMemInstanceTypesInReg))
+	availableOptions := make(provider.InstancesRegionOutput, 0, len(k.inMemInstanceTypesInReg))
+
+	k.l.Note(k.Ctx, prompt)
 
 	for _, v := range k.inMemInstanceTypesInReg {
-		if v.Category == category {
+		if v.Category == category && v.CpuArch == provider.ArchAmd64 {
 			availableOptions = append(availableOptions, v)
 		}
 	}
 
-	v, ok := k.getSelectedInstanceType(prompt, availableOptions)
-	if !ok {
-		k.l.Error("Failed to get the instance type")
+	v, err := k.menuDriven.CardSelection(
+		cli.ConverterForInstanceTypesForCards(availableOptions),
+	)
+	if err != nil {
+		k.l.Error("Failed to get the instance type from user", "Reason", err)
+		os.Exit(1)
+	}
+	if v == "" {
+		k.l.Error("Instance type not selected")
 		os.Exit(1)
 	}