fix: app crashes when favorites path is null

Author: kimlimjustin

src/Api/favorites.ts

@@ -9,13 +9,19 @@ class FavoritesAPI {
 	VIDEO_PATH: string;
 	HOMEDIR_PATH: string;
 	async build(): Promise<void> {
-		this.DOCUMENT_PATH = await path.documentDir();
-		this.DOWNLOAD_PATH = await path.downloadDir();
-		this.DESKTOP_PATH = await path.desktopDir();
-		this.PICTURE_PATH = await path.pictureDir();
-		this.MUSIC_PATH = await path.audioDir();
-		this.VIDEO_PATH = await path.videoDir();
-		this.HOMEDIR_PATH = await path.homeDir();
+		try {
+			this.DOCUMENT_PATH = await path.documentDir();
+			this.DOWNLOAD_PATH = await path.downloadDir();
+			this.DESKTOP_PATH = await path.desktopDir();
+			this.PICTURE_PATH = await path.pictureDir();
+			this.MUSIC_PATH = await path.audioDir();
+			this.VIDEO_PATH = await path.videoDir();
+			// eslint-disable-next-line no-empty
+		} catch (_) {}
+		try {
+			this.HOMEDIR_PATH = await path.homeDir();
+			// eslint-disable-next-line no-empty
+		} catch (_) {}
 	}
 }
 

src/Components/Favorites/favorites.ts

@@ -27,6 +27,7 @@ const Favorites = async (): Promise<string> => {
 	result += `<h1 class="section-title">${await Translate('Favorites')}</h1>`;
 	const defaultFavoritesList = (await defaultFavorites()).map((favorite) => favorite.name);
 	for (const favorite of favorites) {
+		if (!favorite.path) continue;
 		if (favorite.path === 'xplorer://Home') continue;
 		const fileData = new FileAPI(favorite.path);
 		const exists = await fileData.exists();

src/Components/Layout/sidebar.ts

@@ -45,6 +45,7 @@ const createSidebar = async (): Promise<void> => {
 		let favoritesElement = '';
 		const defaultFavoritesList = (await defaultFavorites()).map((favorite) => favorite.name);
 		for (const favorite of favorites) {
+			if (!favorite.path) continue;
 			const exists = await new FileAPI(favorite.path).exists();
 			if (!(await isDefaultFavorite(favorite.path)) && !favorite.path.startsWith('xplorer://')) {
 				if (!exists) continue;