Fix #131: match issue ids exactly, not as substrings

Author: paul-brooks

ui2/src/components/AppSidebar.tsx

@@ -12,6 +12,7 @@ import {Collapsible, CollapsibleContent, CollapsibleTrigger,} from "@/components
 import {Popover, PopoverContent, PopoverTrigger,} from "@/components/ui/popover"
 import {Kbd, KbdGroup} from "@/components/ui/kbd"
 import {useConfig} from "@/contexts/ConfigContext"
+import {matchesAnyIssue} from "@/util/issueMatch"
 
 interface StateCounts {
     passed: number;
@@ -215,7 +216,7 @@ export function AppSidebar({indices, searchQuery, onSearchChange, onSelect, sele
 
                 // Class issues...
                 const classMatchesIssue = requiredIssues.length === 0 ||
-                    nodeIssues.some(ni => requiredIssues.some(ri => ni.includes(ri.toLowerCase())));
+                    matchesAnyIssue(nodeIssues, requiredIssues);
 
                 // If we have state/issue filters, we MUST filter children
                 if (node.children && (requiredStates.length > 0 || requiredIssues.length > 0)) {
@@ -230,8 +231,7 @@ export function AppSidebar({indices, searchQuery, onSearchChange, onSelect, sele
                                 return childMatchesState;
                             }
                             // Otherwise, check if the child has the issue
-                            const childIssues = (child.issues || []).map((i: string) => i.toLowerCase());
-                            const childMatchesIssue = childIssues.some(ci => requiredIssues.some(ri => ci.includes(ri.toLowerCase())));
+                            const childMatchesIssue = matchesAnyIssue(child.issues || [], requiredIssues);
                             return childMatchesIssue && childMatchesState;
                         }
 

ui2/src/util/issueMatch.test.ts

@@ -0,0 +1,33 @@
+import { describe, it, expect } from 'vitest';
+import { matchesAnyIssue } from './issueMatch';
+
+describe('matchesAnyIssue', () => {
+    it('matches when the node has the exact issue id', () => {
+        expect(matchesAnyIssue(['TEAM-1'], ['TEAM-1'])).toBe(true);
+    });
+
+    it('does not match TEAM-10 when the filter is TEAM-1', () => {
+        expect(matchesAnyIssue(['TEAM-10'], ['TEAM-1'])).toBe(false);
+    });
+
+    it('does not match TEAM-123 when the filter is TEAM-1', () => {
+        expect(matchesAnyIssue(['TEAM-123'], ['TEAM-1'])).toBe(false);
+    });
+
+    it('is case-insensitive', () => {
+        expect(matchesAnyIssue(['team-1'], ['TEAM-1'])).toBe(true);
+        expect(matchesAnyIssue(['TEAM-1'], ['team-1'])).toBe(true);
+    });
+
+    it('matches if any required issue is present', () => {
+        expect(matchesAnyIssue(['TEAM-2', 'TEAM-7'], ['TEAM-1', 'TEAM-7'])).toBe(true);
+    });
+
+    it('returns false when no issues match', () => {
+        expect(matchesAnyIssue(['TEAM-2'], ['TEAM-1'])).toBe(false);
+    });
+
+    it('returns false when the node has no issues', () => {
+        expect(matchesAnyIssue([], ['TEAM-1'])).toBe(false);
+    });
+});

ui2/src/util/issueMatch.ts

@@ -0,0 +1,5 @@
+export function matchesAnyIssue(nodeIssues: string[], requiredIssues: string[]): boolean {
+    const required = requiredIssues.map(i => i.toLowerCase());
+    const have = nodeIssues.map(i => i.toLowerCase());
+    return have.some(ni => required.includes(ni));
+}