chore(deps): update dependency golangci/golangci-lint to v2.12.1 (#1616)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vincent Link <[email protected]>

Author: renovate[bot]

.github/workflows/tests.yaml

@@ -55,7 +55,7 @@ jobs:
           version: ${{ env.GOLANGCI_LINT_VERSION }}
         env:
           # renovate: datasource=github-releases depName=golangci/golangci-lint
-          GOLANGCI_LINT_VERSION: "v2.11.4"
+          GOLANGCI_LINT_VERSION: "v2.12.1"
       - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
         env:
           SKIP: golangci-lint

.golangci.yml

@@ -28,17 +28,19 @@ linters:
     - unparam # reports unused function parameters
     - unused # checks for unused code
     - whitespace # checks for unnecessary newlines
+  settings:
+    goconst:
+      ignore-tests: true
   exclusions:
     generated: lax # exclude generated files
     presets:
       # suppress "exported X should have comment" — not all exports are documented
       - comments
     rules:
-      # test files: relax duplicate detection, unused params, and repeated strings
+      # test files: relax duplicate detection and unused params
       - linters:
           - dupl
           - unparam
-          - goconst
         path: _test\.go
       - linters:
           - revive

test/helpers/app.go

@@ -15,8 +15,9 @@ import (
 
 const (
 	// renovate: datasource=docker
-	defaultImage = "ghcr.io/traefik/whoami:v1.11.0"
-	defaultPort  = int32(8080)
+	defaultImage   = "ghcr.io/traefik/whoami:v1.11.0"
+	defaultPort    = int32(8080)
+	tlsCertsVolume = "tls-certs"
 )
 
 // TestApp bundles a Deployment and Service for a test backend.
@@ -81,12 +82,12 @@ func (a *TestApp) Resources() []k8s.Object {
 		probeScheme = corev1.URISchemeHTTPS
 		args = append(args, "--cert=/certs/tls.crt", "--key=/certs/tls.key")
 		volumeMounts = []corev1.VolumeMount{{
-			Name:      "tls-certs",
+			Name:      tlsCertsVolume,
 			MountPath: "/certs",
 			ReadOnly:  true,
 		}}
 		volumes = []corev1.Volume{{
-			Name: "tls-certs",
+			Name: tlsCertsVolume,
 			VolumeSource: corev1.VolumeSource{
 				Secret: &corev1.SecretVolumeSource{
 					SecretName: a.TLSSecretName,

test/helpers/deployment.go

@@ -111,10 +111,9 @@ func WithTLSCert(dnsNames []string) PatchDeploymentOption {
 			return err
 		}
 
-		volName := "tls-certs"
 		dep.Spec.Template.Spec.Volumes = append(dep.Spec.Template.Spec.Volumes,
 			corev1.Volume{
-				Name: volName,
+				Name: tlsCertsVolume,
 				VolumeSource: corev1.VolumeSource{
 					Secret: &corev1.SecretVolumeSource{SecretName: certName},
 				},
@@ -124,7 +123,7 @@ func WithTLSCert(dnsNames []string) PatchDeploymentOption {
 			dep.Spec.Template.Spec.Containers[i].VolumeMounts = append(
 				dep.Spec.Template.Spec.Containers[i].VolumeMounts,
 				corev1.VolumeMount{
-					Name:      volName,
+					Name:      tlsCertsVolume,
 					MountPath: "/certs",
 				},
 			)

tests/helper/helper.go

@@ -10,6 +10,7 @@ import (
 	"io"
 	"os"
 	"os/exec"
+	"slices"
 	"strings"
 	"testing"
 	"text/template"
@@ -398,8 +399,7 @@ func KubectlDeleteWithTemplate(t *testing.T, data any, templateName, config stri
 
 // Delete templates in reverse order of slice
 func KubectlDeleteMultipleWithTemplate(t *testing.T, data any, templates []Template) {
-	for idx := len(templates) - 1; idx >= 0; idx-- {
-		tmpl := templates[idx]
+	for _, tmpl := range slices.Backward(templates) {
 		KubectlDeleteWithTemplate(t, data, tmpl.Name, tmpl.Config)
 	}
 }