Skip to content

Commit c2ddb86

Browse files
committed
Fix unit test
1 parent 5b9e521 commit c2ddb86

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

test/apivalidations/applicationcredential_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ func applicationcredentialStub(namespace *corev1.Namespace) *orcv1alpha1.Applica
4242

4343
func testApplicationCredentialResource() *applyconfigv1alpha1.ApplicationCredentialResourceSpecApplyConfiguration {
4444
return applyconfigv1alpha1.ApplicationCredentialResourceSpec().
45-
WithUserRef("user")
45+
WithUserRef("user").
46+
WithSecretRef("applicationcredential-secret")
4647
}
4748

4849
func baseApplicationCredentialPatch(obj client.Object) *applyconfigv1alpha1.ApplicationCredentialApplyConfiguration {
@@ -79,7 +80,7 @@ var _ = Describe("ORC ApplicationCredential API validations", func() {
7980
p.Spec.WithImport(applyconfigv1alpha1.ApplicationCredentialImport().WithFilter(applyconfigv1alpha1.ApplicationCredentialFilter()))
8081
},
8182
applyValidFilter: func(p *applyconfigv1alpha1.ApplicationCredentialApplyConfiguration) {
82-
p.Spec.WithImport(applyconfigv1alpha1.ApplicationCredentialImport().WithFilter(applyconfigv1alpha1.ApplicationCredentialFilter().WithName("foo")))
83+
p.Spec.WithImport(applyconfigv1alpha1.ApplicationCredentialImport().WithFilter(applyconfigv1alpha1.ApplicationCredentialFilter().WithName("foo").WithUserRef("user")))
8384
},
8485
applyManaged: func(p *applyconfigv1alpha1.ApplicationCredentialApplyConfiguration) {
8586
p.Spec.WithManagementPolicy(orcv1alpha1.ManagementPolicyManaged)
@@ -105,7 +106,7 @@ var _ = Describe("ORC ApplicationCredential API validations", func() {
105106
Expect(applyObj(ctx, obj, patch)).NotTo(Succeed())
106107
})
107108

108-
It("should have immutable userRef", func(ctx context.Context) {
109+
It("should be immutable", func(ctx context.Context) {
109110
obj := applicationcredentialStub(namespace)
110111
patch := baseApplicationCredentialPatch(obj)
111112
patch.Spec.WithResource(testApplicationCredentialResource().
@@ -114,7 +115,7 @@ var _ = Describe("ORC ApplicationCredential API validations", func() {
114115

115116
patch.Spec.WithResource(testApplicationCredentialResource().
116117
WithUserRef("user-b"))
117-
Expect(applyObj(ctx, obj, patch)).To(MatchError(ContainSubstring("userRef is immutable")))
118+
Expect(applyObj(ctx, obj, patch)).To(MatchError(ContainSubstring("ApplicationCredentialResourceSpec is immutable")))
118119
})
119120

120121
// TODO(scaffolding): Add more resource-specific validation tests.

0 commit comments

Comments
 (0)