You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Chetan's addition of metadata fields for different celltypes in #1099 has offered a great solution for the inconsistent customization in viz.py across celltypes. Different plotting functions can differ wildly, including reading or not reading a network's celltypes, assigning colors to celltypes explicitly or differently or using different colorschemes, allowing or not allowing support for subsets of celltypes (including with or without color-matching), etc. Therefore, I think the following work should be done:
Each celltype should have one color to be used consistently, and the same for its "marker" in some uses of viz.py
viz.py's plotting functions should be updated so that they never make assumptions about celltypes (as much as possible, e.g. sorting alphabetically by celltype name), and they only ever read a celltype's colors instead of setting them inside the function itself.
Chetan's addition of metadata fields for different celltypes in #1099 has offered a great solution for the inconsistent customization in
viz.pyacross celltypes. Different plotting functions can differ wildly, including reading or not reading a network's celltypes, assigning colors to celltypes explicitly or differently or using different colorschemes, allowing or not allowing support for subsets of celltypes (including with or without color-matching), etc. Therefore, I think the following work should be done:hnn-core/hnn_core/network_models.py
Line 78 in 0279e31
jones_2009_model()for use elsewhere such as in [MRG] fix: enable backwards-compatible hier JSON #1119 .viz.pyviz.py's plotting functions should be updated so that they never make assumptions about celltypes (as much as possible, e.g. sorting alphabetically by celltype name), and they only ever read a celltype's colors instead of setting them inside the function itself.