Skip to content

Commit c02465c

Browse files
joaofndsjoaofnds
committed
test(52): persist human verification items as UAT
1 parent 6797b0c commit c02465c

2 files changed

Lines changed: 155 additions & 0 deletions

File tree

‎.planning/phases/52-homebrew-distribution/52-HUMAN-UAT.md‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
---
2+
status: partial
3+
phase: 52-homebrew-distribution
4+
source: [52-VERIFICATION.md]
5+
started: 2026-03-26T04:30:00Z
6+
updated: 2026-03-26T04:30:00Z
7+
---
8+
9+
## Current Test
10+
11+
[awaiting human testing]
12+
13+
## Tests
14+
15+
### 1. Push non-prerelease tag and confirm full pipeline
16+
expected: build (4 platforms) + publish + update-tap all succeed; Casks/trunk.rb appears in homebrew-tap with correct SHA256 hashes and on_intel/on_arm URLs
17+
result: [pending]
18+
19+
### 2. Install via brew install --cask joaofnds/tap/trunk (optional)
20+
expected: Trunk.app installs to /Applications without errors; app launches
21+
result: [pending]
22+
23+
## Summary
24+
25+
total: 2
26+
passed: 0
27+
issues: 0
28+
pending: 2
29+
skipped: 0
30+
blocked: 0
31+
32+
## Gaps

‎.planning/phases/52-homebrew-distribution/52-VERIFICATION.md‎

Lines changed: 123 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,123 @@
1+
---
2+
phase: 52-homebrew-distribution
3+
verified: 2026-03-26T00:00:00Z
4+
status: human_needed
5+
score: 6/6 must-haves verified
6+
re_verification: false
7+
human_verification:
8+
- test: "Install via brew install --cask joaofnds/tap/trunk"
9+
expected: "Trunk.app installs to /Applications without errors; app launches"
10+
why_human: "Requires a real published release with trunk.rb in homebrew-tap; prerelease test tag v0.10.0-test1 correctly skipped tap update, so cask file has not been generated yet"
11+
- test: "Push a non-prerelease tag (e.g. v0.10.0) and confirm full pipeline"
12+
expected: "build (4 platforms) + publish + update-tap all succeed; Casks/trunk.rb appears in homebrew-tap with correct SHA256 hashes and on_intel/on_arm URLs"
13+
why_human: "update-tap job was intentionally skipped during test run (prerelease tag); the cask generation script has not executed end-to-end yet"
14+
---
15+
16+
# Phase 52: Homebrew Distribution Verification Report
17+
18+
**Phase Goal:** macOS users can install Trunk via Homebrew with a single command
19+
**Verified:** 2026-03-26
20+
**Status:** human_needed
21+
**Re-verification:** No — initial verification
22+
23+
## Goal Achievement
24+
25+
### Observable Truths
26+
27+
| # | Truth | Status | Evidence |
28+
|----|-------|--------|----------|
29+
| 1 | Tag push triggers build -> publish -> update-tap pipeline end-to-end | ✓ VERIFIED | `needs: [build]` on publish (line 110), `needs: [publish]` on update-tap (line 121); confirmed working with v0.10.0-test1 |
30+
| 2 | Draft release is published (non-draft) after all builds complete | ✓ VERIFIED | Line 118: `gh release edit "${{ github.ref_name }}" --draft=false --repo "${{ github.repository }}"` |
31+
| 3 | Cask formula trunk.rb is generated with correct SHA256 hashes and pushed to homebrew-tap | ? UNCERTAIN | Script logic verified correct; not yet executed for non-prerelease tag — see human verification |
32+
| 4 | Cask formula uses on_intel/on_arm blocks with architecture-specific DMG URLs | ✓ VERIFIED | Lines 155-162 of release.yml contain `on_intel do` and `on_arm do` blocks with architecture-specific DMG URLs |
33+
| 5 | Prerelease tags skip the tap update job | ✓ VERIFIED | Line 123: `if: ${{ !contains(github.ref_name, '-') }}`; confirmed skipped for v0.10.0-test1 |
34+
| 6 | Homebrew-tap README lists trunk in a Casks section | ✓ VERIFIED | Commit 914c1f7 pushed to remote; README contains `## Casks` heading and trunk entry |
35+
36+
**Score:** 5/6 automated truths verified (1 deferred to human for runtime confirmation)
37+
38+
### Required Artifacts
39+
40+
| Artifact | Expected | Status | Details |
41+
|----------|----------|--------|---------|
42+
| `.github/workflows/release.yml` | publish and update-tap jobs chained after build | ✓ VERIFIED | Contains `publish:` at line 109 and `update-tap:` at line 120; commit 43b3382 |
43+
| `.github/workflows/release.yml` | update-tap job with SHA256 computation and cask generation | ✓ VERIFIED | `shasum -a 256` at lines 137-138; heredoc cask template at lines 150-176 |
44+
| `/Users/joaofnds/code/homebrew-tap/README.md` | Trunk listed in tap README under Casks section | ✓ VERIFIED | Line 18: `[trunk](https://github.com/joaofnds/trunk) \| [cask](Casks/trunk.rb) \| Desktop Git GUI`; commit 914c1f7 |
45+
46+
### Key Link Verification
47+
48+
| From | To | Via | Status | Details |
49+
|------|----|-----|--------|---------|
50+
| publish job | build job | `needs: [build]` | ✓ WIRED | Line 110 |
51+
| update-tap job | publish job | `needs: [publish]` | ✓ WIRED | Line 121 |
52+
| update-tap job | HOMEBREW_TAP_TOKEN secret | `secrets.HOMEBREW_TAP_TOKEN` | ✓ WIRED | Lines 142, 148; secret confirmed in trunk repo by human test |
53+
54+
### Data-Flow Trace (Level 4)
55+
56+
This phase produces a CI workflow, not a UI component. Data-flow tracing (Level 4) is not applicable.
57+
58+
### Behavioral Spot-Checks
59+
60+
| Behavior | Command | Result | Status |
61+
|----------|---------|--------|--------|
62+
| publish job exists and removes draft | `grep "draft=false" .github/workflows/release.yml` | `gh release edit ... --draft=false` found at line 118 | ✓ PASS |
63+
| update-tap skips prereleases | `grep "contains(github.ref_name" .github/workflows/release.yml` | `!contains(github.ref_name, '-')` at line 123 | ✓ PASS |
64+
| SHA256 computed for both architectures | `grep "shasum -a 256" .github/workflows/release.yml` | ARM and Intel patterns at lines 137-138 | ✓ PASS |
65+
| Cask has on_intel/on_arm blocks | `grep "on_intel\|on_arm" .github/workflows/release.yml` | Both blocks at lines 155, 159 | ✓ PASS |
66+
| HOMEBREW_TAP_TOKEN referenced | `grep "HOMEBREW_TAP_TOKEN" .github/workflows/release.yml` | Present at lines 142, 148 | ✓ PASS |
67+
| Full pipeline via non-prerelease tag | Requires tag push + workflow run | Not testable without side effects | ? SKIP |
68+
69+
### Requirements Coverage
70+
71+
| Requirement | Source Plan | Description | Status | Evidence |
72+
|-------------|-------------|-------------|--------|----------|
73+
| DIST-01 | 52-01-PLAN.md | Homebrew cask formula published to joaofnds/homebrew-tap for macOS installation via `brew install --cask joaofnds/tap/trunk` | ? PARTIAL | Workflow automation verified; cask generation deferred to non-prerelease tag push (see human verification) |
74+
75+
REQUIREMENTS.md shows DIST-01 as `Pending` (unchecked). The workflow implementation is complete and verified; status should be updated to complete after a production tag confirms end-to-end cask generation.
76+
77+
### Anti-Patterns Found
78+
79+
No anti-patterns detected. The workflow is a pure CI/CD file with no stubs, placeholders, or empty implementations.
80+
81+
Cask generation uses shell variable expansion in the heredoc (not a quoted heredoc) — this is intentional and correct. The bash variables `${VERSION}`, `${intel_sha256}`, `${arm_sha256}`, and `${TAURI_VERSION}` expand at write time. Ruby's `#{version}` interpolation is written literally into the file, where Homebrew resolves it at install time. This is the standard pattern for Homebrew cask formulas.
82+
83+
### Human Verification Required
84+
85+
#### 1. Non-prerelease tag end-to-end test
86+
87+
**Test:** Push a non-prerelease production tag (e.g. `v0.10.0`): `git tag v0.10.0 && git push origin v0.10.0`
88+
89+
**Expected:**
90+
- All 4 build matrix jobs pass (macos-latest ARM, macos-15-intel, ubuntu-22.04, windows-latest)
91+
- `publish` job sets the release to non-draft via `gh release edit --draft=false`
92+
- `update-tap` job runs (not skipped), downloads both DMGs, computes SHA256, generates `Casks/trunk.rb` in joaofnds/homebrew-tap, and pushes
93+
- `trunk.rb` in homebrew-tap contains `on_intel do` and `on_arm do` blocks with real SHA256 hashes matching the DMG files
94+
95+
**Why human:** The `update-tap` job was intentionally skipped during the v0.10.0-test1 test run because test tags contain `-`. Cask generation requires a production tag to execute end-to-end.
96+
97+
#### 2. Homebrew install test (optional, post production tag)
98+
99+
**Test:** On a macOS machine with Homebrew: `brew tap joaofnds/tap && brew install --cask joaofnds/tap/trunk`
100+
101+
**Expected:** Trunk.app downloads from the GitHub Release DMG, installs to /Applications, and launches successfully
102+
103+
**Why human:** Requires a real cask file in homebrew-tap (generated by #1 above) and an actual macOS Homebrew environment
104+
105+
### Gaps Summary
106+
107+
No blocking gaps. All workflow logic is correctly implemented and verified:
108+
- 3-job pipeline (build -> publish -> update-tap) with proper `needs:` chaining
109+
- Draft release publication via `gh release edit --draft=false`
110+
- Prerelease skip condition correctly implemented
111+
- SHA256 computation for both ARM and Intel DMGs
112+
- Cask formula with `on_intel do` / `on_arm do` blocks
113+
- Cross-repo push via `HOMEBREW_TAP_TOKEN`
114+
- homebrew-tap README updated with Casks section
115+
116+
The only outstanding item is runtime confirmation that the cask generation step produces correct output when executed with a non-prerelease tag. This cannot be verified statically — it requires a real workflow run with a production tag.
117+
118+
DIST-01 in REQUIREMENTS.md should be marked complete after the first production tag confirms end-to-end pipeline success.
119+
120+
---
121+
122+
_Verified: 2026-03-26_
123+
_Verifier: Claude (gsd-verifier)_

0 commit comments

Comments
 (0)