Skip to content

Commit c0a17dd

Browse files
fix: honor --skip-login on docker build
1 parent cc8aff1 commit c0a17dd

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

buildtools/cli.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1042,7 +1042,7 @@ func buildCmd(c *cli.Context) error {
10421042
}
10431043

10441044
// Extract build configuration and arguments
1045-
_, rtDetails, _, _, _, cleanArgs, buildConfiguration, err := extractDockerOptionsFromArgs(c.Args())
1045+
_, rtDetails, _, skipLogin, _, cleanArgs, buildConfiguration, err := extractDockerOptionsFromArgs(c.Args())
10461046
if err != nil {
10471047
return err
10481048
}
@@ -1051,12 +1051,14 @@ func buildCmd(c *cli.Context) error {
10511051
return err
10521052
}
10531053

1054-
// Login to the docker registry
1055-
err = loginCmd(c)
1056-
if err != nil {
1057-
return err
1054+
if !skipLogin {
1055+
// Login to the docker registry
1056+
err = loginCmd(c)
1057+
if err != nil {
1058+
return err
1059+
}
10581060
}
1059-
1061+
10601062
dockerOptions := strategies.DockerBuildOptions{
10611063
DockerFilePath: dockerFilePath,
10621064
PushExpected: pushOption,

0 commit comments

Comments
 (0)