Merge pull request #39 from jakemmarsh/update-linter

jakemmarsh · jakemmarsh · commit bd7d230ec7ec · 2016-05-11T22:34:35.000-07:00
Update linter packages and config
diff --git a/.eslintrc b/.eslintrc
@@ -9,23 +9,28 @@
   },
   "env": {
     "browser": true,
-    "node": true
+    "es6": true,
+    "node": true,
   },
   "rules": {
     "quotes": [2, "single"],
-    "eol-last": 0,
+    "eol-last": 2,
     "no-debugger": 1,
     "no-mixed-requires": 0,
     "no-underscore-dangle": 0,
     "no-multi-spaces": 0,
     "no-trailing-spaces": 0,
     "no-extra-boolean-cast": 0,
-    "no-unused-vars": 1,
+    "no-undef": 2,
+    "no-unused-vars": 2,
+    "no-var": 2,
+    "prefer-const": 2,
     "new-cap": 0,
-    "camelcase": 1,
+    "camelcase": 2,
+    "semi": 2,
     "react/jsx-uses-react": 2,
     "react/jsx-uses-vars": 2,
-    "react/react-in-jsx-scope": 0,
+    "react/react-in-jsx-scope": 2,
     "react/prop-types": 2
   }
-}
+}
diff --git a/app/js/App.js b/app/js/App.js
@@ -75,4 +75,4 @@ class App extends React.Component {
 
 App.propTypes = propTypes;
 
-export default App;
+export default App;
diff --git a/app/js/actions/CurrentUserActions.js b/app/js/actions/CurrentUserActions.js
@@ -10,4 +10,4 @@ const CurrentUserActions = Reflux.createActions([
 
 ]);
 
-export default CurrentUserActions;
+export default CurrentUserActions;
diff --git a/app/js/components/Footer.js b/app/js/components/Footer.js
@@ -20,4 +20,4 @@ class Footer extends React.Component{
 
 }
 
-export default Footer;
+export default Footer;
diff --git a/app/js/components/Header.js b/app/js/components/Header.js
@@ -20,4 +20,4 @@ class Header extends React.Component {
 
 }
 
-export default Header;
+export default Header;
diff --git a/app/js/index.js b/app/js/index.js
@@ -10,4 +10,4 @@ if ( process.env.NODE_ENV !== 'production' ) {
   window.React = React;
 }
 
-ReactDOM.render(Routes, document.getElementById('app'));
+ReactDOM.render(Routes, document.getElementById('app'));
diff --git a/app/js/pages/HomePage.js b/app/js/pages/HomePage.js
@@ -36,4 +36,4 @@ class HomePage extends React.Component {
 
 HomePage.propTypes = propTypes;
 
-export default HomePage;
+export default HomePage;
diff --git a/app/js/pages/NotFoundPage.js b/app/js/pages/NotFoundPage.js
@@ -29,4 +29,4 @@ class NotFoundPage extends React.Component {
 
 NotFoundPage.propTypes = propTypes;
 
-export default NotFoundPage;
+export default NotFoundPage;
diff --git a/app/js/pages/SearchPage.js b/app/js/pages/SearchPage.js
@@ -52,4 +52,4 @@ class SearchPage extends React.Component {
 
 SearchPage.propTypes = propTypes;
 
-export default SearchPage;
+export default SearchPage;
diff --git a/app/js/utils/AuthAPI.js b/app/js/utils/AuthAPI.js
@@ -18,4 +18,4 @@ const AuthAPI = {
 
 };
 
-export default AuthAPI;
+export default AuthAPI;
diff --git a/gulp/config.js b/gulp/config.js
@@ -7,7 +7,9 @@ const config = {
 
   scripts: {
     src: './app/js/**/*.js',
-    dest: './build/js/'
+    dest: './build/js/',
+    test: './tests/**/*.js',
+    gulp: './gulp/**/*.js'
   },
 
   images: {
diff --git a/gulp/index.js b/gulp/index.js
@@ -1,9 +1,10 @@
 'use strict';
 
-var fs = require('fs');
-var onlyScripts = require('./util/script-filter');
-var tasks = fs.readdirSync('./gulp/tasks/').filter(onlyScripts);
+import fs          from 'fs';
+import onlyScripts from './util/script-filter';
 
-tasks.forEach(function(task) {
+const TASKS = fs.readdirSync('./gulp/tasks/').filter(onlyScripts);
+
+TASKS.forEach(function(task) {
   require('./tasks/' + task);
-});
+});
diff --git a/gulp/tasks/browserSync.js b/gulp/tasks/browserSync.js
@@ -14,7 +14,7 @@ gulp.task('browserSync', function() {
     server: {
       baseDir: config.buildDir,
       middleware: function(req, res, next) {
-        let fileHref = url.parse(req.url).href;
+        const fileHref = url.parse(req.url).href;
 
         if ( !ASSET_EXTENSION_REGEX.test(fileHref)) {
           req.url = '/' + DEFAULT_FILE;
@@ -32,4 +32,4 @@ gulp.task('browserSync', function() {
     }
   });
 
-});
+});
diff --git a/gulp/tasks/browserify.js b/gulp/tasks/browserify.js
@@ -19,7 +19,7 @@ import config       from '../config';
 // Based on: http://blog.avisi.nl/2014/04/25/how-to-keep-a-fast-build-with-browserify-and-reactjs/
 function buildScript(file, watch) {
 
-  var bundler = browserify({
+  let bundler = browserify({
     entries: [config.sourceDir + 'js/' + file],
     debug: !global.isProd,
     cache: {},
@@ -36,7 +36,7 @@ function buildScript(file, watch) {
   bundler.transform(debowerify);
 
   function rebundle() {
-    let stream = bundler.bundle();
+    const stream = bundler.bundle();
 
     gutil.log('Rebundle...');
 
diff --git a/gulp/tasks/clean.js b/gulp/tasks/clean.js
@@ -8,4 +8,4 @@ gulp.task('clean', function() {
 
   return del([config.buildDir]);
 
-});
+});
diff --git a/gulp/tasks/copyIcons.js b/gulp/tasks/copyIcons.js
@@ -5,7 +5,6 @@ import config from '../config';
 
 gulp.task('copyIcons', function() {
 
-  // Copy icons from root directory to build/
   return gulp.src(['./*.png', './favicon.ico'])
     .pipe(gulp.dest(config.buildDir));
 
diff --git a/gulp/tasks/copyIndex.js b/gulp/tasks/copyIndex.js
@@ -7,4 +7,4 @@ gulp.task('copyIndex', function() {
 
   gulp.src(config.sourceDir + 'index.html').pipe(gulp.dest(config.buildDir));
 
-});
+});
diff --git a/gulp/tasks/deploy.js b/gulp/tasks/deploy.js
@@ -1,10 +1,9 @@
 'use strict';
 
 import gulp from 'gulp';
-//import config from '../config';
 
 gulp.task('deploy', ['prod'], function() {
 
   // Deploy to hosting environment
 
-});
+});
diff --git a/gulp/tasks/development.js b/gulp/tasks/development.js
@@ -9,7 +9,6 @@ gulp.task('dev', ['clean'], function(cb) {
 
   global.isProd = false;
 
-  // Run all tasks once
   return runSequence(['sass', 'imagemin', 'browserify', 'copyFonts', 'copyIndex', 'copyIcons'], 'watch', cb);
 
-});
+});
diff --git a/gulp/tasks/imagemin.js b/gulp/tasks/imagemin.js
@@ -8,10 +8,9 @@ import config      from '../config';
 
 gulp.task('imagemin', function() {
 
-  // Run imagemin task on all images
   return gulp.src(config.images.src)
     .pipe(gulpif(global.isProd, imagemin()))
     .pipe(gulp.dest(config.images.dest))
     .pipe(gulpif(browserSync.active, browserSync.reload({ stream: true, once: true })));
 
-});
+});
diff --git a/gulp/tasks/lint.js b/gulp/tasks/lint.js
@@ -6,9 +6,9 @@ import config from '../config';
 
 gulp.task('lint', function() {
 
-  return gulp.src([config.scripts.src, config.testFiles, './*.js'])
+  return gulp.src([config.scripts.src, config.scripts.test, config.scripts.gulp])
     .pipe(eslint())
     .pipe(eslint.format())
     .pipe(eslint.failAfterError());
 
-});
+});
diff --git a/gulp/tasks/production.js b/gulp/tasks/production.js
@@ -11,4 +11,4 @@ gulp.task('prod', ['clean'], function(cb) {
 
   runSequence(['sass', 'imagemin', 'browserify', 'copyFonts', 'copyIndex', 'copyIcons'], cb);
 
-});
+});
diff --git a/gulp/tasks/test.js b/gulp/tasks/test.js
@@ -22,7 +22,7 @@ gulp.task('test', () => {
     files = ['tests/helper.js', singleFile];
   } else {
     // Default to all test files
-    files = [config.testFiles];
+    files = [config.scripts.test];
   }
 
   // Ensure that all window/DOM related properties
diff --git a/gulp/tasks/watch.js b/gulp/tasks/watch.js
@@ -6,8 +6,8 @@ import config from '../config';
 gulp.task('watch', ['browserSync'], function() {
 
   // Scripts are automatically watched by Watchify inside Browserify task
-  gulp.watch(config.styles.src,                 ['sass']);
-  gulp.watch(config.images.src,                 ['imagemin']);
-  gulp.watch(config.sourceDir + 'index.html',   ['copyIndex']);
+  gulp.watch(config.styles.src,               ['sass']);
+  gulp.watch(config.images.src,               ['imagemin']);
+  gulp.watch(config.sourceDir + 'index.html', ['copyIndex']);
 
-});
+});
diff --git a/gulp/util/handle-errors.js b/gulp/util/handle-errors.js
@@ -1,12 +1,12 @@
 'use strict';
 
-var notify = require('gulp-notify');
+import notify from 'gulp-notify';
 
-module.exports = function(error) {
+export default function(error) {
 
   if( !global.isProd ) {
 
-    var args = Array.prototype.slice.call(arguments);
+    const args = Array.prototype.slice.call(arguments);
 
     // Send error to notification center with gulp-notify
     notify.onError({
@@ -24,4 +24,4 @@ module.exports = function(error) {
     process.exit(1);
   }
 
-};
+};
diff --git a/gulp/util/script-filter.js b/gulp/util/script-filter.js
@@ -1,9 +1,9 @@
 'use strict';
 
-var path = require('path');
+import path from 'path';
 
 // Filters out non .coffee and .js files. Prevents
 // accidental inclusion of possible hidden files
-module.exports = function(name) {
+export default function(name) {
   return /(\.(js|coffee)$)/i.test(path.extname(name));
-};
+};
diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
   ],
   "devDependencies": {
     "babel-core": "^6.3.15",
-    "babel-eslint": "^5.0.0-beta4",
+    "babel-eslint": "^6.0.4",
     "babel-plugin-transform-object-rest-spread": "^6.3.13",
     "babel-preset-es2015": "^6.3.13",
     "babel-preset-react": "^6.3.13",
@@ -27,10 +27,10 @@
     "change-case": "^2.3.1",
     "debowerify": "^1.3.1",
     "del": "^2.2.0",
-    "eslint-plugin-react": "^3.6.3",
+    "eslint-plugin-react": "^5.1.1",
     "gulp": "^3.9.0",
     "gulp-autoprefixer": "^3.1.0",
-    "gulp-eslint": "^1.1.1",
+    "gulp-eslint": "^2.0.0",
     "gulp-if": "^2.0.0",
     "gulp-imagemin": "^2.3.0",
     "gulp-jsx-coverage": "^0.3.5",
diff --git a/tests/.eslintrc b/tests/.eslintrc
@@ -6,6 +6,6 @@
   "globals": {
     "sinon": true,
     "sandbox": true,
-    "Should": true
+    "assert": true
   }
-}
+}
diff --git a/tests/helper.js b/tests/helper.js
@@ -6,4 +6,4 @@ beforeEach(function() {
 
 afterEach(function() {
   global.sandbox.restore();
-});
+});

Original file line number	Diff line number	Diff line change
`@@ -75,4 +75,4 @@ class App extends React.Component {`
`75`	`75`
`76`	`76`	`App.propTypes = propTypes;`
`77`	`77`
`78`		`-export default App;`
	`78`	`+export default App;`
Original file line number	Diff line number	Diff line change
`@@ -10,4 +10,4 @@ const CurrentUserActions = Reflux.createActions([`
`10`	`10`
`11`	`11`	`]);`
`12`	`12`
`13`		`-export default CurrentUserActions;`
	`13`	`+export default CurrentUserActions;`
Original file line number	Diff line number	Diff line change
`@@ -20,4 +20,4 @@ class Footer extends React.Component{`
`20`	`20`
`21`	`21`	`}`
`22`	`22`
`23`		`-export default Footer;`
	`23`	`+export default Footer;`
Original file line number	Diff line number	Diff line change
`@@ -20,4 +20,4 @@ class Header extends React.Component {`
`20`	`20`
`21`	`21`	`}`
`22`	`22`
`23`		`-export default Header;`
	`23`	`+export default Header;`
Original file line number	Diff line number	Diff line change
`@@ -10,4 +10,4 @@ if ( process.env.NODE_ENV !== 'production' ) {`
`10`	`10`	`window.React = React;`
`11`	`11`	`}`
`12`	`12`
`13`		`-ReactDOM.render(Routes, document.getElementById('app'));`
	`13`	`+ReactDOM.render(Routes, document.getElementById('app'));`
Original file line number	Diff line number	Diff line change
`@@ -36,4 +36,4 @@ class HomePage extends React.Component {`
`36`	`36`
`37`	`37`	`HomePage.propTypes = propTypes;`
`38`	`38`
`39`		`-export default HomePage;`
	`39`	`+export default HomePage;`
Original file line number	Diff line number	Diff line change
`@@ -29,4 +29,4 @@ class NotFoundPage extends React.Component {`
`29`	`29`
`30`	`30`	`NotFoundPage.propTypes = propTypes;`
`31`	`31`
`32`		`-export default NotFoundPage;`
	`32`	`+export default NotFoundPage;`
Original file line number	Diff line number	Diff line change
`@@ -52,4 +52,4 @@ class SearchPage extends React.Component {`
`52`	`52`
`53`	`53`	`SearchPage.propTypes = propTypes;`
`54`	`54`
`55`		`-export default SearchPage;`
	`55`	`+export default SearchPage;`
Original file line number	Diff line number	Diff line change
`@@ -18,4 +18,4 @@ const AuthAPI = {`
`18`	`18`
`19`	`19`	`};`
`20`	`20`
`21`		`-export default AuthAPI;`
	`21`	`+export default AuthAPI;`