Merge pull request #1271 from itflow-org/develop

Develop to Master

Author: johnnyq

CHANGELOG.md

@@ -2,6 +2,46 @@
 
 This file documents all notable changes made to ITFlow.
 
+## [26.03] Stable Release
+### Bug Fixes
+- Ticket Templates: Fix Task Sorting.
+- Ticket: Lower autoclose setting minimum value from 48 to 24 Hours.
+- Ticket: Fix Task Approval.
+- Recurring Ticket: add empty value placeholder for Ticket Frequency.
+- Documents/Files: Fix redirect after File Upload to redirect to files instead of the non existent documents.
+- Setup: Fix base url tacking on /setup when not installing via script.
+
+
+### New Features & Updates 
+- Clients: Net Terms: Added common 45 and 15 Days, removed 14 Days not as common.
+- Clients: Bulk Action Set Net Terms Added.
+- Clients: Swapped location and contact column, add PopOver with Details such as created, abbreviation, DB ID instead of taking up space underneath client, rounded tag pills and increased padding, removed info badges and added one info badge that displays a popover with details.
+- Clients: Added New Ticket to Client Top Header Menu.
+- Clients: Client Overview: UI Sprucing.
+- Invoice: Send reminder 1 day after due date.
+- Invoices/Quotes/Recurring Invoices: Split Items tables into their own POST logic and Modal UIs and tables (quote_items, invoice_items, recurring_items).
+- Tickets: New Ticket Parsing - Anyone CC'ed onto the original email that created the ticket is added as a ticket watcher.
+- Ticket/Quotes: Quotes can now be associated with a ticket.
+- Networks: Removed Subnet Mask Field, Use CIDR instead.
+- Networks: Rearranged fields, Updated placeholders, Add/Edit/list for better flow.
+- Networks: Renamed DHCP to IP Range to allow for you use of both DHCP and or Usable IPs.
+- Assets: Rearranged fields, Updated placeholders, Add/Edit/list for better flow.
+- Assets: Added IPv6 if available under IP, Make and Model are now one line with Serial Underneath. Added OS under Type. use pill for status.
+- Calendar: Event thats are cut off can now be viewed as a tooltip on hover.
+- Calendar: Renamed System Calendars to built-in calendars and added the names and color dot for reference.
+- Calendar: You can now delete a custom calendar.
+- Report: Client Ticket Time Detail Audit: Selectable Billing Time Increment, will later be avauilable globally.
+- Roles/Permissions: Now complete and is out of beta all permission roles are strictly enforced, except for in Trips and Calendar, new enforce modules will be added for these at a later date.
+- Project Templates: Ticket Template order can now be dragged and dropped.
+- Global: Introduced new checkbox class to all Checkbox select columns to keep consistency and reduce space and enhance ui.
+- Global: CSRF Checks everywhere instead of just deletion calls.
+- Global: Renamed the rest of the unarchive post and label calls to restore.
+- Files: Allow upload of .unifi extension.
+- Bump Libraries:
+  - stripe-php from 19.0.0 to 19.4.1.
+  - fullcalendar from 6.1.19 to 6.1.20
+  - TCPDF from 6.10.1 to 6.11.2
+
 ## [26.02.1] Maint Release
 ### Bug Fixes
 - Credentials: Fix Password Generator.
@@ -12,7 +52,7 @@ This file documents all notable changes made to ITFlow.
 - Ticket Details: Deny access to client restricted agents to view tickets without client_id in uri.
 - Tickets: Allow agents with restricted client access to view and edit tickets without a client.
 - Ticket Change client: Limit selection for agents with restricted client access.
-- Ticket Details: Don't display Updated at when null.
+- Ticket Details: Don't display updated at when null.
 
 ### New Features & Updates 
 - Report: Added Client Detail Auditing.

README.md

@@ -82,7 +82,7 @@ We track the implementation of confirmed features and bugs via [TaskFlow](https:
 For help using ITFlow, bugs, feature requests, and general ideas / discussions please use the community [forum](https://forum.itflow.org).
 
 ### Contributing
-If you want to improve ITFlow, feel free to fork the repo and create a pull reques. Make sure to discuss significant changes or new features with fellow contributors on the forum first. This helps ensure that your contributions are aligned with project goals, and saves time for everyone. All contributions should follow our [code standards](https://docs.itflow.org/code_standards). See the [contributing guide](https://docs.itflow.org/contribute).
+We have temporarily paused PRs from the community.
 
 #### Contributors
 <a href="https://github.com/itflow-org/itflow/graphs/contributors">

admin/category.php

@@ -135,11 +135,11 @@ class="fas fa-fw fa-archive mr-2"></i>Archived</a>
                                         if ($archived) {
                                             ?>
                                             <a class="dropdown-item text-success confirm-link"
-                                                href="post.php?unarchive_category=<?php echo $category_id; ?>">
-                                                <i class="fas fa-fw fa-archive mr-2"></i>Unarchive
+                                                href="post.php?restore_category=<?php echo $category_id; ?>&csrf_token=<?= $_SESSION['csrf_token'] ?>">
+                                                <i class="fas fa-fw fa-archive mr-2"></i>Restore
                                             </a>
                                             <a class="dropdown-item text-danger confirm-link"
-                                                href="post.php?delete_category=<?php echo $category_id; ?>">
+                                                href="post.php?delete_category=<?php echo $category_id; ?>&csrf_token=<?= $_SESSION['csrf_token'] ?>">
                                                 <i class="fas fa-fw fa-trash mr-2"></i>Delete
                                             </a>
                                             <?php
@@ -150,7 +150,7 @@ class="fas fa-fw fa-archive mr-2"></i>Archived</a>
                                                 <i class="fas fa-fw fa-edit mr-2"></i>Edit
                                             </a>
                                             <a class="dropdown-item text-danger confirm-link"
-                                                href="post.php?archive_category=<?php echo $category_id; ?>">
+                                                href="post.php?archive_category=<?php echo $category_id; ?>&csrf_token=<?= $_SESSION['csrf_token'] ?>">
                                                 <i class="fas fa-fw fa-archive mr-2"></i>Archive
                                             </a>
                                             <?php

admin/custom_link.php

@@ -123,7 +123,7 @@
                                             <i class="fas fa-fw fa-edit mr-2"></i>Edit
                                         </a>
                                         <div class="dropdown-divider"></div>
-                                        <a class="dropdown-item text-danger text-bold confirm-link" href="post.php?delete_custom_link=<?php echo $custom_link_id; ?>">
+                                        <a class="dropdown-item text-danger text-bold confirm-link" href="post.php?delete_custom_link=<?php echo $custom_link_id; ?>&csrf_token=<?= $_SESSION['csrf_token'] ?>">
                                             <i class="fas fa-fw fa-trash mr-2"></i>Delete
                                         </a>
                                     </div>

admin/database_updates.php

@@ -4193,10 +4193,152 @@ function processFile($file_path, $file_name, $mysqli) {
         mysqli_query($mysqli, "UPDATE `settings` SET `config_current_database_version` = '2.4.0'");
     }
 
-    // if (CURRENT_DATABASE_VERSION == '2.4.0') {
-    //     // Insert queries here required to update to DB version 2.4.1
+    if (CURRENT_DATABASE_VERSION == '2.4.0') {
+
+        mysqli_query($mysqli, "
+            CREATE TABLE `quote_items` (
+              `item_id` int(11) NOT NULL AUTO_INCREMENT,
+              `item_name` varchar(200) NOT NULL,
+              `item_description` text DEFAULT NULL,
+              `item_quantity` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_price` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_subtotal` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_tax` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_total` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_order` int(11) NOT NULL DEFAULT 0,
+              `item_created_at` datetime NOT NULL DEFAULT current_timestamp(),
+              `item_updated_at` datetime DEFAULT NULL ON UPDATE current_timestamp(),
+              `item_archived_at` datetime DEFAULT NULL,
+              `item_tax_id` int(11) NOT NULL DEFAULT 0,
+              `item_product_id` int(11) NOT NULL DEFAULT 0,
+              `item_quote_id` int(11) NOT NULL,
+              PRIMARY KEY (`item_id`)
+            ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
+        ");
+
+        mysqli_query($mysqli, "
+            CREATE TABLE `recurring_invoice_items` (
+              `item_id` int(11) NOT NULL AUTO_INCREMENT,
+              `item_name` varchar(200) NOT NULL,
+              `item_description` text DEFAULT NULL,
+              `item_quantity` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_price` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_subtotal` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_tax` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_total` decimal(15,2) NOT NULL DEFAULT 0.00,
+              `item_order` int(11) NOT NULL DEFAULT 0,
+              `item_created_at` datetime NOT NULL DEFAULT current_timestamp(),
+              `item_updated_at` datetime DEFAULT NULL ON UPDATE current_timestamp(),
+              `item_archived_at` datetime DEFAULT NULL,
+              `item_tax_id` int(11) NOT NULL DEFAULT 0,
+              `item_product_id` int(11) NOT NULL DEFAULT 0,
+              `item_recurring_invoice_id` int(11) NOT NULL,
+              PRIMARY KEY (`item_id`)
+            ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
+        ");
+
+        mysqli_query($mysqli, "UPDATE `settings` SET `config_current_database_version` = '2.4.1'");
+    }
+
+    if (CURRENT_DATABASE_VERSION == '2.4.1') {
+
+        // Migrate Items
+        mysqli_query($mysqli, "
+            INSERT INTO `recurring_invoice_items` (
+              `item_name`,
+              `item_description`,
+              `item_quantity`,
+              `item_price`,
+              `item_subtotal`,
+              `item_tax`,
+              `item_total`,
+              `item_order`,
+              `item_created_at`,
+              `item_updated_at`,
+              `item_archived_at`,
+              `item_tax_id`,
+              `item_product_id`,
+              `item_recurring_invoice_id`
+            )
+            SELECT
+              `item_name`,
+              `item_description`,
+              `item_quantity`,
+              `item_price`,
+              `item_subtotal`,
+              `item_tax`,
+              `item_total`,
+              `item_order`,
+              `item_created_at`,
+              `item_updated_at`,
+              `item_archived_at`,
+              `item_tax_id`,
+              `item_product_id`,
+              `item_recurring_invoice_id`
+            FROM `invoice_items`
+            WHERE `item_recurring_invoice_id` != 0
+        ");
+
+        mysqli_query($mysqli, "
+            INSERT INTO `quote_items` (
+              `item_name`,
+              `item_description`,
+              `item_quantity`,
+              `item_price`,
+              `item_subtotal`,
+              `item_tax`,
+              `item_total`,
+              `item_order`,
+              `item_created_at`,
+              `item_updated_at`,
+              `item_archived_at`,
+              `item_tax_id`,
+              `item_product_id`,
+              `item_quote_id`
+            )
+            SELECT
+              `item_name`,
+              `item_description`,
+              `item_quantity`,
+              `item_price`,
+              `item_subtotal`,
+              `item_tax`,
+              `item_total`,
+              `item_order`,
+              `item_created_at`,
+              `item_updated_at`,
+              `item_archived_at`,
+              `item_tax_id`,
+              `item_product_id`,
+              `item_quote_id`
+            FROM `invoice_items`
+            WHERE `item_quote_id` != 0
+        ");
+
+        mysqli_query($mysqli, "
+            DELETE FROM `invoice_items`
+            WHERE `item_recurring_invoice_id` != 0
+        ");
+
+        mysqli_query($mysqli, "
+            DELETE FROM `invoice_items`
+            WHERE `item_quote_id` != 0
+        ");
+
+        mysqli_query($mysqli, "
+            ALTER TABLE `invoice_items`
+            DROP COLUMN `item_quote_id`,
+            DROP COLUMN `item_recurring_invoice_id`
+        ");
+
+        mysqli_query($mysqli, "UPDATE `settings` SET `config_current_database_version` = '2.4.2'");
+
+    }
+    //
+    // // if (CURRENT_DATABASE_VERSION == '2.4.2') {
+    //     // Insert queries here required to update to DB version 2.4.3
     //     // Then, update the database to the next sequential version
-    //     mysqli_query($mysqli, "UPDATE `settings` SET `config_current_database_version` = '2.4.1'");
+    //     mysqli_query($mysqli, "UPDATE `settings` SET `config_current_database_version` = '2.4.3'");
     // }
 
 } else {

admin/document_template.php

@@ -20,7 +20,7 @@
 
 <div class="card card-dark">
     <div class="card-header py-2">
-        <h3 class="card-title mt-2"><i class="fa fa-fw fa-file mr-2"></i>Document Templates</h3>
+        <h3 class="card-title mt-2"><i class="fa fa-fw fa-file-alt mr-2"></i>Document Templates</h3>
         <div class="card-tools">
             <button type="button" class="btn btn-primary ajax-modal" data-modal-url="modals/document_template/document_template_add.php" data-modal-size="xl">
                 <i class="fas fa-plus mr-2"></i>New Template
@@ -73,14 +73,23 @@
                             $document_template_content = nullable_htmlentities($row['document_template_content']);
                             $document_template_created_by_name = nullable_htmlentities($row['user_name']);
                             $document_template_created_at = nullable_htmlentities($row['document_template_created_at']);
-                            $document_template_updated_at = nullable_htmlentities($row['document_template_updated_at']);
+                            $document_template_updated_at = nullable_htmlentities(getFallback($row['document_template_updated_at']));
 
                     ?>
 
                     <tr>
                         <td>
-                            <a class="text-bold" href="document_template_details.php?document_template_id=<?php echo $document_template_id; ?>"><i class="fas fa-fw fa-file-alt text-dark"></i> <?php echo $document_template_name; ?></a>
-                            <div class="mt-1 text-secondary"><?php echo $document_template_description; ?></div>
+                            <a class="text-dark ajax-modal" href="#"
+                                data-modal-size="xl"
+                                data-modal-url="modals/document_template/document_template_edit.php?id=<?= $document_template_id ?>">
+                                <div class="media">
+                                    <i class="fas fa-fw fa-2x fa-file-alt mr-2"></i>
+                                    <div class="media-body">
+                                        <div><?= $document_template_name ?></div>
+                                        <div><small class="text-secondary"><?= $document_template_description ?></small></div>
+                                    </div>
+                                </div>
+                            </a>
                         </td>
                         <td>
                             <?php echo $document_template_created_at; ?>
@@ -93,13 +102,17 @@
                                     <i class="fas fa-ellipsis-h"></i>
                                 </button>
                                 <div class="dropdown-menu">
+                                    <a class="dropdown-item" href="document_template_details.php?document_template_id=<?= $document_template_id ?>">
+                                        <i class="fas fa-fw fa-eye mr-2"></i>View
+                                    </a>
+                                    <div class="dropdown-divider"></div>
                                     <a class="dropdown-item ajax-modal" href="#"
                                         data-modal-size="xl"
                                         data-modal-url="modals/document_template/document_template_edit.php?id=<?= $document_template_id ?>">
                                         <i class="fas fa-fw fa-edit mr-2"></i>Edit
                                     </a>
                                     <div class="dropdown-divider"></div>
-                                    <a class="dropdown-item text-danger text-bold" href="post.php?delete_document_template=<?php echo $document_template_id; ?>">
+                                    <a class="dropdown-item text-danger text-bold" href="post.php?delete_document_template=<?php echo $document_template_id; ?>&csrf_token=<?= $_SESSION['csrf_token'] ?>">
                                         <i class="fas fa-fw fa-trash mr-2"></i>Delete
                                     </a>
                                 </div>

admin/document_template_details.php

@@ -43,19 +43,19 @@
     <li class="breadcrumb-item">
         <a href="document_template.php">Document Templates</a>
     </li>
-    <li class="breadcrumb-item active"><i class="fas fa-file mr-2"></i><?php echo $document_template_name; ?></li>
+    <li class="breadcrumb-item active"><i class="fas fa-file-alt mr-2"></i><?php echo $document_template_name; ?></li>
 </ol>
 
 <div class="card card-dark">
-    <div class="card-header py-2">
+    <div class="card-header">
 
-        <h3 class="card-title mt-2"><i class="fa fa-fw fa-file mr-2"></i><?php echo $document_template_name; ?></h3>
+        <h3 class="card-title mt-1"><i class="fa fa-fw fa-file-alt mr-2"></i><?php echo $document_template_name; ?></h3>
 
         <div class="card-tools">
-            <button type="button" class="btn btn-primary ajax-modal"
+            <button type="button" class="btn btn-tool ajax-modal"
                 data-modal-size="xl"
                 data-modal-url="modals/document_template/document_template_edit.php?id=<?= $document_template_id ?>">
-                <i class="fas fa-edit mr-2"></i>Edit
+                <i class="fas fa-edit mr-2"></i>
             </button>
         </div>
     </div>

admin/includes/side_nav.php

@@ -139,7 +139,7 @@ class="nav-link <?php echo (in_array(basename($_SERVER['PHP_SELF']), ['ai_provid
                     </li>
                     <li class="nav-item">
                         <a href="/admin/document_template.php" class="nav-link <?php echo (in_array(basename($_SERVER['PHP_SELF']), ['document_template.php', 'document_template_details.php']) ? 'active' : ''); ?>">
-                            <i class="nav-icon fas fa-file"></i>
+                            <i class="nav-icon fas fa-file-alt"></i>
                             <p>Document Templates</p>
                         </a>
                     </li>