feat(iota-sdk-types)!: make MoveStruct contents checked (#1065)

* feat(iota-sdk-types)!: make MoveStruct contents checked

* use thiserror

* remove contents_mut_unchecked()

* make remaining fields private, move serialization

Author: Thoralf-M

crates/iota-sdk-ffi/src/types/object.rs

@@ -561,22 +561,24 @@ pub struct MoveStruct {
 
 impl From<iota_sdk::types::MoveStruct> for MoveStruct {
     fn from(value: iota_sdk::types::MoveStruct) -> Self {
-        let struct_tag: iota_sdk::types::StructTag = value.object_type.into();
+        let (object_type, version, contents) = value.into_parts();
+        let struct_tag: iota_sdk::types::StructTag = object_type.into();
         Self {
             struct_type: Arc::new(struct_tag.into()),
-            version: Arc::new(value.version.into()),
-            contents: value.contents,
+            version: Arc::new(version.into()),
+            contents,
         }
     }
 }
 
 impl From<MoveStruct> for iota_sdk::types::MoveStruct {
     fn from(value: MoveStruct) -> Self {
-        Self {
-            object_type: value.struct_type.0.clone().into(),
-            version: **value.version,
-            contents: value.contents,
-        }
+        iota_sdk::types::MoveStruct::new(
+            value.struct_type.0.clone().into(),
+            **value.version,
+            value.contents,
+        )
+        .expect("FFI MoveStruct should always have valid contents")
     }
 }
 

crates/iota-sdk-types/src/framework.rs

@@ -30,22 +30,21 @@ impl Coin {
         match &object.data {
             super::ObjectData::Struct(move_struct) => {
                 let coin_type = move_struct
-                    .object_type
+                    .object_type()
                     .coin_type_opt()
                     .ok_or(CoinFromObjectError::NotACoin)?;
 
-                let contents = &move_struct.contents;
+                let contents = move_struct.contents();
                 if contents.len() != ObjectId::LENGTH + std::mem::size_of::<u64>() {
                     return Err(CoinFromObjectError::InvalidContentLength);
                 }
 
-                let id = ObjectId::new((&contents[..ObjectId::LENGTH]).try_into().unwrap());
                 let balance =
                     u64::from_le_bytes((&contents[ObjectId::LENGTH..]).try_into().unwrap());
 
                 Ok(Self {
                     coin_type: coin_type.clone(),
-                    id,
+                    id: move_struct.id(),
                     balance,
                 })
             }

crates/iota-sdk-types/src/lib.rs

@@ -160,8 +160,8 @@ pub use gas::GasCostSummary;
 pub use move_core::{Identifier, StructTag, TypeParseError, TypeTag};
 pub use move_package::{MovePackage, MovePackageData, TypeOrigin, UpgradeInfo, UpgradePolicy};
 pub use object::{
-    GenesisObject, MoveObjectType, MoveStruct, Object, ObjectData, ObjectReference, ObjectType,
-    Owner,
+    GenesisObject, MoveObjectType, MoveStruct, MoveStructContentsError, Object, ObjectData,
+    ObjectReference, ObjectType, Owner,
 };
 pub use object_id::ObjectId;
 #[cfg(feature = "serde")]