Address PR review feedback

- Remove explicit commons-collections dependency (pulled in transitively
  by json-path; old 3.x artifact has known CVEs)
- Add CONTRIBUTING.md with setup, coding standards, and PR guidelines
- Remove implements Serializable from JsonTransformer (ObjectMapper is
  not serializable; interface was unused)
- Make ObjectMapper private in ProcessorUtils (internal detail; public
  field allowed external mutation of the shared instance)
- Add overflow warning when Long value exceeds int range in
  handleIntegerSchema; behaviour is documented via log.warn

Made-with: Cursor

Author: Pratik Lala

CONTRIBUTING.md

@@ -0,0 +1,115 @@
+# Contributing to json2jsontransformer
+
+Thank you for your interest in contributing! This guide covers everything you need to get started.
+
+## Table of Contents
+
+- [Code of Conduct](#code-of-conduct)
+- [Getting Started](#getting-started)
+- [How to Contribute](#how-to-contribute)
+- [Development Setup](#development-setup)
+- [Running Tests](#running-tests)
+- [Submitting a Pull Request](#submitting-a-pull-request)
+- [Coding Standards](#coding-standards)
+
+---
+
+## Code of Conduct
+
+This project follows the [Contributor Covenant Code of Conduct](https://www.contributor-covenant.org/version/2/1/code_of_conduct/).
+Please be respectful and inclusive in all interactions.
+
+---
+
+## Getting Started
+
+1. **Fork** the repository on GitHub
+2. **Clone** your fork locally:
+   ```bash
+   git clone [email protected]:<your-username>/json2jsontransformer.git
+   cd json2jsontransformer
+   ```
+3. **Add the upstream remote**:
+   ```bash
+   git remote add upstream [email protected]:intuit/json2jsontransformer.git
+   ```
+
+---
+
+## How to Contribute
+
+- **Bug reports** — Open a GitHub Issue with steps to reproduce, expected behaviour, and actual behaviour.
+- **Feature requests** — Open a GitHub Issue describing the use case and proposed API.
+- **Code changes** — Fork → branch → PR (see below).
+- **Documentation** — README improvements and Javadoc fixes are always welcome.
+
+---
+
+## Development Setup
+
+**Prerequisites:**
+- Java 11+ (`export JAVA_HOME=$(/usr/libexec/java_home -v 11)` on macOS)
+- Maven 3.6+
+
+**Build the project:**
+```bash
+mvn clean install
+```
+
+**Build the fat JAR:**
+```bash
+mvn clean package
+```
+
+---
+
+## Running Tests
+
+```bash
+mvn clean test
+```
+
+All pull requests must pass the full test suite. New features or bug fixes should include corresponding test cases in `JsonTransformerTest.java`.
+
+---
+
+## Submitting a Pull Request
+
+1. Sync your fork with upstream:
+   ```bash
+   git fetch upstream
+   git checkout main
+   git merge upstream/main
+   ```
+2. Create a feature branch:
+   ```bash
+   git checkout -b feature/my-change
+   ```
+3. Make your changes and commit with a clear message:
+   ```bash
+   git commit -m "Add support for XYZ"
+   ```
+4. Push and open a PR against `main`:
+   ```bash
+   git push origin feature/my-change
+   ```
+5. Fill in the PR description explaining **what** changed and **why**.
+
+The CI workflow will automatically run tests against Java 11, 17, and 21.
+
+---
+
+## Coding Standards
+
+- Follow existing code style (4-space indentation, standard Java conventions)
+- Use Lombok annotations (`@Getter`, `@Slf4j`) consistently — avoid `@Data` on library-facing classes
+- Add `@JsonIgnoreProperties(ignoreUnknown = true)` to any new config POJOs
+- Prefer `LinkedHashMap` over `HashMap` when field order in JSON output matters
+- Write Javadoc for all public classes and methods
+- Do not introduce new dependencies without discussion in a GitHub Issue first
+
+---
+
+## License
+
+By contributing, you agree that your contributions will be licensed under the [Apache License 2.0](LICENSE).

pom.xml

@@ -75,7 +75,6 @@
         <json-smart.version>2.5.2</json-smart.version>
         <lombok.version>1.18.36</lombok.version>
         <commons-lang3.version>3.14.0</commons-lang3.version>
-        <commons-collections.version>3.2.2</commons-collections.version>
         <slf4j.version>2.0.13</slf4j.version>
         <logback.version>1.5.6</logback.version>
         <junit-jupiter.version>5.11.0</junit-jupiter.version>
@@ -120,12 +119,6 @@
             <artifactId>commons-lang3</artifactId>
             <version>${commons-lang3.version}</version>
         </dependency>
-        <dependency>
-            <groupId>commons-collections</groupId>
-            <artifactId>commons-collections</artifactId>
-            <version>${commons-collections.version}</version>
-        </dependency>
-
         <!-- Logging -->
         <dependency>
             <groupId>org.slf4j</groupId>

src/main/java/com/intuit/json2jsontransformer/JsonTransformer.java

@@ -20,7 +20,6 @@
 import org.apache.commons.lang3.StringUtils;
 
 import java.io.IOException;
-import java.io.Serializable;
 import java.net.URISyntaxException;
 import java.nio.file.Files;
 import java.nio.file.Paths;
@@ -57,7 +56,7 @@
  */
 @Slf4j
 @Getter
-public class JsonTransformer implements Serializable {
+public class JsonTransformer {
 
     private ObjectMapper mapper;
     private Map<String, List<JsonTransformerConfig>> configsMap;
@@ -187,7 +186,11 @@ private Object handleIntegerSchema(DocumentContext inputContext, TargetSchema ta
                     if (readValue instanceof Integer) {
                         return readValue;
                     } else if (readValue instanceof Long) {
-                        return ((Long) readValue).intValue();
+                        long longVal = (Long) readValue;
+                        if (longVal < Integer.MIN_VALUE || longVal > Integer.MAX_VALUE) {
+                            log.warn("Long value {} overflows int range for field='{}'; value will be clamped", longVal, fieldName);
+                        }
+                        return (int) longVal;
                     } else if (readValue instanceof String) {
                         return Integer.parseInt((String) readValue);
                     }

src/main/java/com/intuit/json2jsontransformer/utils/ProcessorUtils.java

@@ -8,7 +8,7 @@
 @Slf4j
 public class ProcessorUtils {
 
-    public static final ObjectMapper objectMapper = new ObjectMapper();
+    private static final ObjectMapper objectMapper = new ObjectMapper();
 
     private ProcessorUtils() {}