feat: upgrade google.golang.org/api package#2889
Conversation
|
Hi @bnpfeife, @jdstrand |
More than just kapacitor uses the cross-builder, so if updating, would have to be sure the other repos are still ok. @bnpfeife, thoughts? |
bednar
left a comment
There was a problem hiding this comment.
We have to use the version of protobuf which is in cross-builder.
There was a problem hiding this comment.
Pull request overview
This PR updates the module dependency set to restore compatibility between google.golang.org/grpc (1.79.x credential changes) and google.golang.org/api by upgrading google.golang.org/api to v0.273.0, along with related dependency and generated-code updates.
Changes:
- Bump
google.golang.org/apito v0.273.0 (and refresh related transitive dependencies) viago.mod/go.sum. - Regenerate UDF protobuf bindings (Go + Python) against newer protobuf tooling/runtime.
- Update build/CI images to
quay.io/influxdb/cross-builder:go1.25.9-latestand refresh the changelog header sections.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Updates direct/indirect module versions, including google.golang.org/api v0.273.0 and newer protobuf/tooling deps. |
go.sum |
Refreshes dependency checksums consistent with the updated module graph. |
udf/agent/udf.pb.go |
Regenerated Go protobuf output (newer protoc-gen-go / protobuf runtime patterns). |
udf/agent/py/kapacitor/udf/udf_pb2.py |
Regenerated Python protobuf output (version bump to protobuf 5.29.3). |
Dockerfile_build_ubuntu64 |
Updates cross-builder image tag to Go 1.25.9. |
.circleci/config.yml |
Updates CI executor image tag to Go 1.25.9. |
CHANGELOG.md |
Updates top-of-file release sections/version headings. |
Files not reviewed (2)
- udf/agent/py/kapacitor/udf/udf_pb2.py: Language not supported
- udf/agent/udf.pb.go: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| FROM quay.io/influxdb/cross-builder:go1.25.7-latest | |||
| FROM quay.io/influxdb/cross-builder:go1.25.9-latest | |||
38a20b5 to
654a2bf
Compare
7a315ff to
056d8b1
Compare
Required checklist
/etcfolder andNewDemoConfigmethods) (influxdb and plutonium)Description
DefaultCredentialsOptions{}in "google.golang.org/[email protected]/credentials/google/google.go" file will make code in the "google.golang.org/api" package not working anymore, so we need to upgrade the "google.golang.org/api" to the latest version v0.273.0.Note for reviewers: