Skip to content

feat: upgrade google.golang.org/api package#2889

Closed
NguyenHoangSon96 wants to merge 0 commit into
masterfrom
feat/upgrade-google-api-package
Closed

feat: upgrade google.golang.org/api package#2889
NguyenHoangSon96 wants to merge 0 commit into
masterfrom
feat/upgrade-google-api-package

Conversation

@NguyenHoangSon96
Copy link
Copy Markdown
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Mar 30, 2026

Required checklist

  • Sample config files updated (both /etc folder and NewDemoConfig methods) (influxdb and plutonium)
  • openapi swagger.yml updated (if modified API) - link openapi PR
  • Signed CLA (if not already signed)

Description

  • Change from this truct DefaultCredentialsOptions{} in "google.golang.org/[email protected]/credentials/google/google.go" file will make code in the "google.golang.org/api" package not working anymore, so we need to upgrade the "google.golang.org/api" to the latest version v0.273.0.

Note for reviewers:

  • This PR will fix this dependabot PR

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Mar 30, 2026
@NguyenHoangSon96
Copy link
Copy Markdown
Contributor Author

Hi @bnpfeife, @jdstrand
Any reason why we should not update the "quay.io/influxdb/cross-builder" image environment variable "PROTOC_GEN_GO_VER" from "v1.34.1" to "v1.36.11"?
I'm asking because I'm upgrading "grpc" package to "1.79.3" and It will need other packages to upgrade also.
Currently, the error in "static-code-checks" can be fixed by upgrading "PROTOC_GEN_GO_VER" to "v1.36.11" and re-run go generate ./... command.

@jdstrand
Copy link
Copy Markdown
Contributor

jdstrand commented Apr 6, 2026

Hi @bnpfeife, @jdstrand Any reason why we should not update the "quay.io/influxdb/cross-builder" image environment variable "PROTOC_GEN_GO_VER" from "v1.34.1" to "v1.36.11"? I'm asking because I'm upgrading "grpc" package to "1.79.3" and It will need other packages to upgrade also. Currently, the error in "static-code-checks" can be fixed by upgrading "PROTOC_GEN_GO_VER" to "v1.36.11" and re-run go generate ./... command.

More than just kapacitor uses the cross-builder, so if updating, would have to be sure the other repos are still ok. @bnpfeife, thoughts?

Copy link
Copy Markdown
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to use the version of protobuf which is in cross-builder.

Copilot AI review requested due to automatic review settings May 22, 2026 07:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the module dependency set to restore compatibility between google.golang.org/grpc (1.79.x credential changes) and google.golang.org/api by upgrading google.golang.org/api to v0.273.0, along with related dependency and generated-code updates.

Changes:

  • Bump google.golang.org/api to v0.273.0 (and refresh related transitive dependencies) via go.mod/go.sum.
  • Regenerate UDF protobuf bindings (Go + Python) against newer protobuf tooling/runtime.
  • Update build/CI images to quay.io/influxdb/cross-builder:go1.25.9-latest and refresh the changelog header sections.

Reviewed changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
go.mod Updates direct/indirect module versions, including google.golang.org/api v0.273.0 and newer protobuf/tooling deps.
go.sum Refreshes dependency checksums consistent with the updated module graph.
udf/agent/udf.pb.go Regenerated Go protobuf output (newer protoc-gen-go / protobuf runtime patterns).
udf/agent/py/kapacitor/udf/udf_pb2.py Regenerated Python protobuf output (version bump to protobuf 5.29.3).
Dockerfile_build_ubuntu64 Updates cross-builder image tag to Go 1.25.9.
.circleci/config.yml Updates CI executor image tag to Go 1.25.9.
CHANGELOG.md Updates top-of-file release sections/version headings.
Files not reviewed (2)
  • udf/agent/py/kapacitor/udf/udf_pb2.py: Language not supported
  • udf/agent/udf.pb.go: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Dockerfile_build_ubuntu64
@@ -1,4 +1,4 @@
FROM quay.io/influxdb/cross-builder:go1.25.7-latest
FROM quay.io/influxdb/cross-builder:go1.25.9-latest
Comment thread .circleci/config.yml
Comment thread CHANGELOG.md
@NguyenHoangSon96 NguyenHoangSon96 force-pushed the feat/upgrade-google-api-package branch 2 times, most recently from 38a20b5 to 654a2bf Compare May 22, 2026 07:57
@NguyenHoangSon96 NguyenHoangSon96 force-pushed the feat/upgrade-google-api-package branch from 7a315ff to 056d8b1 Compare May 22, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants