chore: Satisfy Clippy

Author: icorbrey

src/backend/config.rs

@@ -54,7 +54,8 @@ impl FromWorld for Config {
 
 impl Config {
     #[mutants::skip]
-    pub fn default() -> Self {
+    #[allow(clippy::new_without_default)] // Default conflicts with FromWorld
+    pub fn new() -> Self {
         default_table()
     }
 }
@@ -136,14 +137,12 @@ mod tests {
             Some(&Config {
                 log: LogConfig {
                     poll_interval_ms: 123,
-                    ..default_table()
                 },
                 splash: SplashConfig {
                     skip: true,
                     total_duration_ms: 4567,
                     ..default_table()
                 },
-                ..default_table()
             })
         );
     }

src/backend/poll.rs

@@ -55,9 +55,8 @@ impl PollTimer {
     }
 
     fn debounce(mut poll_timer: ResMut<Self>, mut ev_log_response: EventReader<LogResponseEvent>) {
-        for _ in ev_log_response.read() {
+        if ev_log_response.read().next().is_some() {
             poll_timer.reset();
-            break;
         }
     }
 }
@@ -77,7 +76,7 @@ mod tests {
             log: LogConfig {
                 poll_interval_ms: 50,
             },
-            ..Config::default()
+            ..Config::new()
         });
 
         app.init_resource::<Time>();

src/frontend/change_buffer.rs

@@ -57,6 +57,7 @@ impl Default for IndexSelection {
     }
 }
 
+#[allow(clippy::large_enum_variant)]
 #[derive(Clone)]
 pub enum RevisionSelection {
     Single(Revision),
@@ -72,7 +73,7 @@ fn read_keys(
 ) -> Result<()> {
     let mut change_buffer = change_buffer.get_single_mut()?;
 
-    if change_buffer.revisions.len() == 0 {
+    if change_buffer.revisions.is_empty() {
         return Ok(());
     }
 
@@ -225,9 +226,7 @@ impl StatefulWidget for ChangeBuffer {
 
         let selected_lines = match self.selection {
             IndexSelection::Single(index) => map_index(index),
-            IndexSelection::Range(start, end) => {
-                map_index(start).start().clone()..=map_index(end).end().clone()
-            }
+            IndexSelection::Range(start, end) => *map_index(start).start()..=*map_index(end).end(),
         };
 
         let mut lines = vec![];
@@ -286,9 +285,9 @@ impl LogLine {
                     is_selected,
                 })]
             }
-            LogOutput::Revision(revision) => RevisionLine::vec_from(&revision, is_selected)
+            LogOutput::Revision(revision) => RevisionLine::vec_from(revision, is_selected)
                 .into_iter()
-                .map(|l| Self::Revision(l))
+                .map(Self::Revision)
                 .collect(),
         }
     }

src/frontend/navigation.rs

@@ -22,7 +22,7 @@ pub fn plugin(app: &mut App) {
 ///
 /// ```rust
 /// pub fn navigate(mut navigation: Navigation, state: Res<State>) {
-/// 	...
+///     ...
 /// }
 /// ```
 #[derive(SystemParam)]
@@ -176,7 +176,7 @@ impl Navigation<'_, '_> {
 /// pub struct SpaceMenu;
 ///
 /// pub fn plugin(app: &mut App) {
-/// 	app.add_systems(Update, read_keys.run_if(is_focused::<SpaceMenu>));
+///     app.add_systems(Update, read_keys.run_if(is_focused::<SpaceMenu>));
 /// }
 ///
 /// fn read_keys(ev_keypress: EventReader<KeyEvent>) { ... }
@@ -246,7 +246,7 @@ mod tests {
         let entity = app.world_mut().spawn_empty().id();
 
         (app.world_mut()).run_system_once(move |mut navigation: Navigation| {
-            navigation.focus_as_root(entity.clone());
+            navigation.focus_as_root(entity);
         })?;
 
         (app.world_mut()).run_system_once(move |q: Query<(&Focus, &NavigationRoot)>| {

src/logger.rs

@@ -3,17 +3,12 @@
 //! ## Usage
 //!
 //! ```rust
-//! use crate::logger;
+//! logger::install();
 //!
-//! fn main() {
-//!     logger::install();
-//!
-//!     // Your application code here
-//!     info!("This is an info message");
-//!     debug!("This is a debug message");
-//!     warn!("This is a warning message");
-//!
-//!     logger::dump();
+//! // Your application code here
+//! info!("This is an info message");
+//! debug!("This is a debug message");
+//! warn!("This is a warning message");
 //! }
 //! ```