Change readme and ci.yml to use pnpm for everything, same as the release-workflow (#179)

Co-authored-by: Copilot <copilot@github.com>

Author: hnn0003

.changeset/common-cameras-cross.md

@@ -0,0 +1,4 @@
+---
+---
+
+Update ci.yml

.changeset/fair-stamps-swim.md

@@ -0,0 +1,6 @@
+---
+"@itwin/saved-views-client": patch
+"@itwin/saved-views-react": patch
+---
+
+Update dependencies to fix audit issues and throw error instead of 0 on callITwinApi failure

.eslintrc.json

@@ -16,10 +16,12 @@
     "no-alert": "warn",
     "no-empty": [ "warn", { "allowEmptyCatch": true } ],
     "no-eval": "error",
-    "@typescript-eslint/comma-dangle": [ "warn", "always-multiline" ],
-    "@typescript-eslint/member-delimiter-style": [ "warn", { "singleline": { "requireLast": true } } ],
+    "comma-dangle": [ "warn", "always-multiline" ],
+    "quotes": "warn",
     "@typescript-eslint/no-confusing-void-expression": [ "warn", { "ignoreArrowShorthand": true } ],
+    "@typescript-eslint/no-duplicate-type-constituents": "warn",
     "@typescript-eslint/no-empty-function": "off",
+    "@typescript-eslint/no-empty-object-type": "off",
     "@typescript-eslint/no-misused-promises": [ "error", { "checksVoidReturn": false } ],
     "@typescript-eslint/no-non-null-assertion": "warn",
     "@typescript-eslint/no-redundant-type-constituents": "off",
@@ -30,8 +32,8 @@
     "@typescript-eslint/no-unsafe-enum-comparison": "off",
     "@typescript-eslint/no-unsafe-member-access": "off",
     "@typescript-eslint/no-unsafe-return": "off",
+    "@typescript-eslint/no-unused-expressions": [ "error", { "allowShortCircuit": true, "allowTernary": true } ],
     "@typescript-eslint/no-unused-vars": [ "warn", { "argsIgnorePattern": "^_", "ignoreRestSiblings": true } ],
-    "@typescript-eslint/quotes": "warn",
     "@typescript-eslint/return-await": "warn",
     "@typescript-eslint/require-await": "off",
     "@typescript-eslint/switch-exhaustiveness-check": "warn",

.github/workflows/CI.yaml

@@ -31,19 +31,23 @@ jobs:
       run: pnpm install
 
     - name: ESLint
-      run: npm run lint -- --max-warnings 0
+      run: pnpm run lint --max-warnings 0
 
     - name: Typecheck
-      run: npm run typecheck
+      run: pnpm run typecheck
 
     - name: Run Audit
       run: pnpm audit --audit-level high
 
     - name: Check saved-views-client unit test coverage
-      run: npm run test:cover --prefix ./packages/saved-views-client
+      run: |
+        cd packages/saved-views-client &&
+        pnpm run test:cover
 
     - name: Check saved-views-react unit test coverage
-      run: npm run test:cover --prefix ./packages/saved-views-react
+      run: |
+        cd packages/saved-views-react &&
+        pnpm run test:cover
 
     - name: Check if changeset is present
       if: github.actor != 'imodeljs-admin'

README.md

@@ -21,17 +21,17 @@
 * Start the test application.
 
   ```shell
-  npm start
+  pnpm start
   ```
 
 * You can now edit TypeScript and CSS source files and changes will automatically be reflected in the test app.
 
 ## Top-level commands
 
-* `npm start` – starts the test app which can be accessed at [http://localhost:7948](http://localhost:7948)
+* `pnpm start` – starts the test app which can be accessed at [http://localhost:7948](http://localhost:7948)
   * To enable app features that use [iTwin Platform](https://developer.bentley.com/), see [`packages/test-app-frontend/.env`](./packages/test-app-frontend/.env) file.
-* `npm run lint` – runs ESLint on all TypeScript files in this repository
-* `npm run typecheck` – type checks all packages in this repository
+* `pnpm run lint` – runs ESLint on all TypeScript files in this repository
+* `pnpm run typecheck` – type checks all packages in this repository
 
 ## Contributing
 

package.json

@@ -24,12 +24,26 @@
     "npm": "<0",
     "node": ">=20"
   },
+  "pnpm": {
+    "overrides": {
+      "path-to-regexp@<0.1.13": ">=0.1.13",
+      "picomatch@>=4.0.0 <4.0.4": "4.0.4",
+      "brace-expansion@<1.1.13": "1.1.13",
+      "brace-expansion@>=4.0.0 <5.0.5": ">=5.0.5",
+      "fast-xml-parser@<5.7.0": ">=5.7.0",
+      "follow-redirects@<=1.15.11": ">=1.16.0",
+      "dompurify@<=3.3.3": ">=3.4.0",
+      "axios@>=1.0.0 <1.15.0": ">=1.15.0",
+      "i18next-http-backend@<3.0.5": ">=3.0.5",
+      "postcss@<8.5.10": ">=8.5.10"
+    }
+  },
   "dependencies": {
     "@changesets/types": "6.0.0",
     "@changesets/cli": "^2.29.4",
     "@types/node": "^18.11.9",
-    "@typescript-eslint/eslint-plugin": "^7.4.0",
-    "@typescript-eslint/parser": "^7.4.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
     "eslint": "^8.57.0",
     "eslint-plugin-react": "^7.35.2",
     "eslint-plugin-react-hooks": "^4.6.2",

packages/saved-views-client/package.json

@@ -43,10 +43,10 @@
   },
   "devDependencies": {
     "@vitest/coverage-v8": "^4.0.16",
-    "happy-dom": "^20.0.0",
+    "happy-dom": "^20.8.9",
     "rimraf": "^6.1.2",
     "typescript": "^5.5.4",
-    "vite": "^6.4.1",
+    "vite": "^6.4.2",
     "vitest": "^4.0.16"
   }
 }

packages/saved-views-client/src/client/ApiUtils.ts

@@ -44,7 +44,7 @@ async function throwBadResponseCodeError(response: Response, errorMessage: strin
   try {
     const resp = (await response.json());
     if (!isErrorResponse(resp)) {
-      throw 0;
+      throw new Error();
     }
     error = resp.error;
   } catch {

packages/saved-views-react/package.json

@@ -53,14 +53,14 @@
     "@types/recursive-readdir": "^2.2.2",
     "@vitejs/plugin-react-swc": "^3.5.0",
     "@vitest/coverage-v8": "^4.0.16",
-    "cpx2": "^5.0.0",
-    "happy-dom": "^20.0.0",
+    "cpx2": "^8.0.0",
+    "happy-dom": "^20.8.9",
     "npm-run-all": "^4.1.5",
     "react": "^18.0.0",
     "react-dom": "^18.0.0",
     "recursive-readdir": "^2.2.3",
     "typescript": "^5.5.4",
-    "vite": "^6.4.1",
+    "vite": "^6.4.2",
     "vitest": "^4.0.16"
   },
   "peerDependencies": {

packages/saved-views-react/src/useSavedViews.tsx

@@ -125,7 +125,7 @@ export interface SavedViewsActions {
   updateSavedView: (
     savedViewId: string,
     savedView: Partial<WriteableSavedViewProperties>,
-    savedViewData?: SavedViewData | undefined,
+    savedViewData?: SavedViewData,
   ) => Promise<void>;
 
   /**