Skip to content

Commit 192bb4f

Browse files
authored
Heather/fix view details (#163)
Fix for when a view contains a clip plane--we were returning the original viewDetails info instead of the newly extracted/transformed info.
1 parent 982ac36 commit 192bb4f

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

.changeset/itchy-heads-search.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@itwin/saved-views-react": patch
3+
---
4+
5+
Fix for viewDetails when a view has a clip plane

packages/saved-views-react/src/translation/viewDetailsLegacyExtractor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export function extractViewDetails3dFromLegacy(
5353
clipGroup.clipVectors = clipGroup.clipVectors?.filter(isValidClipPrimitive);
5454
}
5555

56-
return viewDetails;
56+
return output;
5757
}
5858

5959
const modelClipGroupLegacyMappings = [

0 commit comments

Comments
 (0)