fix: resolve mypy type annotation errors in test files and CLI

- Add -> None return type annotations to all test functions
- Fix positional-only parameter issue in deprecated_wrapper function
- Add Path type annotation for temp_project_dir parameter in test_stats.py

All mypy checks now pass successfully.

🤖 Generated with Claude Code

Co-Authored-By: Claude <[email protected]>

Author: Really Him

fix_remaining_annotations.py

@@ -0,0 +1,43 @@
+import re
+from pathlib import Path
+
+# Remaining test files with mypy errors
+test_files = [
+    "tests/unit/cli/test_config_view.py",
+]
+
+for file_path in test_files:
+    path = Path(file_path)
+    if not path.exists():
+        print(f"Skipping {file_path} (not found)")
+        continue
+
+    content = path.read_text()
+
+    # Pattern to match test functions without return type annotation
+    pattern = r'(\s+def test_[^(]+\(self[^)]*\))(\s*:)'
+
+    def replacer(match):
+        # Add -> None before the colon
+        return match.group(1) + ' -> None' + match.group(2)
+
+    # Apply the replacement
+    new_content = re.sub(pattern, replacer, content)
+
+    if new_content != content:
+        path.write_text(new_content)
+        print(f"Fixed {file_path}")
+    else:
+        print(f"No changes needed for {file_path}")
+
+# Now fix the specific issue in test_stats.py - missing type annotation for temp_project_dir parameter
+stats_file = Path("tests/unit/cli/test_stats.py")
+if stats_file.exists():
+    content = stats_file.read_text()
+    # Fix the specific line with missing parameter type annotation
+    content = content.replace(
+        "def test_negative_depth(self, temp_project_dir) -> None:",
+        "def test_negative_depth(self, temp_project_dir: Path) -> None:"
+    )
+    stats_file.write_text(content)
+    print(f"Fixed parameter annotation in tests/unit/cli/test_stats.py")

fix_test_annotations.py

@@ -0,0 +1,37 @@
+import re
+from pathlib import Path
+
+# List of test files with mypy errors
+test_files = [
+    "tests/unit/cli/test_validate_config.py",
+    "tests/unit/cli/test_ignore_patterns.py",
+    "tests/unit/cli/test_generate_config.py",
+    "tests/unit/cli/test_metrics.py",
+    "tests/unit/cli/test_config.py",
+    "tests/unit/cli/test_stats.py",
+]
+
+for file_path in test_files:
+    path = Path(file_path)
+    if not path.exists():
+        print(f"Skipping {file_path} (not found)")
+        continue
+
+    content = path.read_text()
+
+    # Pattern to match test functions without return type annotation
+    # Matches: def test_name(self): or def test_name(self, ...):
+    pattern = r'(\s+def test_[^(]+\(self[^)]*\))(\s*:)'
+
+    def replacer(match):
+        # Add -> None before the colon
+        return match.group(1) + ' -> None' + match.group(2)
+
+    # Apply the replacement
+    new_content = re.sub(pattern, replacer, content)
+
+    if new_content != content:
+        path.write_text(new_content)
+        print(f"Fixed {file_path}")
+    else:
+        print(f"No changes needed for {file_path}")

src/antipasta/cli/main.py

@@ -34,7 +34,7 @@ def create_deprecated_command(new_cmd_path: str, old_function: click.Command) ->
 
     @click.command(hidden=True)  # Hidden from help text
     @click.pass_context
-    def deprecated_wrapper(ctx: click.Context, **kwargs: Any) -> None:
+    def deprecated_wrapper(ctx: click.Context, /, **kwargs: Any) -> None:
         click.echo(
             f"⚠️  Warning: This command is deprecated. "
             f"Please use 'antipasta {new_cmd_path}' instead.",

tests/unit/cli/test_config.py

@@ -11,7 +11,7 @@
 class TestConfigCommandGroup:
     """Test the config command group and subcommands."""
 
-    def test_config_help(self):
+    def test_config_help(self) -> None:
         """Test config command help."""
         runner = CliRunner()
         result = runner.invoke(cli, ["config", "--help"])
@@ -23,7 +23,7 @@ def test_config_help(self):
         assert "validate" in result.output
         assert "view" in result.output
 
-    def test_config_generate_subcommand(self):
+    def test_config_generate_subcommand(self) -> None:
         """Test config generate subcommand works."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -38,7 +38,7 @@ def test_config_generate_subcommand(self):
             assert output_file.exists()
             assert "✅ Configuration saved to" in result.output
 
-    def test_config_validate_subcommand(self):
+    def test_config_validate_subcommand(self) -> None:
         """Test config validate subcommand works."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -68,7 +68,7 @@ def test_config_validate_subcommand(self):
             assert result.exit_code == 0
             assert "✅ Configuration file is valid" in result.output
 
-    def test_config_view_subcommand(self):
+    def test_config_view_subcommand(self) -> None:
         """Test config view subcommand works."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -98,7 +98,7 @@ def test_config_view_subcommand(self):
             assert f"Configuration: {config_file}" in result.output
             assert "Status: ✅ Valid" in result.output
 
-    def test_backward_compatibility_generate_config(self):
+    def test_backward_compatibility_generate_config(self) -> None:
         """Test backward compatibility for generate-config command."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -115,7 +115,7 @@ def test_backward_compatibility_generate_config(self):
             assert "Please use 'antipasta config generate'" in result.output
             assert output_file.exists()
 
-    def test_backward_compatibility_validate_config(self):
+    def test_backward_compatibility_validate_config(self) -> None:
         """Test backward compatibility for validate-config command."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -147,7 +147,7 @@ def test_backward_compatibility_validate_config(self):
             assert "Please use 'antipasta config validate'" in result.output
             assert "✅ Configuration file is valid" in result.output
 
-    def test_deprecated_commands_hidden_from_help(self):
+    def test_deprecated_commands_hidden_from_help(self) -> None:
         """Test that deprecated commands are hidden from main help."""
         runner = CliRunner()
         result = runner.invoke(cli, ["--help"])

tests/unit/cli/test_config_view.py

@@ -13,7 +13,7 @@
 class TestConfigViewCommand:
     """Test the config view command."""
 
-    def test_view_valid_config_summary(self):
+    def test_view_valid_config_summary(self) -> None:
         """Test viewing a valid configuration in summary format."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -55,7 +55,7 @@ def test_view_valid_config_summary(self):
             assert "IGNORE PATTERNS (2)" in result.output
             assert "Using .gitignore: Yes" in result.output
 
-    def test_view_nonexistent_config(self):
+    def test_view_nonexistent_config(self) -> None:
         """Test viewing a nonexistent configuration file."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -67,7 +67,7 @@ def test_view_nonexistent_config(self):
             assert "Configuration file not found" in result.output
             assert "Run 'antipasta config generate'" in result.output
 
-    def test_view_invalid_config_with_validation(self):
+    def test_view_invalid_config_with_validation(self) -> None:
         """Test viewing an invalid configuration with validation enabled."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -91,7 +91,7 @@ def test_view_invalid_config_with_validation(self):
             assert "Status: ❌ Invalid" in result.output
             assert "Configuration has validation errors" in result.output
 
-    def test_view_raw_format(self):
+    def test_view_raw_format(self) -> None:
         """Test viewing configuration in raw format."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -107,7 +107,7 @@ def test_view_raw_format(self):
             assert result.exit_code == 0
             assert result.output.strip() == content.strip()
 
-    def test_view_json_format(self):
+    def test_view_json_format(self) -> None:
         """Test viewing configuration in JSON format."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -142,7 +142,7 @@ def test_view_json_format(self):
             assert data["languages"][0]["name"] == "python"
             assert data["use_gitignore"] is False
 
-    def test_view_yaml_format(self):
+    def test_view_yaml_format(self) -> None:
         """Test viewing configuration in YAML format."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -174,7 +174,7 @@ def test_view_yaml_format(self):
             assert data["defaults"]["max_cyclomatic_complexity"] == 10
             assert data["languages"][0]["name"] == "python"
 
-    def test_view_table_format(self):
+    def test_view_table_format(self) -> None:
         """Test viewing configuration in table format."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -222,7 +222,7 @@ def test_view_table_format(self):
             assert "║" in result.output
             assert "╚" in result.output
 
-    def test_view_no_languages_config(self):
+    def test_view_no_languages_config(self) -> None:
         """Test viewing configuration with no languages configured."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -244,7 +244,7 @@ def test_view_no_languages_config(self):
             assert "No languages configured" in result.output
             assert "Using .gitignore: No" in result.output
 
-    def test_view_many_ignore_patterns(self):
+    def test_view_many_ignore_patterns(self) -> None:
         """Test viewing configuration with many ignore patterns."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -276,7 +276,7 @@ def test_view_many_ignore_patterns(self):
             assert "pattern_0" in result.output
             assert "... and 5 more" in result.output
 
-    def test_view_no_validate_flag(self):
+    def test_view_no_validate_flag(self) -> None:
         """Test viewing configuration with --no-validate flag."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -297,7 +297,7 @@ def test_view_no_validate_flag(self):
             # But no validation errors shown with --no-validate
             assert "Configuration has validation errors" not in result.output
 
-    def test_view_default_config_file(self):
+    def test_view_default_config_file(self) -> None:
         """Test that view defaults to .antipasta.yaml."""
         runner = CliRunner()
         with runner.isolated_filesystem():

tests/unit/cli/test_generate_config.py

@@ -13,7 +13,7 @@
 class TestGenerateConfigCommand:
     """Test the generate-config command."""
 
-    def test_non_interactive_generates_default_config(self):
+    def test_non_interactive_generates_default_config(self) -> None:
         """Test that non-interactive mode generates a valid default config."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -33,7 +33,7 @@ def test_non_interactive_generates_default_config(self):
             assert len(config.languages) == 1
             assert config.languages[0].name == "python"
 
-    def test_non_interactive_overwrites_existing_file(self):
+    def test_non_interactive_overwrites_existing_file(self) -> None:
         """Test that non-interactive mode overwrites existing files without prompting."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -50,7 +50,7 @@ def test_non_interactive_overwrites_existing_file(self):
             assert "existing content" not in content
             assert "# antipasta configuration file" in content
 
-    def test_interactive_mode_with_defaults(self):
+    def test_interactive_mode_with_defaults(self) -> None:
         """Test interactive mode accepting all defaults."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -81,7 +81,7 @@ def test_interactive_mode_with_defaults(self):
             assert config.defaults.max_cyclomatic_complexity == 10
             assert config.defaults.max_cognitive_complexity == 15
 
-    def test_interactive_mode_with_custom_values(self):
+    def test_interactive_mode_with_custom_values(self) -> None:
         """Test interactive mode with custom threshold values."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -124,7 +124,7 @@ def test_interactive_mode_with_custom_values(self):
             assert "*.pyc" in config.ignore_patterns
             assert "__pycache__" in config.ignore_patterns
 
-    def test_interactive_mode_file_exists_abort(self):
+    def test_interactive_mode_file_exists_abort(self) -> None:
         """Test that interactive mode aborts when user declines to overwrite."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -156,7 +156,7 @@ def test_interactive_mode_file_exists_abort(self):
             content = output_file.read_text()
             assert content == "existing content\n"
 
-    def test_interactive_mode_file_exists_overwrite(self):
+    def test_interactive_mode_file_exists_overwrite(self) -> None:
         """Test that interactive mode overwrites when user confirms."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -188,7 +188,7 @@ def test_interactive_mode_file_exists_overwrite(self):
             assert "old content" not in content
             assert "# antipasta configuration file" in content
 
-    def test_default_output_path(self):
+    def test_default_output_path(self) -> None:
         """Test that default output path is .antipasta.yaml."""
         runner = CliRunner()
         with runner.isolated_filesystem():
@@ -198,7 +198,7 @@ def test_default_output_path(self):
             assert Path(".antipasta.yaml").exists()
             assert "✅ Configuration saved to .antipasta.yaml" in result.output
 
-    def test_generated_config_has_helpful_comments(self):
+    def test_generated_config_has_helpful_comments(self) -> None:
         """Test that generated config includes helpful comments."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -217,7 +217,7 @@ def test_generated_config_has_helpful_comments(self):
             assert "# Files and patterns to ignore during analysis" in content
             assert "# Whether to use .gitignore file for excluding files" in content
 
-    def test_javascript_coming_soon_message(self):
+    def test_javascript_coming_soon_message(self) -> None:
         """Test that JavaScript/TypeScript shows 'coming soon' message."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -248,7 +248,7 @@ def test_javascript_coming_soon_message(self):
             assert len(config.languages) == 1
             assert config.languages[0].name == "python"
 
-    def test_permission_error_handling(self):
+    def test_permission_error_handling(self) -> None:
         """Test that permission errors are handled gracefully."""
         runner = CliRunner()
         with patch("builtins.open", side_effect=PermissionError("Permission denied")):
@@ -259,7 +259,7 @@ def test_permission_error_handling(self):
             assert result.exit_code == 1
             assert "❌ Error saving configuration: Permission denied" in result.output
 
-    def test_interactive_mode_invalid_values_reprompt(self):
+    def test_interactive_mode_invalid_values_reprompt(self) -> None:
         """Test that invalid values trigger re-prompt."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -289,7 +289,7 @@ def test_interactive_mode_invalid_values_reprompt(self):
             assert result.exit_code == 0
             assert output_file.exists()
 
-    def test_shows_metric_ranges_in_prompts(self):
+    def test_shows_metric_ranges_in_prompts(self) -> None:
         """Test that metric prompts show valid ranges."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir:
@@ -317,7 +317,7 @@ def test_shows_metric_ranges_in_prompts(self):
             assert "Range: 1-100" in result.output  # Cognitive
             assert "Range: 0-100" in result.output  # Maintainability
 
-    def test_advanced_metrics_validation(self):
+    def test_advanced_metrics_validation(self) -> None:
         """Test validation of advanced Halstead metrics."""
         runner = CliRunner()
         with tempfile.TemporaryDirectory() as tmpdir: