Add class member visibility as ESLint warning

Also remove unnecessary rules from config.

Author: happy5214

eslint.config.mjs

@@ -12,7 +12,7 @@ export default defineConfig([
   globalIgnores(['src/data/*'], 'Ignore Source Data Directory'),
 
   {
-    files: ['**/*.js', '**/*.mjs'],
+    files: ['**/*.js', '**/*.mjs', '**/*.cjs'],
     plugins: {
       js,
     },
@@ -27,7 +27,6 @@ export default defineConfig([
       },
 
       ecmaVersion: 'latest',
-      sourceType: 'module',
     },
 
     rules: {
@@ -38,20 +37,16 @@ export default defineConfig([
         },
       ],
 
-      'linebreak-style': ['error', 'unix'],
       'guard-for-in': 'error',
-      'max-len': 'off',
       'no-var': 'error',
       'prefer-const': 'error',
       'array-callback-return': 'error',
-      'no-constant-binary-expression': 'error',
       'no-constructor-return': 'error',
       'no-duplicate-imports': 'error',
       'no-self-compare': 'error',
       'no-template-curly-in-string': 'warn',
       'no-unmodified-loop-condition': 'warn',
       'no-unreachable-loop': 'error',
-      'no-unused-private-class-members': 'error',
 
       'prefer-arrow-callback': [
         'error',
@@ -62,54 +57,16 @@ export default defineConfig([
     },
   },
   {
-    files: ['**/*.cjs'],
-    plugins: {
-      js,
+    files: ['**/*.js', '**/*.mjs'],
+    languageOptions: {
+      sourceType: 'module',
     },
-
-    extends: ['js/recommended'],
-
+  },
+  {
+    files: ['**/*.cjs'],
     languageOptions: {
-      globals: {
-        ...globals.node,
-        ...globals.jest,
-        __VITE_ENV__: 'readonly',
-      },
-
-      ecmaVersion: 'latest',
       sourceType: 'commonjs',
     },
-
-    rules: {
-      'no-console': [
-        'error',
-        {
-          allow: ['warn'],
-        },
-      ],
-
-      'linebreak-style': ['error', 'unix'],
-      'guard-for-in': 'error',
-      'max-len': 'off',
-      'no-var': 'error',
-      'prefer-const': 'error',
-      'array-callback-return': 'error',
-      'no-constant-binary-expression': 'error',
-      'no-constructor-return': 'error',
-      'no-duplicate-imports': 'error',
-      'no-self-compare': 'error',
-      'no-template-curly-in-string': 'warn',
-      'no-unmodified-loop-condition': 'warn',
-      'no-unreachable-loop': 'error',
-      'no-unused-private-class-members': 'error',
-
-      'prefer-arrow-callback': [
-        'error',
-        {
-          allowUnboundThis: false,
-        },
-      ],
-    },
   },
   {
     files: ['**/*.ts'],
@@ -133,21 +90,18 @@ export default defineConfig([
         },
       ],
 
-      'linebreak-style': ['error', 'unix'],
       'guard-for-in': 'error',
-      'max-len': 'off',
       'no-var': 'error',
       'prefer-const': 'error',
       'array-callback-return': 'error',
-      'no-constant-binary-expression': 'error',
       'no-constructor-return': 'error',
       'no-duplicate-imports': 'error',
       'no-self-compare': 'error',
       'no-template-curly-in-string': 'warn',
       'no-unmodified-loop-condition': 'warn',
       'no-unreachable-loop': 'error',
-      'no-unused-private-class-members': 'error',
       '@typescript-eslint/require-await': 'off',
+      '@typescript-eslint/explicit-member-accessibility': 'warn',
 
       'prefer-arrow-callback': [
         'error',

src/schema/loader.ts

@@ -18,7 +18,7 @@ export default class HedSchemaLoader extends AbstractHedSchemaLoader {
    * @returns The schema XML data.
    * @throws {IssueError} If the schema could not be loaded.
    */
-  override async loadLocalSchema(path: string): Promise<HedSchemaXMLObject> {
+  protected override async loadLocalSchema(path: string): Promise<HedSchemaXMLObject> {
     return this.loadSchemaFile(files.readFile(path), 'localSchemaLoadFailed', { path })
   }
 
@@ -28,7 +28,7 @@ export default class HedSchemaLoader extends AbstractHedSchemaLoader {
    * @param schemaDef - The description of which schema to use.
    * @returns Whether this validator bundles a particular schema.
    */
-  override hasBundledSchema(schemaDef: SchemaSpec): boolean {
+  protected override hasBundledSchema(schemaDef: SchemaSpec): boolean {
     return localSchemaMap.has(schemaDef.localName)
   }
 
@@ -38,7 +38,7 @@ export default class HedSchemaLoader extends AbstractHedSchemaLoader {
    * @param schemaDef - The description of which schema to use.
    * @returns The raw schema XML data.
    */
-  override async getBundledSchema(schemaDef: SchemaSpec): Promise<string> {
+  protected override async getBundledSchema(schemaDef: SchemaSpec): Promise<string> {
     const schemaXml = localSchemaMap.get(schemaDef.localName)
     if (!schemaXml) {
       IssueError.generateAndThrowInternalError('Bundled schema could not be found')

src/schema/parser.ts

@@ -84,7 +84,7 @@ export default class SchemaParser {
    *
    * @param rootElement - The root XML element.
    */
-  constructor(rootElement: HedSchemaRootElement) {
+  public constructor(rootElement: HedSchemaRootElement) {
     this.rootElement = rootElement
     this._versionDefinitions = {
       typeProperties: new Set(['boolProperty']),