Merge pull request #35 from hed-standard/explicit-override

Add explicit override tags

Author: happy5214

src/bids/types/json.ts

@@ -121,7 +121,7 @@ export class BidsSidecar extends BidsJsonFile {
    *
    * @returns {boolean}
    */
-  public get hasHedData(): boolean {
+  public override get hasHedData(): boolean {
     return this.sidecarKeys.size > 0
   }
 

src/bids/types/tsv.ts

@@ -94,7 +94,7 @@ export class BidsTsvFile extends BidsFile {
    *
    * @returns Whether this file has any HED data.
    */
-  public get hasHedData(): boolean {
+  public override get hasHedData(): boolean {
     return this.parsedTsv.has('HED') || this.mergedSidecar.hasHedData
   }
 

src/parser/parsedHedGroup.ts

@@ -207,7 +207,7 @@ export default class ParsedHedGroup extends ParsedHedSubstring {
    *
    * @returns The original string for this group.
    */
-  public toString(): string {
+  public override toString(): string {
     return this.originalTag
   }
 

src/parser/parsedHedTag.ts

@@ -225,7 +225,7 @@ export default class ParsedHedTag extends ParsedHedSubstring {
    *
    * @returns The original form of this HED tag.
    */
-  public toString(): string {
+  public override toString(): string {
     if (this.schema?.prefix) {
       return this.schema.prefix + ':' + this.originalTag
     } else {

src/schema/entries.ts

@@ -279,7 +279,7 @@ export class SchemaEntryWithAttributes extends SchemaEntry {
    * @param attributeName - The attribute to check for.
    * @returns Whether this schema entry has this attribute.
    */
-  public hasBooleanAttribute(attributeName: string): boolean {
+  public override hasBooleanAttribute(attributeName: string): boolean {
     return this.booleanAttributeNames.has(attributeName)
   }
 
@@ -724,7 +724,7 @@ export class SchemaValueTag extends SchemaTag {
   /**
    * This tag's long name.
    */
-  public get longName(): string {
+  public override get longName(): string {
     const nameParts = this.ancestors.map((parentTag) => parentTag.name)
     nameParts.reverse()
     nameParts.push('#')
@@ -737,7 +737,7 @@ export class SchemaValueTag extends SchemaTag {
    * @param extension - The extension.
    * @returns The extended short string.
    */
-  public extend(extension: string): string {
+  public override extend(extension: string): string {
     return this.parent.extend(extension)
   }
 
@@ -747,7 +747,7 @@ export class SchemaValueTag extends SchemaTag {
    * @param extension - The extension.
    * @returns The extended long string.
    */
-  public longExtend(extension: string): string {
+  public override longExtend(extension: string): string {
     return this.parent.longExtend(extension)
   }
 }

tsconfig.json

@@ -5,18 +5,15 @@
     "checkJs": false,
     "target": "esnext",
     "module": "esnext",
-    "moduleResolution": "node",
+    "resolveJsonModule": true,
     "skipLibCheck": true,
-    "esModuleInterop": true,
-    "allowSyntheticDefaultImports": true,
-    "downlevelIteration": true,
-    "typeRoots": ["./node_modules/@types"],
+    "types": ["node"],
     "strict": true,
     "strictNullChecks": false,
     "strictFunctionTypes": false,
     "strictPropertyInitialization": false,
     "exactOptionalPropertyTypes": false,
-    "resolveJsonModule": true
+    "noImplicitOverride": true
   },
   "include": ["index.ts", "src/**/*"],
   "exclude": ["node_modules", "dist"]