[Bug] Double-Quote Replacement Issue For Custom Revsets

[emadpres]

I found a weird issue with the text input for custom revsets:

If you start typing right after a " character, the double-quote char is replaced with ” (Right Double-Quote, Unicode U+201D). Since the replaced character is invalid the resulting revsets is invalid, GG doesn't register the revsets.

In fact, since GG doesn't provide any feedback on invalid inputs, you can't tell if the updated revsets is correct and resulted in the very same log chart, or it's actually an invalid input)

Before Typing:

As soon as I add g char right after " char:

(It's so subtle that at first I didn't realize it and I was pulling my hair why sometime typing custom revsets breaks everything)

---

Version: GG 0.35.1
OS: MacOS 26.2

[gulbanana]

oh dear. i think this is the OS or WebKit interfering with text inputs in order to be helpful... I'll look for a way to turn it off. and a way to provide better feedback! it is indeed annoying when you get a revset wrong and nothing happens.

[joyously]

This is a common problem with quotes and slashes when you use HTML tools to display the input. You have to make sure the escape/unescape functions are bidirectional, with no smart quotes or backslashes output but those are changed to straight quotes and slashes, because the input becomes output and then input again. Be sure to test a Windows path.

[gulbanana]

Converted to issue #111.