Skip to content

Commit d8c6cc5

Browse files
committed
Simplify Shinobu cog init
1 parent ca9c564 commit d8c6cc5

3 files changed

Lines changed: 5 additions & 18 deletions

File tree

shinobu/runtime/models/shinobu_cog.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,21 +27,12 @@ def visible_in_help(self) -> bool:
2727
return self._visible_in_help
2828

2929
class ShinobuCog(commands.Cog):
30-
def __init__(self, bot):
30+
def __init__(self, bot, shinobu_metadata: ShinobuCogMetadata | None = None):
3131
self.bot: bridge.Bot = bot
32-
self._shinobu_metadata: ShinobuCogMetadata | None = None
32+
self._shinobu_metadata: ShinobuCogMetadata | None = shinobu_metadata
3333
self._shinobu_secrets: fine_grained.FineGrainedSecrets | None = None
3434
self._shinobu_files: fine_grained.FineGrainedSecureFiles | None = None
3535

36-
def setup_shinobu_cog(self, bot, **kwargs):
37-
self.bot = bot
38-
self._shinobu_secrets: fine_grained.FineGrainedSecrets | None = None
39-
self._shinobu_files: fine_grained.FineGrainedSecureFiles | None = None
40-
41-
# Get secure files wrapper if it exists
42-
if "files_wrapper" in kwargs:
43-
self._shinobu_files = kwargs.get("files_wrapper")
44-
4536
def issue_entitlements(self, secrets: fine_grained.FineGrainedSecrets | None = None,
4637
files: fine_grained.FineGrainedSecureFiles | None = None):
4738
"""Issues entitlements to a Shinobu cog."""

shinobu/runtime/modules/admin.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,9 @@ def is_owner(ctx):
1919
return ctx.message.author.id == 356456393491873795
2020

2121
class Admin(shinobu_cog.ShinobuCog):
22-
def __init__(self, bot, **kwargs):
23-
# Register cog metadata
24-
self.setup_shinobu_cog(
22+
def __init__(self, bot):
23+
super().__init__(
2524
bot,
26-
**kwargs,
2725
shinobu_metadata=shinobu_cog.ShinobuCogMetadata(
2826
name="Admin",
2927
description="Admin commands",

shinobu/runtime/modules/events.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,8 @@
44

55
class ShinobuEvents(shinobu_cog.ShinobuCog):
66
def __init__(self, bot, **kwargs):
7-
# Register cog metadata
8-
self.setup_shinobu_cog(
7+
super().__init__(
98
bot,
10-
**kwargs,
119
shinobu_metadata=shinobu_cog.ShinobuCogMetadata(
1210
name="Events",
1311
description="A cog handling Shinobu bot events.",

0 commit comments

Comments
 (0)