Skip to content

Ability to distinguish between performance marks and measures #214

@nolanlawson

Description

@nolanlawson

First off, thanks for maintaining Tachometer! It's a really awesome tool.

This is just a minor issue. Sometimes I like to use this pattern:

performance.mark('foo')
// do something
performance.measure('foo', 'foo')

Unfortunately, if I do this, then I can't use the following in my tachometer.json:

{
  "measurement": [
    {
      "mode": "performance",
      "entryName": "foo"
    }
  ]
}

The reason is that Tachometer doesn't know whether I'm talking about the foo mark or measure. So as soon as it sees the mark, it uses that, rather than waiting for the measure.

Something like this would be great:

{
  "measurement": [
    {
      "mode": "performance",
      "entryName": "foo",
      "entryType": "measure"
    }
  ]
}

In the meantime, the workaround is to use a different name for the mark and the measure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions