Notes on implementation:

Currently we reproduce the crash as part of the patching workflow here:

syzkaller/pkg/aflow/flow/patching/patching.go

Line 45 in 8ee77f7

crash.Reproduce,

Reproduce action produces bug title and full oops report:

syzkaller/pkg/aflow/action/crash/reproduce.go

Lines 46 to 49 in 8ee77f7

    
           type reproduceResult struct { 
        
           	ReproducedBugTitle    string 
        
           	ReproducedCrashReport string 
        
           }

The oops report is then injected into the prompt here:

syzkaller/pkg/aflow/flow/patching/patching.go

Line 123 in 8ee77f7

Full kernel console output should be available here:

syzkaller/pkg/aflow/action/crash/reproduce.go

Lines 106 to 119 in 8ee77f7

    
           if err := results[0].Error; err != nil { 
        
           	if crashErr := new(instance.CrashError); errors.As(err, &crashErr) { 
        
           		res.Report = crashErr.Report 
        
           	} else if testErr := new(instance.TestError); errors.As(err, &testErr) { 
        
           		if testErr.Infra { 
        
           			// No point in showing this to LLM and asking to fix. 
        
           			return res, fmt.Errorf("%v\n%v\n%s", 
        
           				testErr.Error(), testErr.Title, testErr.Output) 
        
           		} 
        
           		res.BootError = parseTestError(testErr) 
        
           	} else { 
        
           		res.BootError = err.Error() 
        
           	} 
        
           }

We should extract fault injection reports from the log and return as part of Reproduce results, then it can be used in subsequent prompts.

	type reproduceResult struct {
	ReproducedBugTitle string
	ReproducedCrashReport string
	}

	if err := results[0].Error; err != nil {
	if crashErr := new(instance.CrashError); errors.As(err, &crashErr) {
	res.Report = crashErr.Report
	} else if testErr := new(instance.TestError); errors.As(err, &testErr) {
	if testErr.Infra {
	// No point in showing this to LLM and asking to fix.
	return res, fmt.Errorf("%v\n%v\n%s",
	testErr.Error(), testErr.Title, testErr.Output)
	}
	res.BootError = parseTestError(testErr)
	} else {
	res.BootError = err.Error()
	}
	}

pkg/aflow/flow/patching: pass fault injection info to LLM #6762

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions