[bazel] Regenerate RBE toolchain configs

Add rbe_configs_gen to WORKSPACE.  This is needed to support
dependencies which require a newer C++ standard.

Bug: b/432211966
Change-Id: I5e8bd98d8c3cb6bf42052c592ca525d45fd49aa2
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/1026537
Reviewed-by: Kaylee Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>

Author: erock2112

BUILD.bazel

@@ -299,3 +299,12 @@ alias(
     actual = "//sk/go/sk",
     visibility = ["//visibility:public"],
 )
+
+################################################
+# rbe_configs_gen  #
+################################################
+alias(
+    name = "rbe_configs_gen",
+    actual = "@rbe_configs_gen_linux_amd64//file:rbe_configs_gen",
+    visibility = ["//visibility:public"],
+)

WORKSPACE

@@ -631,6 +631,22 @@ load("//bazel/external:google_chrome.bzl", "google_chrome")
 
 google_chrome(name = "google_chrome")
 
+################################################
+# bazel-toolchains rbe_configs_gen (prebuilt). #
+################################################
+
+http_file(
+    name = "rbe_configs_gen_linux_amd64",
+    downloaded_file_path = "rbe_configs_gen",
+    executable = True,
+    sha256 = "1206e8a79b41cb22524f73afa4f4ee648478f46ef6990d78e7cc953665a1db89",
+    urls = gcs_mirror_url(
+        ext = "",
+        sha256 = "1206e8a79b41cb22524f73afa4f4ee648478f46ef6990d78e7cc953665a1db89",
+        url = "https://github.com/bazelbuild/bazel-toolchains/releases/download/v5.1.2/rbe_configs_gen_linux_amd64",
+    ),
+)
+
 ##########################
 # Buildifier (prebuilt). #
 ##########################

bazel/rbe/generated/README.md

@@ -60,14 +60,13 @@ regenerating these files, just update the `container-image` exec_property of the
 in `//bazel/rbe/generated/config/BUILD`
 ([example](https://skia.googlesource.com/buildbot/+/bb3604fd9a57bb20d799341b50f616af9e0062d4/bazel/rbe/generated/config/BUILD#43)).
 
-Regenerate the `//bazel/rbe/generated` directory with the `rbe_configs_gen` CLI tool (installation
-instructions below):
+Regenerate the `//bazel/rbe/generated` directory with the `rbe_configs_gen` CLI tool:
 
 ```
 # Replace the <PLACEHOLDERS> as needed.
-$ rbe_configs_gen \
+$ bazelisk run //:rbe_configs_gen \
       --bazel_version=<BAZEL VERSION> \
-      --toolchain_container=gcr.io/skia-public/rbe-container-skia-infra@sha256:<HASH OF MOST RECENT IMAGE> \
+      --toolchain_container=gcr.io/skia-public/infra-rbe-linux@sha256:<HASH OF MOST RECENT IMAGE> \
       --output_src_root=<PATH TO REPOSITORY CHECKOUT> \
       --output_config_path=bazel/rbe/generated \
       --exec_os=linux \
@@ -78,10 +77,10 @@ $ rbe_configs_gen \
 Example:
 
 ```
-$ rbe_configs_gen \
-      --bazel_version=4.1.0 \
-      --toolchain_container=gcr.io/skia-public/rbe-container-skia-infra@sha256:5418d876cd8bb7cdbd05b834254038744d15f2f38327dfa46ff8dc9f83355260 \
-      --output_src_root=$HOME/buildbot \
+$ bazelisk run //:rbe_configs_gen -- \
+      --bazel_version=$(cat .bazelversion) \
+      --toolchain_container=gcr.io/skia-public/infra-rbe-linux@sha256:0b12571d1befe54e9300711c8519535d635b867c317b2098915c7733fd65b833 \
+      --output_src_root=$(pwd) \
       --output_config_path=bazel/rbe/generated \
       --exec_os=linux \
       --target_os=linux \
@@ -111,17 +110,3 @@ Try running various bazel commands with `--config remote` to make use of the new
 
 When uploading the change as a CL, any tasks with the `-RBE` suffix will automatically use the
 image specified in `//bazel/rbe/generated/config/BUILD`.
-
-## How to install the `rbe_configs_gen` CLI tool
-
-Clone the [bazel-toolchains](https://github.com/bazelbuild/bazel-toolchains) repository outside of
-the Buildbot repository checkout, build the `rbe_configs_gen` binary, and place it on your $PATH:
-
-```
-$ git clone https://github.com/bazelbuild/bazel-toolchains
-
-$ cd bazel-toolchains
-
-# This assumes that $HOME/bin is in your $PATH.
-$ go build -o $HOME/bin/rbe_configs_gen ./cmd/rbe_configs_gen/rbe_configs_gen.go
-```

bazel/rbe/generated/cc/BUILD

@@ -113,7 +113,7 @@ cc_toolchain_config(
     "-ffunction-sections",
     "-fdata-sections"],
     dbg_compile_flags = ["-g"],
-    cxx_flags = ["-std=c++0x"],
+    cxx_flags = ["-std=c++14"],
     link_flags = ["-fuse-ld=/usr/bin/ld.gold",
     "-Wl,-no-as-needed",
     "-Wl,-z,relro,-z,now",

bazel/rbe/generated/cc/cc_toolchain_config.bzl

@@ -143,6 +143,34 @@ lto_index_actions = [
     ACTION_NAMES.lto_index_for_nodeps_dynamic_library,
 ]
 
+def _sanitizer_feature(name = "", specific_compile_flags = [], specific_link_flags = []):
+    return feature(
+        name = name,
+        flag_sets = [
+            flag_set(
+                actions = all_compile_actions,
+                flag_groups = [
+                    flag_group(flags = [
+                        "-fno-omit-frame-pointer",
+                        "-fno-sanitize-recover=all",
+                    ] + specific_compile_flags),
+                ],
+                with_features = [
+                    with_feature_set(features = [name]),
+                ],
+            ),
+            flag_set(
+                actions = all_link_actions,
+                flag_groups = [
+                    flag_group(flags = specific_link_flags),
+                ],
+                with_features = [
+                    with_feature_set(features = [name]),
+                ],
+            ),
+        ],
+    )
+
 def _impl(ctx):
     tool_paths = [
         tool_path(name = name, path = path)
@@ -783,6 +811,24 @@ def _impl(ctx):
         ],
     )
 
+    is_linux = ctx.attr.target_libc != "macosx"
+    if is_linux:
+        versioned_library_flag_group = flag_group(
+            flags = ["-l:%{libraries_to_link.name}"],
+            expand_if_equal = variable_with_value(
+                name = "libraries_to_link.type",
+                value = "versioned_dynamic_library",
+            ),
+        )
+    else:
+        versioned_library_flag_group = flag_group(
+            flags = ["%{libraries_to_link.path}"],
+            expand_if_equal = variable_with_value(
+                name = "libraries_to_link.type",
+                value = "versioned_dynamic_library",
+            ),
+        )
+
     libraries_to_link_feature = feature(
         name = "libraries_to_link",
         flag_sets = [
@@ -840,13 +886,7 @@ def _impl(ctx):
                                     value = "dynamic_library",
                                 ),
                             ),
-                            flag_group(
-                                flags = ["-l:%{libraries_to_link.name}"],
-                                expand_if_equal = variable_with_value(
-                                    name = "libraries_to_link.type",
-                                    value = "versioned_dynamic_library",
-                                ),
-                            ),
+                            versioned_library_flag_group,
                             flag_group(
                                 flags = ["-Wl,-no-whole-archive"],
                                 expand_if_true = "libraries_to_link.is_whole_archive",
@@ -1224,7 +1264,37 @@ def _impl(ctx):
         enabled = True,
     )
 
-    is_linux = ctx.attr.target_libc != "macosx"
+    asan_feature = _sanitizer_feature(
+        name = "asan",
+        specific_compile_flags = [
+            "-fsanitize=address",
+            "-fno-common",
+        ],
+        specific_link_flags = [
+            "-fsanitize=address",
+        ],
+    )
+
+    tsan_feature = _sanitizer_feature(
+        name = "tsan",
+        specific_compile_flags = [
+            "-fsanitize=thread",
+        ],
+        specific_link_flags = [
+            "-fsanitize=thread",
+        ],
+    )
+
+    ubsan_feature = _sanitizer_feature(
+        name = "ubsan",
+        specific_compile_flags = [
+            "-fsanitize=undefined",
+        ],
+        specific_link_flags = [
+            "-fsanitize=undefined",
+        ],
+    )
+
     libtool_feature = feature(
         name = "libtool",
         enabled = not is_linux,
@@ -1265,6 +1335,9 @@ def _impl(ctx):
             strip_debug_symbols_feature,
             coverage_feature,
             supports_pic_feature,
+            asan_feature,
+            tsan_feature,
+            ubsan_feature,
         ] + (
             [
                 supports_start_end_lib_feature,
@@ -1300,6 +1373,9 @@ def _impl(ctx):
             libtool_feature,
             archiver_flags_feature,
             supports_pic_feature,
+            asan_feature,
+            tsan_feature,
+            ubsan_feature,
         ] + (
             [
                 supports_start_end_lib_feature,