Skip to content

Commit 172704c

Browse files
SeawardTskcq-be@skia-corp.google.com.iam.gserviceaccount.com
authored andcommitted
Perf: Fall back to reporting if bisection fails
Recently, a change (b134f59) was introduced to fail the bisect workflow if Chromeperf fails to create a job, which prevents confusing "success" statuses when no job was actually created. However, this also inadvertently stopped bugs from being filed because the workflow failed completely instead of falling back to reporting. This change catches the bisection failure and falls back to processAnomaliesAsReporting so that users are still notified of regressions. Bug: b/502224585 goalie(skia/fix-bug-502224585) Change-Id: I20d5d17558775d9eb202a5aebc0549fcf4eac788 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/1209869 Reviewed-by: Maxim Sheshukov <[email protected]> Commit-Queue: Tony Seaward <[email protected]>
1 parent 0c424be commit 172704c

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

perf/go/workflows/internal/maybe_trigger_bisection.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,14 @@ func MaybeTriggerBisectionWorkflow(
7474
return nil, skerr.Wrap(err)
7575
}
7676
if bisectionAllowed {
77-
return processAnomaliesAsBisection(ctx, input)
78-
} else {
79-
// Fallback to reporting if the rate limiter prevents creating bisect jobs.
80-
return processAnomaliesAsReporting(ctx, input)
77+
res, err := processAnomaliesAsBisection(ctx, input)
78+
if err == nil {
79+
return res, nil
80+
}
81+
workflow.GetLogger(ctx).Error("Bisection failed, falling back to reporting.", "error", err)
8182
}
83+
// Fallback: bisection not allowed or failed.
84+
return processAnomaliesAsReporting(ctx, input)
8285
case ag_pb.GroupActionType_REPORT:
8386
return processAnomaliesAsReporting(ctx, input)
8487
case ag_pb.GroupActionType_NOACTION:

0 commit comments

Comments
 (0)