Skip to content

Commit 416e896

Browse files
authored
Update CHANGELOG, release 8.12.4. (#1389)
1 parent 4ffea12 commit 416e896

File tree

9 files changed

+20
-19
lines changed

9 files changed

+20
-19
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
# 8.12.4
4+
5+
- Reduce use of dynamic calls in generated `operator==` when there are
6+
functions: only use dynamic calls if the class also has type parameters.
7+
38
# 8.12.3
49

510
- Require `analyzer ^10.0.0`, stop using removed and deprecated methods from

benchmark/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: benchmark
2-
version: 8.12.3
2+
version: 8.12.4
33
publish_to: none
44
description: >
55
Benchmark, not for publishing.
@@ -14,7 +14,7 @@ dependencies:
1414

1515
dev_dependencies:
1616
build_runner: '>=1.0.0 <3.0.0'
17-
built_value_generator: ^8.12.3
17+
built_value_generator: ^8.12.4
1818
pedantic: ^1.4.0
1919
quiver: '>=0.21.0 <4.0.0'
2020
test: ^1.0.0

built_value/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: built_value
2-
version: 8.12.3
2+
version: 8.12.4
33
description: >
44
Value types with builders, Dart classes as enums, and serialization.
55
This library is the runtime dependency.

built_value_generator/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: built_value_generator
2-
version: 8.12.3
2+
version: 8.12.4
33
description: >
44
Value types with builders, Dart classes as enums, and serialization.
55
This library is the dev dependency.

built_value_generator/test/built_value_generator_test.dart

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -882,33 +882,29 @@ abstract class NestedValue implements Built<NestedValue, NestedValueBuilder> {
882882

883883
test('uses dynamic for equality check on function fields with generics',
884884
() async {
885-
expect(
886-
await generate('''library value;
885+
expect(await generate('''library value;
887886
import 'package:built_value/built_value.dart';
888887
part 'value.g.dart';
889888
abstract class Value<T> implements Built<Value<T>, ValueBuilder<T>> {
890889
Value._();
891890
factory Value([void Function(ValueBuilder<T>) updates]) = _\$Value<T>;
892891
void Function(T) get callback;
893892
}
894-
'''),
895-
contains(r'final dynamic _$dynamicOther = other;'));
893+
'''), contains(r'final dynamic _$dynamicOther = other;'));
896894
});
897895

898896
test(
899897
'does not use dynamic for equality check on function fields without generics',
900898
() async {
901-
expect(
902-
await generate('''library value;
899+
expect(await generate('''library value;
903900
import 'package:built_value/built_value.dart';
904901
part 'value.g.dart';
905902
abstract class Value implements Built<Value, ValueBuilder> {
906903
Value._();
907904
factory Value([void Function(ValueBuilder) updates]) = _\$Value;
908905
void Function(int) get callback;
909906
}
910-
'''),
911-
isNot(contains(r'dynamicOther')));
907+
'''), isNot(contains(r'dynamicOther')));
912908
});
913909

914910
test('cleans generated class names for private classes', () async {

built_value_test/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: built_value_test
2-
version: 8.12.3
2+
version: 8.12.4
33
description: >
44
Value types with builders, Dart classes as enums, and serialization.
55
This library provides test support.
@@ -21,7 +21,7 @@ dependencies:
2121
quiver: '>=0.21.0 <4.0.0'
2222

2323
dev_dependencies:
24-
built_value_generator: ^8.12.3
24+
built_value_generator: ^8.12.4
2525
build_runner: '>=1.0.0 <3.0.0'
2626
pedantic: ^1.4.0
2727
test: ^1.0.0

chat_example/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: chat_example
2-
version: 8.12.3
2+
version: 8.12.4
33
publish_to: none
44
description: >
55
Just an example, not for publishing.
@@ -21,6 +21,6 @@ dev_dependencies:
2121
build_runner: any
2222
build_test: any
2323
build_web_compilers: any
24-
built_value_generator: ^8.12.3
24+
built_value_generator: ^8.12.4
2525
pedantic: ^1.4.0
2626
test: ^1.0.0

end_to_end_test/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: end_to_end_test
2-
version: 8.12.3
2+
version: 8.12.4
33
publish_to: none
44
description: >
55
Tests, not for publishing.
@@ -15,7 +15,7 @@ dependencies:
1515
dev_dependencies:
1616
build: '>=3.1.0 <5.0.0'
1717
build_runner: '>=2.5.0 <3.0.0'
18-
built_value_generator: ^8.12.3
18+
built_value_generator: ^8.12.4
1919
fixnum: ^1.0.0
2020
pedantic: ^1.4.0
2121
quiver: '>=0.21.0 <4.0.0'

example/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ dependencies:
1313

1414
dev_dependencies:
1515
build_runner: '>=1.0.0 <3.0.0'
16-
built_value_generator: ^8.12.3
16+
built_value_generator: ^8.12.4
1717
pedantic: ^1.4.0
1818
quiver: '>=0.21.0 <4.0.0'
1919
test: ^1.0.0

0 commit comments

Comments
 (0)