Skip to content

Commit 0b5e429

Browse files
committed
Resolve review comments
1 parent d00f038 commit 0b5e429

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

base/cvd/cuttlefish/host/libs/web/cas/cas_flags.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ class FlagValue {
3131
public:
3232
explicit FlagValue(const T& default_value) : default_value_(default_value) {}
3333

34-
// Return by value to avoid dangling references.
35-
T value() const { return value_.value_or(default_value_); }
34+
// Use ref-qualifier to avoid calling value() on a temporary.
35+
const T& value() const& { return value_ ? *value_ : default_value_; }
3636
void set_value(const T& value) { value_.emplace(value); }
3737
bool user_provided() const { return value_.has_value(); }
3838

0 commit comments

Comments
 (0)