Skip to content

Added cpack support#9

Merged
gistrec merged 2 commits intomasterfrom
clack-support
May 3, 2026
Merged

Added cpack support#9
gistrec merged 2 commits intomasterfrom
clack-support

Conversation

@MrHerrn
Copy link
Copy Markdown
Collaborator

@MrHerrn MrHerrn commented May 3, 2026

No description provided.

@MrHerrn MrHerrn requested a review from gistrec May 3, 2026 13:44
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.18%. Comparing base (2209670) to head (f0a7b8b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files          20       20           
  Lines         497      497           
  Branches       88       88           
=======================================
  Hits          488      488           
  Misses          1        1           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Owner

@gistrec gistrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order issue: include(CPack) snapshots all CPACK_* vars at include time and writes them to CPackConfig.cmake — which is what cpack actually reads. Setting CPACK_GENERATOR after include(CPack) doesn't make it into the config, so cpack falls back to the platform default (STGZ;TGZ on Linux, ZIP on Windows, TGZ on macOS). Silent — you only notice when someone gets the wrong format.

Swap the order:

set(CPACK_GENERATOR "ZIP")
include(CPack)

@gistrec gistrec merged commit 3c584b2 into master May 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants