Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 20 20
Lines 497 497
Branches 88 88
=======================================
Hits 488 488
Misses 1 1
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gistrec
requested changes
May 3, 2026
Owner
gistrec
left a comment
There was a problem hiding this comment.
Order issue: include(CPack) snapshots all CPACK_* vars at include time and writes them to CPackConfig.cmake — which is what cpack actually reads. Setting CPACK_GENERATOR after include(CPack) doesn't make it into the config, so cpack falls back to the platform default (STGZ;TGZ on Linux, ZIP on Windows, TGZ on macOS). Silent — you only notice when someone gets the wrong format.
Swap the order:
set(CPACK_GENERATOR "ZIP")
include(CPack)
gistrec
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.