fix disconnect typo in connection return tuple#267
Open
malcolmsgc wants to merge 4 commits into
Open
Conversation
Connections are now created eagerly during pool init instead of lazily on first checkout, eliminating cold-start timeouts. Defaults to 1 connection, clamped to max_concurrency when set. Also fixes the max_allowed_connections calculation to explicitly handle nil concurrency values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The server can send LogMessage notifications (e.g. "requested to stop; disconnecting now") during ping. Previously this crashed the connection because handle_ping_message had no LogMessage clause, causing a cascade: the disconnect callback tried to send Terminate on a closing socket, returned a non-:ok value, and DBConnection's :ok = apply() crashed with MatchError. Fix both issues: consume LogMessages during ping (matching the pattern used by receive_message elsewhere), and ensure all disconnect clauses explicitly return :ok as DBConnection requires. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typo in return tuple was causing clause match error.