[HELP] Did skia changed too much so that now the compiling procedure changed?

[pgilfernandez]

Hi @rodlie,

Did your recent skia changes made compiling procedura different?
I don't know if it is a coincidence or not, my submodule skia got "corrupted" so I ended up deleting it and now I'm unable to recompile it...
I'm stuck with GN:

pablo@MacBook-Pro-de-Pablo-2 build % cmake -G Ninja \
-DCMAKE_BUILD_TYPE=Release \
-DQSCINTILLA_INCLUDE_DIRS=/opt/local/libexec/qt5/include \
-DQSCINTILLA_LIBRARIES_DIRS=/opt/local/libexec/qt5/lib \
-DQSCINTILLA_LIBRARIES=qscintilla2_qt5 \
..
-- The C compiler identification is AppleClang 14.0.0.14000029
-- The CXX compiler identification is AppleClang 14.0.0.14000029
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Checking for module 'libavformat'
--   Found libavformat, version 58.76.100
-- Checking for module 'libavcodec'
--   Found libavcodec, version 58.134.100
-- Checking for module 'libavutil'
--   Found libavutil, version 56.70.100
-- Checking for module 'libswscale'
--   Found libswscale, version 5.9.100
-- Checking for module 'libswresample'
--   Found libswresample, version 3.9.100
-- ffmpeg include: /opt/local/include
-- ffmpeg libraries: /opt/local/lib avformat;avcodec;avutil;swscale;swresample
-- skia libraries: /Users/pablo/GitHub/friction/build/src/core/../skia skia;z
-- ffmpeg include: /opt/local/include
-- ffmpeg libraries: /opt/local/lib avformat;avcodec;avutil;swscale;swresample
-- skia libraries: /Users/pablo/GitHub/friction/build/src/ui/../skia skia;z
-- qscintilla include: /opt/local/libexec/qt5/include
-- qscintilla libraries: /opt/local/libexec/qt5/lib qscintilla2_qt5
-- Configuring done (3.4s)
-- Generating done (0.5s)
-- Build files have been written to: /Users/pablo/GitHub/friction/build
pablo@MacBook-Pro-de-Pablo-2 build % cmake --build . --config Release
[3/452] Performing update step for 'gn'
[5/452] Performing configure step for 'gn'
/usr/local/Cellar/[email protected]/3.13.2/Frameworks/Python.framework/Versions/3.13/Resources/Python.app/Contents/MacOS/Python: can't open file '/Users/pablo/GitHub/friction/src/skia/gn-src/build/gen.py': [Errno 2] No such file or directory
FAILED: src/skia/gn-prefix/src/gn-stamp/gn-configure /Users/pablo/GitHub/friction/build/src/skia/gn-prefix/src/gn-stamp/gn-configure 
cd /Users/pablo/GitHub/friction/build/src/skia/gn && /usr/local/bin/python3 /Users/pablo/GitHub/friction/src/skia/gn-src/build/gen.py --out-path /Users/pablo/GitHub/friction/build/src/skia/gn && /usr/local/bin/cmake -E touch /Users/pablo/GitHub/friction/build/src/skia/gn-prefix/src/gn-stamp/gn-configure
ninja: build stopped: subcommand failed.

Any idea?
Thanks

[rodlie]

Yes, the src/engine/skia submodule was replaced with src/skia

git submodule update -i --recursive

Should fix it.

[pgilfernandez]

Thanks man, it helped... I had some other issues with my Qt too but I'm back again able to fully compile Friction 😄

[rodlie]

Great 👍