example code passes incorrectly

[bswhite1]

The function, expectPermissionGetSucceeds, can pass when it shouldn't.

quickstart-testing/unit-test-security-rules-v9/test/utils.ts

Line 61 in 6ac0acf

export async function expectPermissionGetSucceeds(promise: Promise<any>) {

If your READ permissions return a PERMISSION_DENIED, then the getDoc promise will return the error code. however since this only expects that promise.not.toBeUndefined, then the error code meets that criteria.

I fixed locally by just adding the second check to make sure that the error code != PERMISSION_DENIED

export async function expectPermissionGetSucceeds(promise: Promise<any>) {
  const successResult = await assertSucceeds(promise);
  expect(successResult).not.toBeUndefined();
  expect(successResult.code).not.toBe('permission-denied' || 'PERMISSION_DENIED');
}