Merge pull request #2808 from fetchai/develop

release 1.2.3

Author: solarw

.github/workflows/workflow.yml

@@ -2,7 +2,7 @@
 ignore-patterns=__main__.py,.*_pb2.py,tac.sh,tac_local.sh
 
 [MESSAGES CONTROL]
-disable=C0103,C0201,C0301,C0302,W0105,W0707,W1202,W1203,R0801
+disable=C0103,C0201,C0301,C0302,W0105,W0707,W1202,W1203,R0801,C0209,R1735
 
 # See here for more options: https://www.codeac.io/documentation/pylint-configuration.html
 ## Eventually resolve these:
@@ -19,6 +19,8 @@ disable=C0103,C0201,C0301,C0302,W0105,W0707,W1202,W1203,R0801
 # C0302: http://pylint-messages.wikidot.com/messages:c0302 > Too many lines in module (%s) , # kept as no harm
 # W0105: pointless-string-statement, # kept as no harm
 # R0801: similar lines, # too granular
+# C0209: Formatting a regular string which could be a f-string (consider-using-f-string)  # to many usage atm
+# R1735: Consider using {} instead of dict() (use-dict-literal)
 
 [IMPORTS]
 ignored-modules=bech32,ecdsa,lru,eth_typing,eth_keys,eth_account,ipfshttpclient,werkzeug,openapi_spec_validator,aiohttp,multidict,yoti_python_sdk,defusedxml,gym,fetch,matplotlib,memory_profiler,numpy,oef,openapi_core,psutil,tensorflow,temper,skimage,web3,aioprometheus,pyaes,Crypto,asn1crypto,cosmpy,google

.pylintrc

@@ -1,7 +1,22 @@
 # Release History
 
 
-## 1.2.1 (2022-10-17)
+## 1.2.3(2022-11-03)
+
+AEA:
+- core and development are dependencies updated.
+- ci improvements
+- cosmpy updated to 0.6.0
+- Small code format improvements and better linting
+
+Plugins:
+- Small code format improvements
+- cosmpy updated to 0.6.0
+
+Packages:
+- Small code format improvements
+
+## 1.2.2 (2022-10-17)
 
 AEA:
 - Dependency management switched from pipenv to poetry.

HISTORY.md

@@ -22,7 +22,7 @@
 __title__ = "aea"
 __description__ = "Autonomous Economic Agent framework"
 __url__ = "https://github.com/fetchai/agents-aea.git"
-__version__ = "1.2.2"
+__version__ = "1.2.3"
 __author__ = "Fetch.AI Limited"
 __license__ = "Apache-2.0"
 __copyright__ = "2022 Fetch.AI Limited"

aea/__version__.py

@@ -18,7 +18,7 @@
 # ------------------------------------------------------------------------------
 """This module contains the interface definition of the abstract agent."""
 import datetime
-from abc import ABC, abstractmethod, abstractproperty
+from abc import ABC, abstractmethod
 from typing import Any, Callable, Dict, List, Optional, Tuple
 
 from aea.mail.base import Envelope
@@ -27,11 +27,13 @@
 class AbstractAgent(ABC):
     """This class provides an abstract base  interface for an agent."""
 
-    @abstractproperty
+    @property
+    @abstractmethod
     def name(self) -> str:
         """Get agent's name."""
 
-    @abstractproperty
+    @property
+    @abstractmethod
     def storage_uri(self) -> Optional[str]:
         """Return storage uri."""
 

aea/abstract_agent.py

@@ -415,7 +415,11 @@ def _reset(self, is_full_reset: bool = False) -> None:
 
     def _remove_components_from_dependency_manager(self) -> None:
         """Remove components added via 'add_component' from the dependency manager."""
-        for component_type in self._component_instances.keys():
+        for (
+            component_type
+        ) in (
+            self._component_instances.keys()
+        ):  # pylint: disable=consider-using-dict-items
             for component_config in self._component_instances[component_type].keys():
                 self._package_dependency_manager.remove_component(
                     component_config.component_id

aea/aea_builder.py

@@ -215,7 +215,7 @@ def start(self) -> None:
 
         if was_started:
             self.runtime.wait_completed(sync=True)
-        else:  #  pragma: nocover
+        else:  # pragma: nocover
             raise AEAException("Failed to start runtime! Was it already started?")
 
     def handle_envelope(self, envelope: Envelope) -> None:

aea/agent.py

@@ -110,12 +110,12 @@ def set_loop(self, loop: AbstractEventLoop) -> None:
         """Set event loop and all event loop related objects."""
         self._loop: AbstractEventLoop = loop
 
-    def _setup(self) -> None:  # pylint: disable=no-self-use
+    def _setup(self) -> None:
         """Set up agent loop before started."""
         # start and stop methods are classmethods cause one instance shared across multiple threads
         ExecTimeoutThreadGuard.start()
 
-    def _teardown(self) -> None:  # pylint: disable=no-self-use
+    def _teardown(self) -> None:
         """Tear down loop on stop."""
         # start and stop methods are classmethods cause one instance shared across multiple threads
         ExecTimeoutThreadGuard.stop()
@@ -295,10 +295,11 @@ def _execution_control(
                 if self.agent.exception_handler(e, fn) is True:
                     self._state.set(AgentLoopStates.error)
                     raise
-            except Exception as e:
+            except Exception as e2:
                 self._state.set(AgentLoopStates.error)
-                self._exceptions.append(e)
+                self._exceptions.append(e2)
                 raise
+        return None
 
     def _register_periodic_task(
         self,

aea/agent_loop.py

@@ -49,7 +49,7 @@ def get(ctx: Context, json_path: str) -> None:
         agent_config_manager = AgentConfigManager.load(ctx.cwd)
         value = agent_config_manager.get_variable(json_path)
     except (ValueError, AEAException) as e:
-        raise ClickException(*e.args)
+        raise ClickException(str(e.args[0]))
 
     if isinstance(value, dict):
         # turn it to json compatible string, not dict str representation
@@ -101,4 +101,4 @@ def set_command(
     except ExtraPropertiesError as e:  # pragma: nocover
         raise ClickException(f"Attribute `{e.args[0][0]}` is not allowed to change!")
     except (ValueError, AEAException) as e:
-        raise ClickException(*e.args)
+        raise ClickException(str(e.args[0]))

aea/cli/config.py

@@ -18,8 +18,8 @@
 # ------------------------------------------------------------------------------
 """Implementation of the 'aea fetch' subcommand."""
 import os
-from distutils.dir_util import copy_tree
 from pathlib import Path
+from shutil import copytree as copy_tree
 from typing import Optional, cast
 
 import click
@@ -169,7 +169,7 @@ def fetch_agent_locally(
         os.makedirs(target_path)  # pragma: nocover
 
     ctx.clean_paths.append(target_path)
-    copy_tree(source_path, target_path)
+    copy_tree(source_path, target_path, dirs_exist_ok=True)  # type: ignore
 
     ctx.cwd = target_path
     try_to_load_agent_config(ctx)