upgrade to nightly-2025-04-14

Summary:
As per the title - to review, the `rustfmt`-specific changes are isolated under `fbsource/tools/third-party/rustfmt` and the rest are codemodded

allow-large-files
ignore-conflict-markers

Reviewed By: capickett

Differential Revision: D73041643

fbshipit-source-id: 14092a58e4439d689ff7eea9cfbd9477071809e4

Author: diliop

below/below_derive/src/helper.rs

@@ -13,12 +13,12 @@
 // limitations under the License.
 
 use quote::ToTokens;
-use syn::parse::Parse;
-use syn::punctuated::Punctuated;
-use syn::spanned::Spanned;
 use syn::Attribute;
 use syn::Ident;
 use syn::Token;
+use syn::parse::Parse;
+use syn::punctuated::Punctuated;
+use syn::spanned::Spanned;
 
 /// Adapted from strum_macros
 pub fn get_metadata<'a, T: Parse + Spanned>(

below/below_derive/src/qenum.rs

@@ -25,9 +25,9 @@
 use proc_macro2::Span;
 use proc_macro2::TokenStream;
 use quote::quote;
-use syn::spanned::Spanned;
 use syn::DeriveInput;
 use syn::LitStr;
+use syn::spanned::Spanned;
 
 use crate::helper::to_snakecase;
 

below/below_derive/src/queriable.rs

@@ -15,13 +15,13 @@
 use proc_macro2::Span;
 use proc_macro2::TokenStream;
 use quote::quote;
-use syn::parse::Parse;
-use syn::parse::ParseStream;
-use syn::spanned::Spanned;
 use syn::DeriveInput;
 use syn::Field;
 use syn::Ident;
 use syn::Token;
+use syn::parse::Parse;
+use syn::parse::ParseStream;
+use syn::spanned::Spanned;
 
 use crate::helper::get_metadata;
 use crate::helper::occurrence_error;

below/btrfs/src/btrfs_api/sudotest.rs

@@ -19,19 +19,19 @@ use std::os::unix::fs::MetadataExt;
 use std::os::unix::io::AsRawFd;
 use std::path::Path;
 
-#[cfg(fbcode_build)]
-pub use btrfs::btrfs_api::*;
 #[cfg(fbcode_build)]
 use btrfs::BtrfsReader;
+#[cfg(fbcode_build)]
+pub use btrfs::btrfs_api::*;
 use common::logutil::get_logger;
-use nix::sys::statfs::fstatfs;
 use nix::sys::statfs::FsType;
+use nix::sys::statfs::fstatfs;
 use openat::Dir;
 
-#[cfg(not(fbcode_build))]
-pub use crate::btrfs_api::*;
 #[cfg(not(fbcode_build))]
 use crate::BtrfsReader;
+#[cfg(not(fbcode_build))]
+pub use crate::btrfs_api::*;
 
 // Currently, sudotests test basic functionality. Will testing infrastructure in later commits
 

below/cgroupfs/src/lib.rs

@@ -28,8 +28,8 @@ use std::path::Path;
 use std::path::PathBuf;
 use std::str::FromStr;
 
-use nix::sys::statfs::fstatfs;
 use nix::sys::statfs::CGROUP2_SUPER_MAGIC;
+use nix::sys::statfs::fstatfs;
 use openat::AsPath;
 use openat::Dir;
 use openat::SimpleType;

below/common/src/cliutil.rs

@@ -16,9 +16,9 @@ use std::time::Duration;
 use std::time::SystemTime;
 use std::time::UNIX_EPOCH;
 
+use anyhow::Result;
 use anyhow::anyhow;
 use anyhow::bail;
-use anyhow::Result;
 
 use crate::dateutil;
 use crate::util;

below/common/src/dateutil.rs

@@ -30,12 +30,12 @@ use std::sync::atomic::AtomicI32;
 use std::sync::atomic::Ordering;
 use std::time::SystemTime;
 
-use chrono::prelude::*;
 use chrono::Duration;
 use chrono::Local;
 use chrono::NaiveDateTime;
 use chrono::NaiveTime;
 use chrono::TimeZone;
+use chrono::prelude::*;
 use regex::Regex;
 
 /// A simple time structure that matches hg's time representation.

below/config/src/lib.rs

@@ -19,8 +19,8 @@ use std::path::Path;
 use std::path::PathBuf;
 use std::sync::OnceLock;
 
-use anyhow::bail;
 use anyhow::Result;
+use anyhow::bail;
 use serde::Deserialize;
 use serde::Serialize;
 

below/dump/src/command.rs

@@ -15,9 +15,9 @@
 use std::fmt::Display;
 use std::str::FromStr;
 
-use anyhow::bail;
 use anyhow::Error;
 use anyhow::Result;
+use anyhow::bail;
 use clap::Parser;
 use model::BtrfsModelFieldId;
 use model::FieldId;

below/dump/src/lib.rs

@@ -24,23 +24,23 @@ use std::str::FromStr;
 use std::sync::mpsc::Receiver;
 use std::time::SystemTime;
 
-use anyhow::bail;
 use anyhow::Context;
 use anyhow::Error;
 use anyhow::Result;
+use anyhow::bail;
 use common::cliutil;
 use common::util::get_belowrc_dump_section_key;
 use common::util::get_belowrc_filename;
 use common::util::timestamp_to_datetime;
 use model::Field;
 use model::FieldId;
 use model::Queriable;
-use serde_json::json;
 use serde_json::Value;
-use store::advance::new_advance_local;
-use store::advance::new_advance_remote;
+use serde_json::json;
 use store::Advance;
 use store::Direction;
+use store::advance::new_advance_local;
+use store::advance::new_advance_remote;
 use tar::Archive;
 use tempfile::TempDir;
 use toml::value::Value as TValue;
@@ -62,14 +62,14 @@ pub mod transport;
 #[cfg(test)]
 mod test;
 
-use command::expand_fields;
 pub use command::DumpCommand;
 use command::GeneralOpt;
 use command::OutputFormat;
+use command::expand_fields;
 use render::HasRenderConfigForDump;
-use tmain::dump_timeseries;
 use tmain::Dumper;
 use tmain::IterExecResult;
+use tmain::dump_timeseries;
 
 /// Fields available to all commands. Each enum represents some semantics and
 /// knows how to extract relevant data from a CommonFieldContext.