Fix Git Codex Review invocation

[mszeszko-meta]

Test.

[github-actions]

✅ clang-tidy: No findings on changed lines

Completed in 0.0s.

[github-actions]

Codex Code Review - OBSOLETE

Superseded by a newer AI review. Expand to see the original review.

🟡 Codex Code Review

Auto-triggered after CI reached the early-review threshold — reviewing commit b0fe00d

---

❌ Codex review failed before producing findings.

WARNING: proceeding, even though we could not update PATH: Refusing to create helper binaries under temporary dir "/tmp" (codex_home: AbsolutePathBuf("/tmp/codex-home"))
error: the argument '--base <BRANCH>' cannot be used with '[PROMPT]'

Usage: codex exec review --commit <SHA> --base <BRANCH> --title <TITLE> --model <MODEL> --config <key=value> --dangerously-bypass-approvals-and-sandbox --output-last-message <FILE> [PROMPT]

For more information, try '--help'.

---

ℹ️ About this response

Generated by Codex CLI.
Review methodology: claude_md/code_review.md

Limitations:

• Codex may miss context from files not in the diff
• Large PRs may be truncated
• Always apply human judgment to AI suggestions

Commands:

• /codex-review [context] — Request a code review
• /codex-query <question> — Ask about the PR or codebase

[github-actions]

Claude Code Review - OBSOLETE

Superseded by a newer AI review. Expand to see the original review.

✅ Claude Code Review

Auto-triggered after CI reached the early-review threshold — reviewing commit b0fe00d

---

Summary

Clean, low-risk CI fix. The PR removes the review subcommand and its --base/--title flags from two codex exec invocations in the GitHub Actions workflow, aligning them with all other Codex invocations in the same file which already use plain codex exec. The BASE_SHA and PR_TITLE env vars are also removed from the corresponding env: blocks since they are no longer referenced.

High-severity findings (0):
No high-severity findings.

Full review (click to expand)

Findings

🔴 HIGH

None.

🟡 MEDIUM

None.

🟢 LOW / NIT

L1. Consistency confirmed — ai-review-analysis.yml

• Observation: After this change, all codex exec invocations in the workflow are consistent — none use the review subcommand or --base/--title flags. The prompt text (which already includes PR title and diff via /tmp/prompt.txt) provides the necessary context to the model via stdin, making the CLI flags redundant.
• Status: No action needed. This is a positive observation.

L2. Unused env vars fully cleaned up

• Observation: BASE_SHA and PR_TITLE are removed from both env: blocks where they were only consumed by the now-removed --base and --title flags. Other steps that still use these variables (lines 446-447, 1015-1016) are unaffected. Cleanup is complete and correct.

Cross-Component Analysis

This change only affects the GitHub Actions CI workflow file. It does not touch any C++ source, headers, build files, or RocksDB logic. No cross-component concerns apply.

Context	Affected?	Notes
Automated PR review (Codex provider)	YES	Both auto-trigger and manual-trigger paths updated
Automated PR review (Claude provider)	NO	Claude paths use separate invocation
Query command path	NO	Already used codex exec without review
Recovery/partial review path	NO	Already used codex exec without review
Prompt construction	NO	/tmp/prompt.txt still contains title and diff

Positive Observations

• The change makes the two divergent invocations consistent with the five other codex exec calls in the same file.
• The PR title and base SHA information is already embedded in the prompt text piped via stdin (/tmp/prompt.txt), so removing the CLI flags does not lose any context.
• Clean removal of now-unused environment variables avoids confusion for future maintainers.

---

ℹ️ About this response

Generated by Claude Code.
Review methodology: claude_md/code_review.md

Limitations:

• Claude may miss context from files not in the diff
• Large PRs may be truncated
• Always apply human judgment to AI suggestions

Commands:

• /claude-review [context] — Request a code review
• /claude-query <question> — Ask about the PR or codebase

[github-actions]

🟡 Codex Code Review

Auto-triggered after CI passed — reviewing commit b0fe00d

---

❌ Codex review failed before producing findings.

WARNING: proceeding, even though we could not update PATH: Refusing to create helper binaries under temporary dir "/tmp" (codex_home: AbsolutePathBuf("/tmp/codex-home"))
error: the argument '--base <BRANCH>' cannot be used with '[PROMPT]'

Usage: codex exec review --commit <SHA> --base <BRANCH> --title <TITLE> --model <MODEL> --config <key=value> --dangerously-bypass-approvals-and-sandbox --output-last-message <FILE> [PROMPT]

For more information, try '--help'.

---

ℹ️ About this response

Generated by Codex CLI.
Review methodology: claude_md/code_review.md

Limitations:

• Codex may miss context from files not in the diff
• Large PRs may be truncated
• Always apply human judgment to AI suggestions

Commands:

• /codex-review [context] — Request a code review
• /codex-query <question> — Ask about the PR or codebase

[github-actions]

✅ Claude Code Review

Auto-triggered after CI passed — reviewing commit b0fe00d

---

Summary

Straightforward CI fix that changes the Codex CLI invocation from codex exec review --base ... --title ... to codex exec in two workflow jobs. This aligns the review invocation with the query and recovery code paths that already use plain codex exec. The removed --base/--title flags and their corresponding environment variables are cleanly excised with no orphaned references.

No high-severity findings.

Full review (click to expand)

Findings

🔴 HIGH

None.

🟡 MEDIUM

None.

🟢 LOW / NIT

L1. Stale BASE_SHA/PR_TITLE env vars remain in the pre-diff step — ai-review-analysis.yml:717-718, 1343-1344

• Issue: After this PR, the BASE_SHA and PR_TITLE env vars in the "Run Codex" steps are removed. However, these same variables remain defined in other steps (prompt-building at lines 446-447 and 1015-1016) where they are still actively used for git diff and prompt construction. This is not a bug — just noting for clarity that the remaining references are intentional and correct.

L2. Confirm codex exec without review subcommand accepts the prompt correctly

• Issue: The change assumes codex exec (without the review subcommand) still correctly processes the review prompt piped via stdin (- < /tmp/prompt.txt). The recovery steps (lines 754, 1386) and query path (line 1350) already use this pattern successfully, so this is consistent. Just worth a quick smoke test to confirm the review prompt format works without the --base/--title flags, since the PR title and base SHA are already embedded in the prompt text (lines 454-468).

Cross-Component Analysis

This change only affects CI workflow configuration. No RocksDB core code, public APIs, or database semantics are impacted.

Aspect	Assessment
Core DB code	Not affected
Public API	Not affected
Tests	Not affected
Build system	Not affected
CI workflow	Two Codex invocation sites updated consistently

Positive Observations

• The change makes all Codex invocations consistent — query, review, and recovery all now use codex exec without the review subcommand.
• Clean removal of unused environment variables with no orphaned references.
• The diff is minimal and easy to verify.

---

ℹ️ About this response

Generated by Claude Code.
Review methodology: claude_md/code_review.md

Limitations:

• Claude may miss context from files not in the diff
• Large PRs may be truncated
• Always apply human judgment to AI suggestions

Commands:

• /claude-review [context] — Request a code review
• /claude-query <question> — Ask about the PR or codebase