fixed crash compiling unknown rules operator

If a rule contained an unknown rule type or unknown operand, the daemon
crashed.

Issue: #1295

Author: gustavo-iniguez-goya

daemon/rule/loader.go

@@ -189,13 +189,13 @@ func (l *Loader) loadRule(fileName string) error {
 		}
 	} else {
 		if err := r.Operator.Compile(); err != nil {
-			log.Warning("Operator.Compile() error: %s: %s", err, r.Operator.Data)
+			log.Warning("Operator.Compile() error: %s: %s (%s)", err, r.Operator.Data, r.Name)
 			return fmt.Errorf("(1) Error compiling rule: %s", err)
 		}
 		if r.Operator.Type == List {
 			for i := 0; i < len(r.Operator.List); i++ {
 				if err := r.Operator.List[i].Compile(); err != nil {
-					log.Warning("Operator.Compile() error: %s: ", err)
+					log.Warning("Operator.Compile() error: %s (%s)", err, r.Name)
 					return fmt.Errorf("(1) Error compiling list rule: %s", err)
 				}
 			}

daemon/rule/operator.go

@@ -111,30 +111,6 @@ func (o *Operator) Compile() error {
 			return err
 		}
 		o.re = re
-	} else if o.Operand == OpDomainsLists {
-		if o.Data == "" {
-			return fmt.Errorf("Operand lists is empty, nothing to load: %s", o)
-		}
-		o.loadLists()
-		o.cb = o.domainsListCmp
-	} else if o.Operand == OpDomainsRegexpLists {
-		if o.Data == "" {
-			return fmt.Errorf("Operand regexp lists is empty, nothing to load: %s", o)
-		}
-		o.loadLists()
-		o.cb = o.reListCmp
-	} else if o.Operand == OpIPLists {
-		if o.Data == "" {
-			return fmt.Errorf("Operand ip lists is empty, nothing to load: %s", o)
-		}
-		o.loadLists()
-		o.cb = o.ipListCmp
-	} else if o.Operand == OpNetLists {
-		if o.Data == "" {
-			return fmt.Errorf("Operand net lists is empty, nothing to load: %s", o)
-		}
-		o.loadLists()
-		o.cb = o.ipNetCmp
 	} else if o.Type == List {
 		o.Operand = OpList
 	} else if o.Type == Network {
@@ -144,7 +120,31 @@ func (o *Operator) Compile() error {
 			return err
 		}
 		o.cb = o.cmpNetwork
+	} else if o.Type == Lists {
+		if o.Data == "" {
+			return fmt.Errorf("Operand lists is empty, nothing to load: %s", o)
+		}
+
+		if o.Operand == OpDomainsLists {
+			o.loadLists()
+			o.cb = o.domainsListCmp
+		} else if o.Operand == OpDomainsRegexpLists {
+			o.loadLists()
+			o.cb = o.reListCmp
+		} else if o.Operand == OpIPLists {
+			o.loadLists()
+			o.cb = o.ipListCmp
+		} else if o.Operand == OpNetLists {
+			o.loadLists()
+			o.cb = o.ipNetCmp
+		} else {
+			return fmt.Errorf("Unknown Lists operand: %s", o.Operand)
+		}
+
+	} else {
+		return fmt.Errorf("Unknown type: %s", o.Type)
 	}
+
 	log.Debug("Operator compiled: %s", o)
 	o.isCompiled = true