Update minimum supported node version

This change updates the minimum support node version for the generated
code and the for running the compiler to 18.20.4.

For the generated code this is a change from v12.22.9.

For the compiler this is a change from v18.3.

This new minimum is supported by both debian/stable and debian/oldstable
as well as the current Ubuntu 24.04 LTS (Noble Numbat).

Author: sbc100

.circleci/config.yml

@@ -106,11 +106,11 @@ commands:
             cat ~/emsdk/.emscripten
             echo "export PATH=\"$HOME/node-v${version}-linux-x64/bin:\$PATH\"" >> $BASH_ENV
   install-node-oldest:
-    description: "install node 12.22.9 (oldest)"
+    description: "install node 18.19.1 (oldest)"
     steps:
       - install-node-version:
           # Keep this in sync with `OLDEST_SUPPORTED_NODE` in `feature_matrix.py`
-          node_version: "12.22.9"
+          node_version: "18.19.1"
   install-node-lts:
     description: "install node 22.21.0 (current LTS)"
     steps:
@@ -962,16 +962,16 @@ jobs:
       # version.
       # Keep this in sync with MINIMUM_NODE_VERSION in tools/shared.py.
       - install-node-version:
-          node_version: "18.3.0"
+          node_version: "18.19.1"
       - run:
-          name: configure compiler to use 18.3.0
+          name: configure compiler to use 18.19.1
           command: echo "NODE_JS = '$(which node)'" >> ~/emsdk/.emscripten
       # Run some basic tests with the minimum version of node that we currently
       # support in the generated code.
       - install-node-oldest
       - run-tests:
-          title: "node (oldest / 12.22.9)"
-          extra-cflags: "-sMIN_NODE_VERSION=122209"
+          title: "node (oldest / 18.19.1)"
+          extra-cflags: "-sMIN_NODE_VERSION=181901"
           # We include most but not all of the nodefs and node rawfs tests here.
           # test_fs_nodefs_rw, test_fs_nodefs_statvfs, and test_unistd_io_nodefs_bigint fail.
           test_targets: "

ChangeLog.md

@@ -29,6 +29,8 @@ See docs/process.md for more on how version tagging works.
 - SDL3 port updated from 3.2.30 to 3.4.2 (#26572)
 - Fixed a race condition in syscall proxying that caused some hangs and ASan
   errors (#26582)
+- The minimum supported version of node (both for the running the generated
+  code and for running the compiler) was bumped to v18.19.1.
 
 5.0.4 - 03/23/26
 ----------------

site/source/docs/tools_reference/settings_reference.rst

@@ -2919,10 +2919,10 @@ MIN_NODE_VERSION
 Specifies minimum node version to target for the generated code.  This is
 distinct from the minimum version required to run the emscripten compiler.
 Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.01.
-Minimum supported value is 122209, which was released 2022-01-11 (see
-feature_matrix.py). This version aligns with the Ubuntu TLS 22.04 (Jammy).
+Minimum supported value is 189101, which was released 2024-02-14 (see
+feature_matrix.py). This version aligns with the Ubuntu TLS 24.04 (Noble).
 
-Default value: 160000
+Default value: 181901
 
 .. _minimal_runtime:
 

src/babel-plugins/strip-node-prefix.mjs

@@ -136,18 +136,6 @@ function updateMemoryViews() {
 #endif
 }
 
-#if ENVIRONMENT_MAY_BE_NODE && MIN_NODE_VERSION < 160000
-// The performance global was added to node in v16.0.0:
-// https://nodejs.org/api/globals.html#performance
-if (ENVIRONMENT_IS_NODE) {
-  // This is needed for emscripten_get_now and for pthreads support which
-  // depends on it for accurate timing.
-  // Use `global` rather than `globalThis` here since older versions of node
-  // don't have `globalThis`.
-  global.performance ??= require('perf_hooks').performance;
-}
-#endif
-
 #if IMPORTED_MEMORY
 // In non-standalone/normal mode, we create the memory here.
 #include "runtime_init_memory.js"

src/runtime_common.js

@@ -1920,9 +1920,9 @@ var MIN_CHROME_VERSION = 85;
 // Specifies minimum node version to target for the generated code.  This is
 // distinct from the minimum version required to run the emscripten compiler.
 // Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.01.
-// Minimum supported value is 122209, which was released 2022-01-11 (see
-// feature_matrix.py). This version aligns with the Ubuntu TLS 22.04 (Jammy).
-var MIN_NODE_VERSION = 160000;
+// Minimum supported value is 189101, which was released 2024-02-14 (see
+// feature_matrix.py). This version aligns with the Ubuntu TLS 24.04 (Noble).
+var MIN_NODE_VERSION = 181901;
 
 // If true, uses minimal sized runtime without POSIX features, Module,
 // preRun/preInit/etc., Emscripten built-in XHR loading or library_browser.js.

src/settings.js

@@ -28,7 +28,7 @@
 import line_endings
 from retryable_unittest import RetryableTestCase
 
-from tools import building, config, feature_matrix, shared, utils
+from tools import building, config, shared, utils
 from tools.feature_matrix import Feature
 from tools.settings import COMPILE_TIME_SETTINGS
 from tools.shared import DEBUG, EMCC, EMXX, get_canonical_temp_dir
@@ -147,15 +147,6 @@ def record_flaky_test(test_name, attempt_count, max_attempts, exception_msg):
     f.write(f'{test_name}\n')
 
 
-def node_bigint_flags(node_version):
-  # The --experimental-wasm-bigint flag was added in v12, and then removed (enabled by default)
-  # in v16.
-  if node_version and node_version < (16, 0, 0):
-    return ['--experimental-wasm-bigint']
-  else:
-    return []
-
-
 @contextlib.contextmanager
 def env_modify(updates):
   """A context manager that updates os.environ."""
@@ -457,11 +448,7 @@ def require_pthreads(self):
     if self.get_setting('MINIMAL_RUNTIME'):
       self.skipTest('non-browser pthreads not yet supported with MINIMAL_RUNTIME')
     for engine in self.js_engines:
-      if engine_is_node(engine):
-        if not self.try_require_node_version(16, 0, 0):
-          self.fail('node v16 required to run this test')
-        return
-      elif engine_is_bun(engine) or engine_is_deno(engine):
+      if engine_is_node(engine) or engine_is_bun(engine) or engine_is_deno(engine):
         self.require_engine(engine)
         return
     self.fail('no JS engine found capable of running pthreads')
@@ -531,23 +518,6 @@ def try_require_node_version(self, major, minor=0, revision=0):
     self.require_engine(nodejs)
     return True
 
-  def require_simd(self):
-    if 'EMTEST_SKIP_SIMD' in os.environ:
-      self.skipTest('test requires node >= 16 or d8 (and EMTEST_SKIP_SIMD is set)')
-    if self.is_browser_test():
-      return
-
-    if self.try_require_node_version(16):
-      return
-
-    v8 = get_v8()
-    if v8:
-      self.cflags.append('-sENVIRONMENT=shell')
-      self.require_engine(v8)
-      return
-
-    self.fail('either d8 or node >= 16 required to run wasm64 tests.  Use EMTEST_SKIP_SIMD to skip')
-
   def require_wasm_legacy_eh(self):
     if 'EMTEST_SKIP_WASM_LEGACY_EH' in os.environ:
       self.skipTest('test requires node >= 17 or d8 (and EMTEST_SKIP_WASM_LEGACY_EH is set)')
@@ -701,13 +671,6 @@ def setUp(self):
     nodejs = get_nodejs()
     if nodejs:
       node_version = shared.get_node_version(nodejs)
-      if node_version < (13, 0, 0):
-        self.node_args.append('--unhandled-rejections=strict')
-      elif node_version < (15, 0, 0):
-        # Opt in to node v15 default behaviour:
-        # https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode
-        self.node_args.append('--unhandled-rejections=throw')
-      self.node_args += node_bigint_flags(node_version)
 
       # If the version we are running tests in is lower than the version that
       # emcc targets then we need to tell emcc to target that older version.
@@ -719,12 +682,6 @@ def setUp(self):
       )
       if node_version < emcc_min_node_version:
         self.cflags.append('-sMIN_NODE_VERSION=%02d%02d%02d' % node_version)
-        self.cflags.append('-Wno-transpile')
-
-      # This allows much of the test suite to be run on older versions of node that don't
-      # support wasm bigint integration
-      if node_version[0] < feature_matrix.min_browser_versions[feature_matrix.Feature.JS_BIGINT_INTEGRATION]['node'] / 10000:
-        self.cflags.append('-sWASM_BIGINT=0')
 
     self.v8_args = ['--wasm-staging']
     self.env = {}

test/common.py

@@ -138,7 +138,6 @@ def wasm_simd(func):
 
   @wraps(func)
   def decorated(self, *args, **kwargs):
-    self.require_simd()
     if self.is_wasm2js():
       self.skipTest('wasm2js only supports MVP for now')
     if '-O3' in self.cflags:

test/test_core.py

@@ -13418,10 +13418,6 @@ def test_node_prefix_transpile(self):
     content = read_file('a.out.js')
     self.assertContained('node:', content)
 
-    self.run_process([EMCC, test_file('hello_world.c'), '-sEXPORT_ES6', '-sMIN_NODE_VERSION=150000', '-Wno-transpile'])
-    content = read_file('a.out.js')
-    self.assertNotContained('node:', content)
-
   def test_gmtime_noleak(self):
     # Confirm that gmtime_r does not leak when called in isolation.
     self.do_other_test('test_gmtime_noleak.c', cflags=['-fsanitize=leak'])

test/test_other.py

@@ -543,7 +543,6 @@ def transpile(filename):
   config = {
     'sourceType': 'script',
     'presets': ['@babel/preset-env'],
-    'plugins': [],
     'targets': {},
     'parserOpts': {
       # FIXME: Remove when updating to Babel 8, see:
@@ -559,7 +558,6 @@ def transpile(filename):
     config['targets']['safari'] = version_split(settings.MIN_SAFARI_VERSION)
   if settings.MIN_NODE_VERSION != UNSUPPORTED:
     config['targets']['node'] = version_split(settings.MIN_NODE_VERSION)
-    config['plugins'] = [path_from_root('src/babel-plugins/strip-node-prefix.mjs')]
   config_json = json.dumps(config, indent=2)
   outfile = shared.get_temp_files().get('babel.js').name
   config_file = shared.get_temp_files().get('babel_config.json').name