From f40b52cb6a15c37d5f5aef0efb5777bad0138dd8 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Sat, 9 May 2026 07:09:12 +0000 Subject: [PATCH] docs: reconcile detector trigger and migration status Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../multi-org-agentic-workflows.md | 18 +++++++++--------- ...e-not-accessible-by-integration-detector.md | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/architecture/multi-org-agentic-workflows.md b/docs/architecture/multi-org-agentic-workflows.md index 0c759d1..cd42163 100644 --- a/docs/architecture/multi-org-agentic-workflows.md +++ b/docs/architecture/multi-org-agentic-workflows.md @@ -44,7 +44,7 @@ Example: - **`workflow-id`** remains unique **within** that org’s `workflow-registry.json` (same as today per file). - **`enabled-workflows`** JSON passed to ingress uses **globally unique** entries in the **canonical** form **`org:workflow-id`** (e.g. `obs:agent-suggestions`, `docs:example-workflow`). Documented in [control-plane-dashboard-format.md](../operations/control-plane-dashboard-format.md). Ingress gating uses **`contains(fromJSON(...), 'org:workflow-id')`** with these exact strings. -Regex and tests in `sync_control_plane_dashboard.py` / `get_enabled_workflows.py` must be updated from the current two-part `oblt-aw:` pattern to this **three-part** pattern. +Regex and tests in `sync_control_plane_dashboard.py` / `get_enabled_workflows.py` are already updated to the three-part `` pattern (with legacy two-part compatibility for previously generated dashboards). --- @@ -122,15 +122,15 @@ scripts/ --- -## 8. Migration sketch (Observability → `obs`) +## 8. Migration status (Observability → `obs`) -1. Add **`config/obs/`** with folder name `obs`; move (or copy) registry + active-repositories from top-level config. **All current** registry entries and distribution targets map to **`obs`**. Top-level `config/*.json` aliases are now removed, so `config/obs/` is the source of truth. -2. Optionally add minimal **`config/docs/`** as a second org (e.g. for tests proving section order and merged enabled lists); org key **`docs`** is distinct from the repo **`docs/`** documentation folder. -3. Extend marker format to `` (and migrate existing marker lines in `tests/`, such as `test_sync_control_plane_dashboard.py` and `test_get_enabled_workflows.py`); dashboard sync rewrites consumer issue markers accordingly. -4. Refactor `sync_control_plane_dashboard.py` to **merge** org files into **one** issue body with sections; keep **one** label/title. -5. Refactor `get_enabled_workflows.py` for three-part markers, **`org:workflow-id`** output, and single-issue read. -6. Update **`oblt-aw-ingress.yml`** gating from bare ids to **`org:workflow-id`** strings. -7. Add tests with **two org folders** (e.g. `obs` + `docs`) proving section order and merged enabled list. +This migration is already implemented in this repository: + +1. `config/obs/` is the source of truth for Observability org configuration, and top-level `config/*.json` aliases are removed. +2. Marker format and parser behavior use org-aware identifiers (`` and `org:workflow-id`) with legacy two-part parsing support. +3. Dashboard sync merges org data into one issue body with one dashboard label/title. +4. Ingress gating uses compound `org:workflow-id` identifiers. +5. Tests cover org-aware parsing and dashboard generation, including multi-org section and marker handling. --- diff --git a/docs/workflows/gh-aw-resource-not-accessible-by-integration-detector.md b/docs/workflows/gh-aw-resource-not-accessible-by-integration-detector.md index 6486450..51f8712 100644 --- a/docs/workflows/gh-aw-resource-not-accessible-by-integration-detector.md +++ b/docs/workflows/gh-aw-resource-not-accessible-by-integration-detector.md @@ -21,7 +21,7 @@ The workflow uses two jobs: 2. **search** — Matrix job that calls `gh-aw-log-searching-agent` per workflow: - [elastic/ai-github-actions/.github/workflows/gh-aw-log-searching-agent.lock.yml@copilot/log-searching-agent-preflight](https://github.com/elastic/ai-github-actions/blob/copilot/log-searching-agent-preflight/.github/workflows/gh-aw-log-searching-agent.lock.yml) -The detector runs in each repository that invokes it (via ingress schedule or workflow_dispatch). +The detector is invoked by ingress only on scheduled runs (`github.event_name == schedule`). Ingress `workflow_dispatch` does not route this detector job. Configured parameters: