Missing COMPARAM references cause conversion failure. (even in lenient mode for project specific odx files)

[arvindr19]

Converter fails with "Couldn't find COMPARAM" error when COMPARAM-REF points to non-existent ID

Description

When ODX files contain COMPARAM-REF elements that reference non-existent COMPARAM IDs, the converter fails with an IllegalStateException. While lenient mode exists, there may be cases where references are broken or incomplete in real-world ODX files.

Error Message:

$java -jar converter/build/libs/converter-all.jar test-cases/issue2-missing-comparam.pdx
odx-converter - version: 0.1.0-SNAPSHOT

Processing issue2-missing-comparam.pdx
Error while processing issue2-missing-comparam.pdx: java.lang.IllegalStateException: Couldn't find COMPARAM cp-missing-999 @ SAMPLE_CPS
        at DatabaseWriter.offset(DatabaseWriter.kt:2113)
        at DatabaseWriter.offsetType(DatabaseWriter.kt:1600)
        at DatabaseWriter.offset(DatabaseWriter.kt:1612)
        at DatabaseWriter.<init>(DatabaseWriter.kt:226)
        at ChunkBuilder.createEcuDataChunk(ChunkBuilder.kt:120)
        at FileConverter.convert(Converter.kt:153)
        at Converter.run$lambda$4$lambda$3(Converter.kt:300)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
        at java.base/java.lang.Thread.run(Thread.java:1583)

Finished processing issue2-missing-comparam.pdx after 174.595983ms

Root Cause:
In DatabaseWriter.kt around line 2107-2113:

private fun COMPARAMREF.offset(): Int =
    cachedObjects.getOrPut(this) {
        val comParam = odx.comparams[this.idref]?.offset()
            ?: odx.complexComparams[this.idref]?.offset()

        if (comParam == null) {
            if (!options.lenient) {
                throw IllegalStateException("Couldn't find COMPARAM ${this.idref} @ ${this.docref}")
            }
            logger.warning("Couldn't find COMPARAM ${this.idref} @ ${this.docref}")
        }
        // ... continues but may have null comParam

Issue:

1. The lenient mode logs a warning but continues with a potentially null comParam
2. This may cause NullPointerException or incorrect data downstream
3. Better handling needed for missing references

Reproduction:
See attached test case: issue2-missing-comparam.pdx

---

attached odx & pdx for repro.

issue2-missing-comparam.zip

[floroks]

The underlying issue is that some odx files use the comparam definitions provided by ASAM, but don't provide the definition itself in the pdx. Since we can't provide the ASAM definitions as open source at the moment, to use them as fallback, we can't resolve those files, and this then makes the definition of the unit, in which a com param is overriden ambiguous. So we decided, that we have to guess it essentially in the CDA, and that's why the lenient mode was introduced.

The correct way is not to use the lenient-mode and have valid odx files, and ideally to provide the additional ASAM definitions in the future (once licensing terms have been revised by ASAM), and then to remove lenient mode. For the time it's needed to handle those files (as that's the reason it was actually introduced)

[floroks]

The added checks from @AnotherDaniel find issues with that odx file and abort earlier:

[2026-02-03 06:51:38.799Z] [SEVERE ] ODX error: [node=null,object=null,url=null,line=6,col=20,offset=-1] unexpected element (uri:"", local:"COMPARAMS"). Expected elements are <{}SHORT-NAME>,<{}LONG-NAME>,<{}DESC>,<{}ADMIN-DATA>,<{}COMPANY-DATAS>,<{}SDGS>,<{}PROT-STACKS>
[2026-02-03 06:51:38.808Z] [SEVERE ] ODX error: [node=null,object=null,url=null,line=11,col=32,offset=-1] unexpected element (uri:"", local:"VALUE"). Expected elements are <{}SIMPLE-VALUE>,<{}COMPLEX-VALUE>,<{}DESC>,<{}PROTOCOL-SNREF>,<{}PROT-STACK-SNREF>
[2026-02-03 06:51:38.812Z] [SEVERE ] Error while converting file issue2-missing-comparam.pdx: Errors were encountered while parsing the ODX file, see log for details, aborting:

can you reproduce the issue with a valid pdx file?

[arvindr19]

I am encountering an ODX error related to my project-specific PDX file (logs attached). Note that our project-specific ODX file is labeled MODEL-VERSION="2.0.1", while the ODX schema is version 2.2.0.
Since commit from @AnotherDaniel, the converter aborts on ANY schema validation errors.

Do I need ODX files that correspond to schema version 2.2.0? Shouldn't the ODX-converter support MODEL-VERSION="2.0.1"?

schema_validation.txt

[floroks]

We currently only support odx 2.2.0 from ISO 22901-1 (2008). Generally speaking, I'm open to PRs adding support for older revisions, but it might be quite a bit of work, and have licensing issues to reproduce (not sure if the older ODX specs were ever published through ISO).

To my knowledge, there are also commercial conversion tools available, which might be an option.

[KlausHartwig]

I had a lot of trials on my PDX files but not a single file was converted successfully (scheme version 2.2.0).
Is there somewhere a input-requirement documentation or are there some sample files?

[floroks]

For the conversion, we don't have support for cross-file references, and references through short-name are often not implemented and will result in a TODO error - you can generate a sample pdx file with the generate_docker.sh script in testcontainer/odx.

There are some additional requirements for the runtime execution in the CDA in terms of required communication parameters and links.